complement/tests/unknown_endpoints_test.go
kegsay a669c750c8
Remove Deployment.Client and change Deploy (#676)
* Remove Deployment.Client and change Deploy

- `Deployment.Client` was used to get pre-registered clients. Now we want tests to register new users for each test, for dirty runs. So swap for `Deployment.Register` everywhere.
- `Deploy` was used to deploy a blueprint. We don't want this to enable dirty runs. So replace it with the number of servers you need e.g `Deploy(t, 2)`.

* Fix up more broken refactoring

* unbreak tests; make user localpart look nicer

* Alice and bob must share a room for presence

* Fix user directory test

* Fix race condition caused by making the room later than before
2023-10-17 18:07:43 +01:00

87 lines
2.9 KiB
Go

package tests
import (
"net/http"
"testing"
"github.com/matrix-org/complement"
"github.com/matrix-org/complement/client"
"github.com/matrix-org/complement/helpers"
"github.com/matrix-org/complement/match"
"github.com/matrix-org/complement/must"
)
func queryUnknownEndpoint(t *testing.T, user *client.CSAPI, paths []string) {
t.Helper()
res := user.Do(t, "GET", paths)
must.MatchResponse(t, res, match.HTTPResponse{
StatusCode: http.StatusNotFound,
JSON: []match.JSON{
match.JSONKeyEqual("errcode", "M_UNRECOGNIZED"),
},
})
}
func queryUnknownMethod(t *testing.T, user *client.CSAPI, method string, paths []string) {
t.Helper()
res := user.Do(t, method, paths)
must.MatchResponse(t, res, match.HTTPResponse{
StatusCode: http.StatusMethodNotAllowed,
JSON: []match.JSON{
match.JSONKeyEqual("errcode", "M_UNRECOGNIZED"),
},
})
}
// Homeservers should return a 404 for unknown endpoints and 405 for incorrect
// methods to known endpoints.
func TestUnknownEndpoints(t *testing.T) {
deployment := complement.Deploy(t, 1)
defer deployment.Destroy(t)
alice := deployment.Register(t, "hs1", helpers.RegistrationOpts{})
// A completely unknown prefix to the matrix project.
t.Run("Unknown prefix", func(t *testing.T) {
queryUnknownEndpoint(t, alice, []string{"_matrix", "unknown"})
})
// Unknown client-server endpoints.
t.Run("Client-server endpoints", func(t *testing.T) {
queryUnknownEndpoint(t, alice, []string{"_matrix", "client", "unknown"})
// v1 should exist, but not v1/unknown.
queryUnknownEndpoint(t, alice, []string{"_matrix", "client", "v1", "unknown"})
queryUnknownEndpoint(t, alice, []string{"_matrix", "client", "v3", "room", "unknown"})
queryUnknownMethod(t, alice, "PUT", []string{"_matrix", "client", "v3", "login"})
})
// Unknown server-server endpoints.
t.Run("Server-server endpoints", func(t *testing.T) {
queryUnknownEndpoint(t, alice, []string{"_matrix", "federation", "unknown"})
// v1 should exist, but not v1/unknown.
queryUnknownEndpoint(t, alice, []string{"_matrix", "federation", "v1", "unknown"})
queryUnknownMethod(t, alice, "PUT", []string{"_matrix", "federation", "v1", "version"})
})
// Unknown key endpoints (part of the Server-server API under a different prefix).
t.Run("Key endpoints", func(t *testing.T) {
queryUnknownEndpoint(t, alice, []string{"_matrix", "key", "unknown"})
// v3 should exist, but not v3/unknown.
queryUnknownEndpoint(t, alice, []string{"_matrix", "key", "v2", "unknown"})
queryUnknownMethod(t, alice, "PUT", []string{"_matrix", "key", "v2", "query"})
})
// Unknown media endpoints.
t.Run("Media endpoints", func(t *testing.T) {
queryUnknownEndpoint(t, alice, []string{"_matrix", "media", "unknown"})
// v3 should exist, but not v3/unknown.
queryUnknownEndpoint(t, alice, []string{"_matrix", "media", "v3", "unknown"})
queryUnknownMethod(t, alice, "PATCH", []string{"_matrix", "media", "v3", "upload"})
})
}