forked from continuwuation/rocksdb
Summary: One of the parameters for constructing a Compaction object is `earliest_snapshot`, which is required for Standalone Range Deletion Optimization (introduced in [https://github.com/facebook/rocksdb/pull/13078](https://github.com/facebook/rocksdb/pull/13078)). Remote Compaction has been using the `CompactionPicker::CompactFiles()` API to create the Compaction object, but this API never sets the `earliest_snapshot` parameter. To address this, update `CompactionPicker::CompactFiles()` to optionally accept `earliest_snapshot` and pass it during the call in `DBImplSecondary::CompactWithoutInstallation()`. Pull Request resolved: https://github.com/facebook/rocksdb/pull/13816 Test Plan: ``` ./compaction_service_test --gtest_filter="*CompactionServiceTest.StandaloneDeleteRangeTombstoneOptimization*" ``` \+ Tested in Meta's internal offload infra. Reviewed By: hx235 Differential Revision: D79284769 Pulled By: jaykorean fbshipit-source-id: 164834ef6972d5e0ddfc2970bb9234ef166d6e52 |
||
|---|---|---|
| .. | ||
| compacted_db_impl.cc | ||
| compacted_db_impl.h | ||
| db_impl.cc | ||
| db_impl.h | ||
| db_impl_compaction_flush.cc | ||
| db_impl_debug.cc | ||
| db_impl_experimental.cc | ||
| db_impl_files.cc | ||
| db_impl_follower.cc | ||
| db_impl_follower.h | ||
| db_impl_open.cc | ||
| db_impl_readonly.cc | ||
| db_impl_readonly.h | ||
| db_impl_secondary.cc | ||
| db_impl_secondary.h | ||
| db_impl_write.cc | ||