forked from continuwuation/rocksdb
Summary: ... caused by public headers depending on build parameters (macro definitions). This change also adds a check under 'make check-headers' (already in CI) looking for potential future violations. I've audited the uses of '#if' in public headers and either * Eliminated them * Systematically excluded them because they are intentional or similar (details in comments in check-public-header.sh * Manually excluded them as being ODR-SAFE In the case of ROCKSDB_USING_THREAD_STATUS, there was no good reason for this to appear in public headers so I've replaced it with a static bool ThreadStatus::kEnabled. I considered getting rid of the ability to disable this code but some relatively recent PRs have been submitted for fixing that case. I've added a release note and updated one of the CI jobs to use this build configuration. (I didn't want to combine with some jobs like no_compression and status_checked because the interaction might limit what is checked. Pull Request resolved: https://github.com/facebook/rocksdb/pull/14096 Test Plan: manual 'make check-headers' + manual cmake as in new CI config + CI Reviewed By: jaykorean Differential Revision: D86241864 Pulled By: pdillinger fbshipit-source-id: d16addc9e3480706b174a006720a4def0740bf2e
219 lines
7.2 KiB
C++
219 lines
7.2 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#include "monitoring/thread_status_util.h"
|
|
|
|
#include "monitoring/thread_status_updater.h"
|
|
#include "rocksdb/env.h"
|
|
#include "rocksdb/system_clock.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
#ifndef NROCKSDB_THREAD_STATUS
|
|
thread_local ThreadStatusUpdater*
|
|
ThreadStatusUtil::thread_updater_local_cache_ = nullptr;
|
|
thread_local bool ThreadStatusUtil::thread_updater_initialized_ = false;
|
|
|
|
void ThreadStatusUtil::RegisterThread(const Env* env,
|
|
ThreadStatus::ThreadType thread_type) {
|
|
if (!MaybeInitThreadLocalUpdater(env)) {
|
|
return;
|
|
}
|
|
assert(thread_updater_local_cache_);
|
|
thread_updater_local_cache_->RegisterThread(thread_type, env->GetThreadID());
|
|
}
|
|
|
|
void ThreadStatusUtil::UnregisterThread() {
|
|
thread_updater_initialized_ = false;
|
|
if (thread_updater_local_cache_ != nullptr) {
|
|
thread_updater_local_cache_->UnregisterThread();
|
|
thread_updater_local_cache_ = nullptr;
|
|
}
|
|
}
|
|
|
|
void ThreadStatusUtil::SetEnableTracking(bool enable_tracking) {
|
|
if (thread_updater_local_cache_ == nullptr) {
|
|
return;
|
|
}
|
|
thread_updater_local_cache_->SetEnableTracking(enable_tracking);
|
|
}
|
|
|
|
void ThreadStatusUtil::SetColumnFamily(const ColumnFamilyData* cfd) {
|
|
if (thread_updater_local_cache_ == nullptr) {
|
|
return;
|
|
}
|
|
assert(cfd);
|
|
thread_updater_local_cache_->SetColumnFamilyInfoKey(cfd);
|
|
}
|
|
|
|
void ThreadStatusUtil::SetThreadOperation(ThreadStatus::OperationType op) {
|
|
if (thread_updater_local_cache_ == nullptr) {
|
|
return;
|
|
}
|
|
|
|
if (op != ThreadStatus::OP_UNKNOWN) {
|
|
uint64_t current_time = SystemClock::Default()->NowMicros();
|
|
thread_updater_local_cache_->SetOperationStartTime(current_time);
|
|
} else {
|
|
// TDOO(yhchiang): we could report the time when we set operation to
|
|
// OP_UNKNOWN once the whole instrumentation has been done.
|
|
thread_updater_local_cache_->SetOperationStartTime(0);
|
|
}
|
|
thread_updater_local_cache_->SetThreadOperation(op);
|
|
}
|
|
|
|
ThreadStatus::OperationType ThreadStatusUtil::GetThreadOperation() {
|
|
if (thread_updater_local_cache_ == nullptr) {
|
|
return ThreadStatus::OperationType::OP_UNKNOWN;
|
|
}
|
|
return thread_updater_local_cache_->GetThreadOperation();
|
|
}
|
|
|
|
ThreadStatus::OperationStage ThreadStatusUtil::SetThreadOperationStage(
|
|
ThreadStatus::OperationStage stage) {
|
|
if (thread_updater_local_cache_ == nullptr) {
|
|
// thread_updater_local_cache_ must be set in SetColumnFamily
|
|
// or other ThreadStatusUtil functions.
|
|
return ThreadStatus::STAGE_UNKNOWN;
|
|
}
|
|
|
|
return thread_updater_local_cache_->SetThreadOperationStage(stage);
|
|
}
|
|
|
|
void ThreadStatusUtil::SetThreadOperationProperty(int code, uint64_t value) {
|
|
if (thread_updater_local_cache_ == nullptr) {
|
|
// thread_updater_local_cache_ must be set in SetColumnFamily
|
|
// or other ThreadStatusUtil functions.
|
|
return;
|
|
}
|
|
|
|
thread_updater_local_cache_->SetThreadOperationProperty(code, value);
|
|
}
|
|
|
|
void ThreadStatusUtil::IncreaseThreadOperationProperty(int code,
|
|
uint64_t delta) {
|
|
if (thread_updater_local_cache_ == nullptr) {
|
|
// thread_updater_local_cache_ must be set in SetColumnFamily
|
|
// or other ThreadStatusUtil functions.
|
|
return;
|
|
}
|
|
|
|
thread_updater_local_cache_->IncreaseThreadOperationProperty(code, delta);
|
|
}
|
|
|
|
void ThreadStatusUtil::SetThreadState(ThreadStatus::StateType state) {
|
|
if (thread_updater_local_cache_ == nullptr) {
|
|
// thread_updater_local_cache_ must be set in SetColumnFamily
|
|
// or other ThreadStatusUtil functions.
|
|
return;
|
|
}
|
|
|
|
thread_updater_local_cache_->SetThreadState(state);
|
|
}
|
|
|
|
void ThreadStatusUtil::ResetThreadStatus() {
|
|
if (thread_updater_local_cache_ == nullptr) {
|
|
return;
|
|
}
|
|
thread_updater_local_cache_->ResetThreadStatus();
|
|
}
|
|
|
|
void ThreadStatusUtil::NewColumnFamilyInfo(const DB* db,
|
|
const ColumnFamilyData* cfd,
|
|
const std::string& cf_name,
|
|
const Env* env) {
|
|
if (!MaybeInitThreadLocalUpdater(env)) {
|
|
return;
|
|
}
|
|
assert(thread_updater_local_cache_);
|
|
if (thread_updater_local_cache_) {
|
|
thread_updater_local_cache_->NewColumnFamilyInfo(db, db->GetName(), cfd,
|
|
cf_name);
|
|
}
|
|
}
|
|
|
|
void ThreadStatusUtil::EraseColumnFamilyInfo(const ColumnFamilyData* cfd) {
|
|
if (thread_updater_local_cache_ == nullptr) {
|
|
return;
|
|
}
|
|
thread_updater_local_cache_->EraseColumnFamilyInfo(cfd);
|
|
}
|
|
|
|
void ThreadStatusUtil::EraseDatabaseInfo(const DB* db) {
|
|
ThreadStatusUpdater* thread_updater = db->GetEnv()->GetThreadStatusUpdater();
|
|
if (thread_updater == nullptr) {
|
|
return;
|
|
}
|
|
thread_updater->EraseDatabaseInfo(db);
|
|
}
|
|
|
|
bool ThreadStatusUtil::MaybeInitThreadLocalUpdater(const Env* env) {
|
|
if (!thread_updater_initialized_ && env != nullptr) {
|
|
thread_updater_initialized_ = true;
|
|
thread_updater_local_cache_ = env->GetThreadStatusUpdater();
|
|
}
|
|
return (thread_updater_local_cache_ != nullptr);
|
|
}
|
|
|
|
AutoThreadOperationStageUpdater::AutoThreadOperationStageUpdater(
|
|
ThreadStatus::OperationStage stage) {
|
|
prev_stage_ = ThreadStatusUtil::SetThreadOperationStage(stage);
|
|
}
|
|
|
|
AutoThreadOperationStageUpdater::~AutoThreadOperationStageUpdater() {
|
|
ThreadStatusUtil::SetThreadOperationStage(prev_stage_);
|
|
}
|
|
|
|
#else
|
|
|
|
ThreadStatusUpdater* ThreadStatusUtil::thread_updater_local_cache_ = nullptr;
|
|
bool ThreadStatusUtil::thread_updater_initialized_ = false;
|
|
|
|
void ThreadStatusUtil::RegisterThread(
|
|
const Env* /*env*/, ThreadStatus::ThreadType /*thread_type*/) {}
|
|
|
|
void ThreadStatusUtil::UnregisterThread() {}
|
|
|
|
void ThreadStatusUtil::SetEnableTracking(bool /*enable_tracking*/) {}
|
|
|
|
void ThreadStatusUtil::SetColumnFamily(const ColumnFamilyData* /*cfd*/) {}
|
|
|
|
ThreadStatus::OperationType ThreadStatusUtil::GetThreadOperation() {
|
|
return ThreadStatus::OperationType::OP_UNKNOWN;
|
|
}
|
|
|
|
void ThreadStatusUtil::SetThreadOperation(ThreadStatus::OperationType /*op*/) {}
|
|
|
|
void ThreadStatusUtil::SetThreadOperationProperty(int /*code*/,
|
|
uint64_t /*value*/) {}
|
|
|
|
void ThreadStatusUtil::IncreaseThreadOperationProperty(int /*code*/,
|
|
uint64_t /*delta*/) {}
|
|
|
|
void ThreadStatusUtil::SetThreadState(ThreadStatus::StateType /*state*/) {}
|
|
|
|
void ThreadStatusUtil::NewColumnFamilyInfo(const DB* /*db*/,
|
|
const ColumnFamilyData* /*cfd*/,
|
|
const std::string& /*cf_name*/,
|
|
const Env* /*env*/) {}
|
|
|
|
void ThreadStatusUtil::EraseColumnFamilyInfo(const ColumnFamilyData* /*cfd*/) {}
|
|
|
|
void ThreadStatusUtil::EraseDatabaseInfo(const DB* /*db*/) {}
|
|
|
|
void ThreadStatusUtil::ResetThreadStatus() {}
|
|
|
|
bool ThreadStatusUtil::MaybeInitThreadLocalUpdater(const Env* /*env*/) {
|
|
return false;
|
|
}
|
|
|
|
AutoThreadOperationStageUpdater::AutoThreadOperationStageUpdater(
|
|
ThreadStatus::OperationStage /*stage*/) {}
|
|
|
|
AutoThreadOperationStageUpdater::~AutoThreadOperationStageUpdater() {}
|
|
|
|
#endif // !NROCKSDB_THREAD_STATUS
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|