forked from continuwuation/rocksdb
799f83a934
Summary: **Context/Summary:** Internally `CompactionJobStats ::num_input_records` is only used for input record count [verification](1aca60c089/db/compaction/compaction_job.cc (L2535)) and such verification always checks for `CompactionJobStats::has_num_input_records` (now renamed) before using this field. This is needed because the `CompactionJobStats::num_input_records` gets its number from `CompactionIterator::NumInputEntryScanned()` in a subcompaction and this number can be inaccurate purposefully to increase performance, see [CompactionIterator::must_count_input_entries](https://github.com/facebook/rocksdb/pull/13929/files#diff-e6c876f655a21865c0f3dff94b9763f1bd40cf88a8a86f04868201b2e845a890R186-R199) for more. - This PR renames the `CompactionJobStats::has_num_input_records` to more explicit naming and adds more comments. Not a behavior change. Also, aggregation of `CompactionJobStats::has_num_input_records` among all subcompactions is done by [AND](1aca60c089/util/compaction_job_stats_impl.cc (L62)) operation so it's false if any of the subcompaction has this field being false. The default value of this field should be "true" in order to not mistakenly "false" by default. We are currently fine because `CompactionJobStats::Reset()` that [sets the value to be true](1aca60c089/util/compaction_job_stats_impl.cc (L14)) is always called before such aggregation. - This PR changes the default value to be true. - Resumable compaction development plans to set `CompactionJobStats::has_num_input_records` to be false if the previous compaction carries inaccurate records. In order for this not be overwritten by the subsequent progress in [here](1aca60c089/db/compaction/compaction_job.cc (L1540-L1543)), this PR also changes this = to AND operation and +=. With the default value `CompactionJobStats::has_num_input_records` now to be true (or Reset() already called) and `CompactionJobStats::num_input_records=0` already, this will not a behavior change. Pull Request resolved: https://github.com/facebook/rocksdb/pull/13929 Test Plan: - Existing UT to test "...changes the default value to be true" is safe. Reviewed By: jaykorean Differential Revision: D82014912 Pulled By: hx235 fbshipit-source-id: 6f211c3b2c9eb7d39abf37271d21a4d3f407b934
102 lines
3.1 KiB
C++
102 lines
3.1 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#include "rocksdb/compaction_job_stats.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
void CompactionJobStats::Reset() {
|
|
elapsed_micros = 0;
|
|
cpu_micros = 0;
|
|
|
|
has_accurate_num_input_records = true;
|
|
num_input_records = 0;
|
|
num_blobs_read = 0;
|
|
num_input_files = 0;
|
|
num_input_files_at_output_level = 0;
|
|
num_filtered_input_files = 0;
|
|
num_filtered_input_files_at_output_level = 0;
|
|
|
|
num_output_records = 0;
|
|
num_output_files = 0;
|
|
num_output_files_blob = 0;
|
|
|
|
is_full_compaction = false;
|
|
is_manual_compaction = false;
|
|
is_remote_compaction = false;
|
|
|
|
total_input_bytes = 0;
|
|
total_blob_bytes_read = 0;
|
|
total_output_bytes = 0;
|
|
total_output_bytes_blob = 0;
|
|
total_skipped_input_bytes = 0;
|
|
|
|
num_records_replaced = 0;
|
|
|
|
total_input_raw_key_bytes = 0;
|
|
total_input_raw_value_bytes = 0;
|
|
|
|
num_input_deletion_records = 0;
|
|
num_expired_deletion_records = 0;
|
|
|
|
num_corrupt_keys = 0;
|
|
|
|
file_write_nanos = 0;
|
|
file_range_sync_nanos = 0;
|
|
file_fsync_nanos = 0;
|
|
file_prepare_write_nanos = 0;
|
|
|
|
smallest_output_key_prefix.clear();
|
|
largest_output_key_prefix.clear();
|
|
|
|
num_single_del_fallthru = 0;
|
|
num_single_del_mismatch = 0;
|
|
}
|
|
|
|
void CompactionJobStats::Add(const CompactionJobStats& stats) {
|
|
elapsed_micros += stats.elapsed_micros;
|
|
cpu_micros += stats.cpu_micros;
|
|
|
|
has_accurate_num_input_records &= stats.has_accurate_num_input_records;
|
|
num_input_records += stats.num_input_records;
|
|
num_blobs_read += stats.num_blobs_read;
|
|
num_input_files += stats.num_input_files;
|
|
num_input_files_at_output_level += stats.num_input_files_at_output_level;
|
|
num_filtered_input_files += stats.num_filtered_input_files;
|
|
num_filtered_input_files_at_output_level +=
|
|
stats.num_filtered_input_files_at_output_level;
|
|
|
|
num_output_records += stats.num_output_records;
|
|
num_output_files += stats.num_output_files;
|
|
num_output_files_blob += stats.num_output_files_blob;
|
|
|
|
total_input_bytes += stats.total_input_bytes;
|
|
total_blob_bytes_read += stats.total_blob_bytes_read;
|
|
total_output_bytes += stats.total_output_bytes;
|
|
total_output_bytes_blob += stats.total_output_bytes_blob;
|
|
total_skipped_input_bytes += stats.total_skipped_input_bytes;
|
|
|
|
num_records_replaced += stats.num_records_replaced;
|
|
|
|
total_input_raw_key_bytes += stats.total_input_raw_key_bytes;
|
|
total_input_raw_value_bytes += stats.total_input_raw_value_bytes;
|
|
|
|
num_input_deletion_records += stats.num_input_deletion_records;
|
|
num_expired_deletion_records += stats.num_expired_deletion_records;
|
|
|
|
num_corrupt_keys += stats.num_corrupt_keys;
|
|
|
|
file_write_nanos += stats.file_write_nanos;
|
|
file_range_sync_nanos += stats.file_range_sync_nanos;
|
|
file_fsync_nanos += stats.file_fsync_nanos;
|
|
file_prepare_write_nanos += stats.file_prepare_write_nanos;
|
|
|
|
num_single_del_fallthru += stats.num_single_del_fallthru;
|
|
num_single_del_mismatch += stats.num_single_del_mismatch;
|
|
|
|
is_remote_compaction |= stats.is_remote_compaction;
|
|
}
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|