rocksdb/cache
Peter Dillinger ab6ba62eb1 Possible fix for CacheWithSecondaryAdapter assertion failures (#13747)
Summary:
Was reading sec_cache_res_ratio_ outside of mutex and using the result for computation that needs to be synchronized

Pull Request resolved: https://github.com/facebook/rocksdb/pull/13747

Test Plan: existing tests. Has been showing up in crash test, and there's no interesting concurrency here that would warrant a regression test based on sync points.

Reviewed By: cbi42

Differential Revision: D77607660

Pulled By: pdillinger

fbshipit-source-id: 12a71936b3558c7528d229a11c7d2e43982ad06b
2025-07-02 18:58:14 -07:00
..
cache.cc Standardize on clang-format version 18 (#13233) 2024-12-19 10:58:40 -08:00
cache_bench.cc Add (& fix) some simple source code checks (#8821) 2021-09-07 21:19:27 -07:00
cache_bench_tool.cc Standardize on clang-format version 18 (#13233) 2024-12-19 10:58:40 -08:00
cache_entry_roles.cc Major Cache refactoring, CPU efficiency improvement (#10975) 2023-01-11 14:20:40 -08:00
cache_entry_roles.h Major Cache refactoring, CPU efficiency improvement (#10975) 2023-01-11 14:20:40 -08:00
cache_entry_stats.h Simplify tracking entries already in SecondaryCache (#11299) 2023-03-15 17:51:44 -07:00
cache_helpers.cc Support compressed and local flash secondary cache stacking (#11812) 2023-09-21 20:30:53 -07:00
cache_helpers.h Put Cache and CacheWrapper in new public header (#11192) 2023-02-09 12:12:02 -08:00
cache_key.cc Put Cache and CacheWrapper in new public header (#11192) 2023-02-09 12:12:02 -08:00
cache_key.h Derive cache keys from SST unique IDs (#10394) 2022-08-12 13:49:49 -07:00
cache_reservation_manager.cc Simplify tracking entries already in SecondaryCache (#11299) 2023-03-15 17:51:44 -07:00
cache_reservation_manager.h Fix updating the capacity of a tiered cache (#11873) 2023-09-22 18:07:46 -07:00
cache_reservation_manager_test.cc Remove extra semi colon from icsp/lib/logging/IcspLogRpcMessage.cpp 2024-03-31 10:26:34 -07:00
cache_test.cc Provide a way to invoke a callback for a Cache handle (#12987) 2024-09-06 14:54:09 -07:00
charged_cache.cc Support compressed and local flash secondary cache stacking (#11812) 2023-09-21 20:30:53 -07:00
charged_cache.h Support compressed and local flash secondary cache stacking (#11812) 2023-09-21 20:30:53 -07:00
clock_cache.cc Provide a way to invoke a callback for a Cache handle (#12987) 2024-09-06 14:54:09 -07:00
clock_cache.h Provide a way to invoke a callback for a Cache handle (#12987) 2024-09-06 14:54:09 -07:00
compressed_secondary_cache.cc Publish/support format_version=7, related enhancements (#13713) 2025-06-20 17:39:47 -07:00
compressed_secondary_cache.h Big refactor for preliminary custom compression API (#13540) 2025-05-15 17:14:23 -07:00
compressed_secondary_cache_test.cc Standardize on clang-format version 18 (#13233) 2024-12-19 10:58:40 -08:00
lru_cache.cc Standardize on clang-format version 18 (#13233) 2024-12-19 10:58:40 -08:00
lru_cache.h Provide a way to invoke a callback for a Cache handle (#12987) 2024-09-06 14:54:09 -07:00
lru_cache_test.cc Standardize on clang-format version 18 (#13233) 2024-12-19 10:58:40 -08:00
secondary_cache.cc Standardize on clang-format version 18 (#13233) 2024-12-19 10:58:40 -08:00
secondary_cache_adapter.cc Possible fix for CacheWithSecondaryAdapter assertion failures (#13747) 2025-07-02 18:58:14 -07:00
secondary_cache_adapter.h Make CacheWithSecondaryAdapter reservation accounting more robust (#12059) 2023-11-14 16:25:52 -08:00
sharded_cache.cc Add APIs to query secondary cache capacity and usage for TieredCache (#12011) 2023-10-25 16:54:50 -07:00
sharded_cache.h Prefer static_cast in place of most reinterpret_cast (#12308) 2024-02-07 10:44:11 -08:00
tiered_secondary_cache.cc Add some compressed and tiered secondary cache stats (#12150) 2023-12-15 11:34:08 -08:00
tiered_secondary_cache.h Remove 'virtual' when implied by 'override' (#12319) 2024-01-31 13:14:42 -08:00
tiered_secondary_cache_test.cc Update test implementations for MultiRead with fs_scratch reuse (#13195) 2024-12-17 16:36:04 -08:00
typed_cache.h Prefer static_cast in place of most reinterpret_cast (#12308) 2024-02-07 10:44:11 -08:00