1ba60ee9ee
Summary: PR https://github.com/facebook/rocksdb/issues/14266 ("Remove compression support") removed compression-related functionality from blob_dump_tool and ldb commands. While this was valid for the legacy stacked BlobDB (which no longer supports compression), the integrated blob storage (`enable_blob_files`) uses the same blob file format and fully supports compression via `blob_compression_type`. This partial revert restores the ability to view uncompressed blob data from compressed blob files, which is essential for debugging and analysis of integrated blob storage. Restored functionality: - `blob_dump --show_uncompressed_blob` option - `ldb dump --dump_uncompressed_blobs` option - `ldb dump_live_files --dump_uncompressed_blobs` option - Related ldb_test.py test coverage The decompression implementation in utilities/blob_db/blob_dump_tool.cc has been updated to use the modern `GetBuiltinV2CompressionManager()->GetDecompressorOptimizeFor()` API. Suggested follow-up: * Tests for blob_dump (or integrate it into sst_dump/ldb?) Pull Request resolved: https://github.com/facebook/rocksdb/pull/14382 Test Plan: Restored ldb_test.py Some manual testing Reviewed By: mszeszko-meta Differential Revision: D94257588 Pulled By: pdillinger fbshipit-source-id: c6d8a556a51ec9422df208ae161806ccc1f20b36
103 lines
3.1 KiB
C++
103 lines
3.1 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#include <getopt.h>
|
|
|
|
#include <cstdio>
|
|
#include <string>
|
|
#include <unordered_map>
|
|
|
|
#include "utilities/blob_db/blob_dump_tool.h"
|
|
|
|
using ROCKSDB_NAMESPACE::Status;
|
|
using ROCKSDB_NAMESPACE::blob_db::BlobDumpTool;
|
|
|
|
int main(int argc, char** argv) {
|
|
using DisplayType = BlobDumpTool::DisplayType;
|
|
const std::unordered_map<std::string, DisplayType> display_types = {
|
|
{"none", DisplayType::kNone},
|
|
{"raw", DisplayType::kRaw},
|
|
{"hex", DisplayType::kHex},
|
|
{"detail", DisplayType::kDetail},
|
|
};
|
|
const struct option options[] = {
|
|
{"help", no_argument, nullptr, 'h'},
|
|
{"file", required_argument, nullptr, 'f'},
|
|
{"show_key", optional_argument, nullptr, 'k'},
|
|
{"show_blob", optional_argument, nullptr, 'b'},
|
|
{"show_uncompressed_blob", optional_argument, nullptr, 'r'},
|
|
{"show_summary", optional_argument, nullptr, 's'},
|
|
};
|
|
DisplayType show_key = DisplayType::kRaw;
|
|
DisplayType show_blob = DisplayType::kNone;
|
|
DisplayType show_uncompressed_blob = DisplayType::kNone;
|
|
bool show_summary = false;
|
|
std::string file;
|
|
while (true) {
|
|
int c = getopt_long(argc, argv, "hk::b::f:", options, nullptr);
|
|
if (c < 0) {
|
|
break;
|
|
}
|
|
std::string arg_str(optarg ? optarg : "");
|
|
switch (c) {
|
|
case 'h':
|
|
fprintf(stdout,
|
|
"Usage: blob_dump --file=filename "
|
|
"[--show_key[=none|raw|hex|detail]] "
|
|
"[--show_blob[=none|raw|hex|detail]] "
|
|
"[--show_uncompressed_blob[=none|raw|hex|detail]] "
|
|
"[--show_summary]\n");
|
|
return 0;
|
|
case 'f':
|
|
file = optarg;
|
|
break;
|
|
case 'k':
|
|
if (optarg) {
|
|
if (display_types.count(arg_str) == 0) {
|
|
fprintf(stderr, "Unrecognized key display type.\n");
|
|
return -1;
|
|
}
|
|
show_key = display_types.at(arg_str);
|
|
}
|
|
break;
|
|
case 'b':
|
|
if (optarg) {
|
|
if (display_types.count(arg_str) == 0) {
|
|
fprintf(stderr, "Unrecognized blob display type.\n");
|
|
return -1;
|
|
}
|
|
show_blob = display_types.at(arg_str);
|
|
} else {
|
|
show_blob = DisplayType::kHex;
|
|
}
|
|
break;
|
|
case 'r':
|
|
if (optarg) {
|
|
if (display_types.count(arg_str) == 0) {
|
|
fprintf(stderr, "Unrecognized blob display type.\n");
|
|
return -1;
|
|
}
|
|
show_uncompressed_blob = display_types.at(arg_str);
|
|
} else {
|
|
show_uncompressed_blob = DisplayType::kHex;
|
|
}
|
|
break;
|
|
case 's':
|
|
show_summary = true;
|
|
break;
|
|
default:
|
|
fprintf(stderr, "Unrecognized option.\n");
|
|
return -1;
|
|
}
|
|
}
|
|
BlobDumpTool tool;
|
|
Status s =
|
|
tool.Run(file, show_key, show_blob, show_uncompressed_blob, show_summary);
|
|
if (!s.ok()) {
|
|
fprintf(stderr, "Failed: %s\n", s.ToString().c_str());
|
|
return -1;
|
|
}
|
|
return 0;
|
|
}
|