1ba60ee9ee
Summary: PR https://github.com/facebook/rocksdb/issues/14266 ("Remove compression support") removed compression-related functionality from blob_dump_tool and ldb commands. While this was valid for the legacy stacked BlobDB (which no longer supports compression), the integrated blob storage (`enable_blob_files`) uses the same blob file format and fully supports compression via `blob_compression_type`. This partial revert restores the ability to view uncompressed blob data from compressed blob files, which is essential for debugging and analysis of integrated blob storage. Restored functionality: - `blob_dump --show_uncompressed_blob` option - `ldb dump --dump_uncompressed_blobs` option - `ldb dump_live_files --dump_uncompressed_blobs` option - Related ldb_test.py test coverage The decompression implementation in utilities/blob_db/blob_dump_tool.cc has been updated to use the modern `GetBuiltinV2CompressionManager()->GetDecompressorOptimizeFor()` API. Suggested follow-up: * Tests for blob_dump (or integrate it into sst_dump/ldb?) Pull Request resolved: https://github.com/facebook/rocksdb/pull/14382 Test Plan: Restored ldb_test.py Some manual testing Reviewed By: mszeszko-meta Differential Revision: D94257588 Pulled By: pdillinger fbshipit-source-id: c6d8a556a51ec9422df208ae161806ccc1f20b36
55 lines
1.7 KiB
C++
55 lines
1.7 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
#pragma once
|
|
|
|
#include <memory>
|
|
#include <string>
|
|
#include <utility>
|
|
|
|
#include "db/blob/blob_log_format.h"
|
|
#include "file/random_access_file_reader.h"
|
|
#include "rocksdb/slice.h"
|
|
#include "rocksdb/status.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
namespace blob_db {
|
|
|
|
class BlobDumpTool {
|
|
public:
|
|
enum class DisplayType {
|
|
kNone,
|
|
kRaw,
|
|
kHex,
|
|
kDetail,
|
|
};
|
|
|
|
BlobDumpTool();
|
|
|
|
Status Run(const std::string& filename, DisplayType show_key,
|
|
DisplayType show_blob, DisplayType show_uncompressed_blob,
|
|
bool show_summary);
|
|
|
|
private:
|
|
std::unique_ptr<RandomAccessFileReader> reader_;
|
|
std::unique_ptr<char[]> buffer_;
|
|
size_t buffer_size_;
|
|
|
|
Status Read(uint64_t offset, size_t size, Slice* result);
|
|
Status DumpBlobLogHeader(uint64_t* offset, CompressionType* compression);
|
|
Status DumpBlobLogFooter(uint64_t file_size, uint64_t* footer_offset);
|
|
Status DumpRecord(DisplayType show_key, DisplayType show_blob,
|
|
DisplayType show_uncompressed_blob, bool show_summary,
|
|
CompressionType compression, uint64_t* offset,
|
|
uint64_t* total_records, uint64_t* total_key_size,
|
|
uint64_t* total_blob_size,
|
|
uint64_t* total_uncompressed_blob_size);
|
|
void DumpSlice(const Slice s, DisplayType type);
|
|
|
|
template <class T>
|
|
std::string GetString(std::pair<T, T> p);
|
|
};
|
|
|
|
} // namespace blob_db
|
|
} // namespace ROCKSDB_NAMESPACE
|