Summary: This PR does two things: 1. Adds a new table property `newest_key_time` 2. Uses this property to improve TTL and temperature change compaction. ### Context The current `creation_time` table property should really be named `oldest_ancestor_time`. For flush output files, this is the oldest key time in the file. For compaction output files, this is the minimum among all oldest key times in the input files. The problem with using the oldest ancestor time for TTL compaction is that we may end up dropping files earlier than we should. What we really want is the newest (i.e. "youngest") key time. Right now we take a roundabout way to estimate this value -- we take the value of the _oldest_ key time for the _next_ (newer) SST file. This is also why the current code has checks for `index >= 1`. Our new property `newest_key_time` is set to the file creation time during flushes, and the max over all input files for compactions. There were some additional smaller changes that I had to make for testing purposes: - Refactoring the mock table reader to support specifying my own table properties - Refactoring out a test utility method `GetLevelFileMetadatas` that would otherwise be copy/pasted in 3 places Credit to cbi42 for the problem explanation and proposed solution ### Testing - Added a dedicated unit test to my `newest_key_time` logic in isolation (i.e. are we populating the property on flush and compaction) - Updated the existing unit tests (for TTL/temperate change compaction), which were comprehensive enough to break when I first made my code changes. I removed the test setup code which set the file metadata `oldest_ancestor_time`, so we know we are actually only using the new table property instead. Pull Request resolved: https://github.com/facebook/rocksdb/pull/13083 Reviewed By: cbi42 Differential Revision: D65298604 Pulled By: archang19 fbshipit-source-id: 898ef91b692ab33f5129a2a16b64ecadd4c32432
619 lines
20 KiB
C++
619 lines
20 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
//
|
|
// Copyright (c) 2012 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
#include <cstdint>
|
|
|
|
#include "db/wide/wide_column_serialization.h"
|
|
#include "file/random_access_file_reader.h"
|
|
#include "port/stack_trace.h"
|
|
#include "rocksdb/convenience.h"
|
|
#include "rocksdb/filter_policy.h"
|
|
#include "rocksdb/sst_dump_tool.h"
|
|
#include "table/block_based/block_based_table_factory.h"
|
|
#include "table/sst_file_dumper.h"
|
|
#include "table/table_builder.h"
|
|
#include "test_util/testharness.h"
|
|
#include "test_util/testutil.h"
|
|
#include "util/defer.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
const uint32_t kOptLength = 1024;
|
|
|
|
namespace {
|
|
static std::string MakeKey(int i,
|
|
ValueType value_type = ValueType::kTypeValue) {
|
|
char buf[100];
|
|
snprintf(buf, sizeof(buf), "k_%04d", i);
|
|
InternalKey key(std::string(buf), 0, value_type);
|
|
return key.Encode().ToString();
|
|
}
|
|
|
|
static std::string MakeKeyWithTimeStamp(int i, uint64_t ts) {
|
|
char buf[100];
|
|
snprintf(buf, sizeof(buf), "k_%04d", i);
|
|
return test::KeyStr(ts, std::string(buf), /*seq=*/0, kTypeValue);
|
|
}
|
|
|
|
static std::string MakeValue(int i) {
|
|
char buf[100];
|
|
snprintf(buf, sizeof(buf), "v_%04d", i);
|
|
InternalKey key(std::string(buf), 0, ValueType::kTypeValue);
|
|
return key.Encode().ToString();
|
|
}
|
|
|
|
static std::string MakeWideColumn(int i) {
|
|
std::string val = MakeValue(i);
|
|
std::string val1 = "attr_1_val_" + val;
|
|
std::string val2 = "attr_2_val_" + val;
|
|
WideColumns columns{{"attr_1", val1}, {"attr_2", val2}};
|
|
std::string entity;
|
|
EXPECT_OK(WideColumnSerialization::Serialize(columns, entity));
|
|
return entity;
|
|
}
|
|
|
|
void cleanup(const Options& opts, const std::string& file_name) {
|
|
Env* env = opts.env;
|
|
ASSERT_OK(env->DeleteFile(file_name));
|
|
std::string outfile_name = file_name.substr(0, file_name.length() - 4);
|
|
outfile_name.append("_dump.txt");
|
|
env->DeleteFile(outfile_name).PermitUncheckedError();
|
|
}
|
|
} // namespace
|
|
|
|
// Test for sst dump tool "raw" mode
|
|
class SSTDumpToolTest : public testing::Test {
|
|
std::string test_dir_;
|
|
Env* env_;
|
|
std::shared_ptr<Env> env_guard_;
|
|
|
|
public:
|
|
SSTDumpToolTest() : env_(Env::Default()) {
|
|
EXPECT_OK(test::CreateEnvFromSystem(ConfigOptions(), &env_, &env_guard_));
|
|
test_dir_ = test::PerThreadDBPath(env_, "sst_dump_test_db");
|
|
Status s = env_->CreateDirIfMissing(test_dir_);
|
|
EXPECT_OK(s);
|
|
}
|
|
|
|
~SSTDumpToolTest() override {
|
|
if (getenv("KEEP_DB")) {
|
|
fprintf(stdout, "Data is still at %s\n", test_dir_.c_str());
|
|
} else {
|
|
EXPECT_OK(env_->DeleteDir(test_dir_));
|
|
}
|
|
}
|
|
|
|
Env* env() { return env_; }
|
|
|
|
std::string MakeFilePath(const std::string& file_name) const {
|
|
std::string path(test_dir_);
|
|
path.append("/").append(file_name);
|
|
return path;
|
|
}
|
|
|
|
template <std::size_t N>
|
|
void PopulateCommandArgs(const std::string& file_path, const char* command,
|
|
char* (&usage)[N]) const {
|
|
for (int i = 0; i < static_cast<int>(N); ++i) {
|
|
usage[i] = new char[kOptLength];
|
|
}
|
|
snprintf(usage[0], kOptLength, "./sst_dump");
|
|
snprintf(usage[1], kOptLength, "%s", command);
|
|
snprintf(usage[2], kOptLength, "--file=%s", file_path.c_str());
|
|
}
|
|
|
|
void createSST(const Options& opts, const std::string& file_name,
|
|
uint32_t wide_column_one_in = 0, bool range_del = false) {
|
|
Env* test_env = opts.env;
|
|
FileOptions file_options(opts);
|
|
ReadOptions read_options;
|
|
const ImmutableOptions imoptions(opts);
|
|
const MutableCFOptions moptions(opts);
|
|
ROCKSDB_NAMESPACE::InternalKeyComparator ikc(opts.comparator);
|
|
std::unique_ptr<TableBuilder> tb;
|
|
|
|
InternalTblPropCollFactories internal_tbl_prop_coll_factories;
|
|
std::unique_ptr<WritableFileWriter> file_writer;
|
|
ASSERT_OK(WritableFileWriter::Create(test_env->GetFileSystem(), file_name,
|
|
file_options, &file_writer, nullptr));
|
|
|
|
std::string column_family_name;
|
|
int unknown_level = -1;
|
|
const WriteOptions write_options;
|
|
tb.reset(opts.table_factory->NewTableBuilder(
|
|
TableBuilderOptions(
|
|
imoptions, moptions, read_options, write_options, ikc,
|
|
&internal_tbl_prop_coll_factories, CompressionType::kNoCompression,
|
|
CompressionOptions(),
|
|
TablePropertiesCollectorFactory::Context::kUnknownColumnFamily,
|
|
column_family_name, unknown_level, kUnknownNewestKeyTime),
|
|
file_writer.get()));
|
|
|
|
// Populate slightly more than 1K keys
|
|
uint32_t num_keys = kNumKey;
|
|
const char* comparator_name = ikc.user_comparator()->Name();
|
|
if (strcmp(comparator_name, ReverseBytewiseComparator()->Name()) == 0) {
|
|
for (int32_t i = num_keys; i > 0; i--) {
|
|
if (wide_column_one_in == 0 || i % wide_column_one_in != 0) {
|
|
tb->Add(MakeKey(i), MakeValue(i));
|
|
} else {
|
|
tb->Add(MakeKey(i, ValueType::kTypeWideColumnEntity),
|
|
MakeWideColumn(i));
|
|
}
|
|
}
|
|
} else if (strcmp(comparator_name,
|
|
test::BytewiseComparatorWithU64TsWrapper()->Name()) ==
|
|
0) {
|
|
for (uint32_t i = 0; i < num_keys; i++) {
|
|
tb->Add(MakeKeyWithTimeStamp(i, 100 + i), MakeValue(i));
|
|
}
|
|
} else {
|
|
uint32_t i = 0;
|
|
if (range_del) {
|
|
tb->Add(MakeKey(i, kTypeRangeDeletion), MakeValue(i + 1));
|
|
i = 1;
|
|
}
|
|
for (; i < num_keys; i++) {
|
|
if (wide_column_one_in == 0 || i % wide_column_one_in != 0) {
|
|
tb->Add(MakeKey(i), MakeValue(i));
|
|
} else {
|
|
tb->Add(MakeKey(i, ValueType::kTypeWideColumnEntity),
|
|
MakeWideColumn(i));
|
|
}
|
|
}
|
|
}
|
|
ASSERT_OK(tb->Finish());
|
|
ASSERT_OK(file_writer->Close(IOOptions()));
|
|
}
|
|
|
|
protected:
|
|
constexpr static int kNumKey = 1024;
|
|
};
|
|
|
|
constexpr int SSTDumpToolTest::kNumKey;
|
|
|
|
TEST_F(SSTDumpToolTest, HelpAndVersion) {
|
|
Options opts;
|
|
opts.env = env();
|
|
|
|
ROCKSDB_NAMESPACE::SSTDumpTool tool;
|
|
|
|
static const char* help[] = {"./sst_dump", "--help"};
|
|
ASSERT_TRUE(!tool.Run(2, help, opts));
|
|
static const char* version[] = {"./sst_dump", "--version"};
|
|
ASSERT_TRUE(!tool.Run(2, version, opts));
|
|
static const char* bad[] = {"./sst_dump", "--not_an_option"};
|
|
ASSERT_TRUE(tool.Run(2, bad, opts));
|
|
}
|
|
|
|
TEST_F(SSTDumpToolTest, EmptyFilter) {
|
|
Options opts;
|
|
opts.env = env();
|
|
std::string file_path = MakeFilePath("rocksdb_sst_test.sst");
|
|
createSST(opts, file_path, 10);
|
|
|
|
char* usage[3];
|
|
PopulateCommandArgs(file_path, "--command=raw", usage);
|
|
|
|
ROCKSDB_NAMESPACE::SSTDumpTool tool;
|
|
ASSERT_TRUE(!tool.Run(3, usage, opts));
|
|
|
|
cleanup(opts, file_path);
|
|
for (int i = 0; i < 3; i++) {
|
|
delete[] usage[i];
|
|
}
|
|
}
|
|
|
|
TEST_F(SSTDumpToolTest, SstDumpReverseBytewiseComparator) {
|
|
Options opts;
|
|
opts.env = env();
|
|
opts.comparator = ReverseBytewiseComparator();
|
|
BlockBasedTableOptions table_opts;
|
|
table_opts.filter_policy.reset(
|
|
ROCKSDB_NAMESPACE::NewBloomFilterPolicy(10, false));
|
|
opts.table_factory.reset(new BlockBasedTableFactory(table_opts));
|
|
std::string file_path =
|
|
MakeFilePath("rocksdb_sst_reverse_bytewise_comparator.sst");
|
|
createSST(opts, file_path);
|
|
|
|
char* usage[3];
|
|
PopulateCommandArgs(file_path, "--command=raw", usage);
|
|
|
|
ROCKSDB_NAMESPACE::SSTDumpTool tool;
|
|
ASSERT_TRUE(!tool.Run(3, usage, opts));
|
|
|
|
cleanup(opts, file_path);
|
|
for (int i = 0; i < 3; i++) {
|
|
delete[] usage[i];
|
|
}
|
|
}
|
|
|
|
TEST_F(SSTDumpToolTest, SstDumpComparatorWithU64Ts) {
|
|
Options opts;
|
|
opts.env = env();
|
|
opts.comparator = test::BytewiseComparatorWithU64TsWrapper();
|
|
BlockBasedTableOptions table_opts;
|
|
table_opts.filter_policy.reset(
|
|
ROCKSDB_NAMESPACE::NewBloomFilterPolicy(10, false));
|
|
opts.table_factory.reset(new BlockBasedTableFactory(table_opts));
|
|
std::string file_path =
|
|
MakeFilePath("rocksdb_sst_comparator_with_u64_ts.sst");
|
|
createSST(opts, file_path, 10);
|
|
|
|
char* usage[3];
|
|
PopulateCommandArgs(file_path, "--command=raw", usage);
|
|
|
|
ROCKSDB_NAMESPACE::SSTDumpTool tool;
|
|
ASSERT_TRUE(!tool.Run(3, usage, opts));
|
|
|
|
cleanup(opts, file_path);
|
|
for (int i = 0; i < 3; i++) {
|
|
delete[] usage[i];
|
|
}
|
|
}
|
|
|
|
TEST_F(SSTDumpToolTest, FilterBlock) {
|
|
Options opts;
|
|
opts.env = env();
|
|
BlockBasedTableOptions table_opts;
|
|
table_opts.filter_policy.reset(
|
|
ROCKSDB_NAMESPACE::NewBloomFilterPolicy(10, true));
|
|
opts.table_factory.reset(new BlockBasedTableFactory(table_opts));
|
|
std::string file_path = MakeFilePath("rocksdb_sst_test.sst");
|
|
createSST(opts, file_path, 10);
|
|
|
|
char* usage[3];
|
|
PopulateCommandArgs(file_path, "--command=raw", usage);
|
|
|
|
ROCKSDB_NAMESPACE::SSTDumpTool tool;
|
|
ASSERT_TRUE(!tool.Run(3, usage, opts));
|
|
|
|
cleanup(opts, file_path);
|
|
for (int i = 0; i < 3; i++) {
|
|
delete[] usage[i];
|
|
}
|
|
}
|
|
|
|
TEST_F(SSTDumpToolTest, FullFilterBlock) {
|
|
Options opts;
|
|
opts.env = env();
|
|
BlockBasedTableOptions table_opts;
|
|
table_opts.filter_policy.reset(
|
|
ROCKSDB_NAMESPACE::NewBloomFilterPolicy(10, false));
|
|
opts.table_factory.reset(new BlockBasedTableFactory(table_opts));
|
|
std::string file_path = MakeFilePath("rocksdb_sst_test.sst");
|
|
createSST(opts, file_path);
|
|
|
|
char* usage[3];
|
|
PopulateCommandArgs(file_path, "--command=raw", usage);
|
|
|
|
ROCKSDB_NAMESPACE::SSTDumpTool tool;
|
|
ASSERT_TRUE(!tool.Run(3, usage, opts));
|
|
|
|
cleanup(opts, file_path);
|
|
for (int i = 0; i < 3; i++) {
|
|
delete[] usage[i];
|
|
}
|
|
}
|
|
|
|
TEST_F(SSTDumpToolTest, GetProperties) {
|
|
Options opts;
|
|
opts.env = env();
|
|
BlockBasedTableOptions table_opts;
|
|
table_opts.filter_policy.reset(
|
|
ROCKSDB_NAMESPACE::NewBloomFilterPolicy(10, false));
|
|
opts.table_factory.reset(new BlockBasedTableFactory(table_opts));
|
|
std::string file_path = MakeFilePath("rocksdb_sst_test.sst");
|
|
createSST(opts, file_path);
|
|
|
|
char* usage[3];
|
|
PopulateCommandArgs(file_path, "--show_properties", usage);
|
|
|
|
ROCKSDB_NAMESPACE::SSTDumpTool tool;
|
|
ASSERT_TRUE(!tool.Run(3, usage, opts));
|
|
|
|
cleanup(opts, file_path);
|
|
for (int i = 0; i < 3; i++) {
|
|
delete[] usage[i];
|
|
}
|
|
}
|
|
|
|
TEST_F(SSTDumpToolTest, CompressedSizes) {
|
|
Options opts;
|
|
opts.env = env();
|
|
BlockBasedTableOptions table_opts;
|
|
table_opts.filter_policy.reset(
|
|
ROCKSDB_NAMESPACE::NewBloomFilterPolicy(10, false));
|
|
opts.table_factory.reset(new BlockBasedTableFactory(table_opts));
|
|
std::string file_path = MakeFilePath("rocksdb_sst_test.sst");
|
|
createSST(opts, file_path, 10);
|
|
|
|
char* usage[3];
|
|
PopulateCommandArgs(file_path, "--command=recompress", usage);
|
|
|
|
ROCKSDB_NAMESPACE::SSTDumpTool tool;
|
|
ASSERT_TRUE(!tool.Run(3, usage, opts));
|
|
|
|
cleanup(opts, file_path);
|
|
for (int i = 0; i < 3; i++) {
|
|
delete[] usage[i];
|
|
}
|
|
}
|
|
|
|
TEST_F(SSTDumpToolTest, MemEnv) {
|
|
std::unique_ptr<Env> mem_env(NewMemEnv(env()));
|
|
Options opts;
|
|
opts.env = mem_env.get();
|
|
std::string file_path = MakeFilePath("rocksdb_sst_test.sst");
|
|
createSST(opts, file_path);
|
|
|
|
char* usage[3];
|
|
PopulateCommandArgs(file_path, "--command=verify_checksum", usage);
|
|
|
|
ROCKSDB_NAMESPACE::SSTDumpTool tool;
|
|
ASSERT_TRUE(!tool.Run(3, usage, opts));
|
|
|
|
cleanup(opts, file_path);
|
|
for (int i = 0; i < 3; i++) {
|
|
delete[] usage[i];
|
|
}
|
|
}
|
|
|
|
TEST_F(SSTDumpToolTest, ReadaheadSize) {
|
|
Options opts;
|
|
opts.env = env();
|
|
std::string file_path = MakeFilePath("rocksdb_sst_test.sst");
|
|
createSST(opts, file_path);
|
|
|
|
char* usage[4];
|
|
PopulateCommandArgs(file_path, "--command=verify", usage);
|
|
snprintf(usage[3], kOptLength, "--readahead_size=4000000");
|
|
|
|
int num_reads = 0;
|
|
SyncPoint::GetInstance()->SetCallBack("RandomAccessFileReader::Read",
|
|
[&](void*) { num_reads++; });
|
|
SyncPoint::GetInstance()->EnableProcessing();
|
|
|
|
SSTDumpTool tool;
|
|
ASSERT_TRUE(!tool.Run(4, usage, opts));
|
|
|
|
// The file is approximately 10MB. Readahead is 4MB.
|
|
// We usually need 3 reads + one metadata read.
|
|
// One extra read is needed before opening the file for metadata.
|
|
ASSERT_EQ(5, num_reads);
|
|
|
|
SyncPoint::GetInstance()->ClearAllCallBacks();
|
|
SyncPoint::GetInstance()->DisableProcessing();
|
|
|
|
cleanup(opts, file_path);
|
|
for (int i = 0; i < 4; i++) {
|
|
delete[] usage[i];
|
|
}
|
|
}
|
|
|
|
TEST_F(SSTDumpToolTest, NoSstFile) {
|
|
Options opts;
|
|
opts.env = env();
|
|
std::string file_path = MakeFilePath("no_such_file.sst");
|
|
char* usage[3];
|
|
PopulateCommandArgs(file_path, "", usage);
|
|
ROCKSDB_NAMESPACE::SSTDumpTool tool;
|
|
for (const auto& command :
|
|
{"--command=check", "--command=dump", "--command=raw",
|
|
"--command=verify", "--command=recompress", "--command=verify_checksum",
|
|
"--show_properties"}) {
|
|
snprintf(usage[1], kOptLength, "%s", command);
|
|
ASSERT_TRUE(tool.Run(3, usage, opts));
|
|
}
|
|
for (int i = 0; i < 3; i++) {
|
|
delete[] usage[i];
|
|
}
|
|
}
|
|
|
|
TEST_F(SSTDumpToolTest, ValidSSTPath) {
|
|
Options opts;
|
|
opts.env = env();
|
|
char* usage[3];
|
|
PopulateCommandArgs("", "", usage);
|
|
SSTDumpTool tool;
|
|
std::string file_not_exists = MakeFilePath("file_not_exists.sst");
|
|
std::string sst_file = MakeFilePath("rocksdb_sst_test.sst");
|
|
createSST(opts, sst_file);
|
|
std::string text_file = MakeFilePath("text_file");
|
|
ASSERT_OK(WriteStringToFile(opts.env, "Hello World!", text_file, false));
|
|
std::string fake_sst = MakeFilePath("fake_sst.sst");
|
|
ASSERT_OK(WriteStringToFile(opts.env, "Not an SST file!", fake_sst, false));
|
|
|
|
for (const auto& command_arg : {"--command=verify", "--command=identify"}) {
|
|
snprintf(usage[1], kOptLength, "%s", command_arg);
|
|
|
|
snprintf(usage[2], kOptLength, "--file=%s", file_not_exists.c_str());
|
|
ASSERT_TRUE(tool.Run(3, usage, opts));
|
|
|
|
snprintf(usage[2], kOptLength, "--file=%s", sst_file.c_str());
|
|
ASSERT_TRUE(!tool.Run(3, usage, opts));
|
|
|
|
snprintf(usage[2], kOptLength, "--file=%s", text_file.c_str());
|
|
ASSERT_TRUE(tool.Run(3, usage, opts));
|
|
|
|
snprintf(usage[2], kOptLength, "--file=%s", fake_sst.c_str());
|
|
ASSERT_TRUE(tool.Run(3, usage, opts));
|
|
}
|
|
ASSERT_OK(opts.env->DeleteFile(sst_file));
|
|
ASSERT_OK(opts.env->DeleteFile(text_file));
|
|
ASSERT_OK(opts.env->DeleteFile(fake_sst));
|
|
|
|
for (int i = 0; i < 3; i++) {
|
|
delete[] usage[i];
|
|
}
|
|
}
|
|
|
|
TEST_F(SSTDumpToolTest, RawOutput) {
|
|
Options opts;
|
|
opts.env = env();
|
|
std::string file_path = MakeFilePath("rocksdb_sst_test.sst");
|
|
createSST(opts, file_path, 10);
|
|
|
|
char* usage[3];
|
|
PopulateCommandArgs(file_path, "--command=raw", usage);
|
|
|
|
ROCKSDB_NAMESPACE::SSTDumpTool tool;
|
|
ASSERT_TRUE(!tool.Run(3, usage, opts));
|
|
|
|
const std::string raw_path = MakeFilePath("rocksdb_sst_test_dump.txt");
|
|
std::ifstream raw_file(raw_path);
|
|
|
|
std::string tp;
|
|
bool is_data_block = false;
|
|
int key_count = 0;
|
|
while (getline(raw_file, tp)) {
|
|
if (tp.find("Data Block #") != std::string::npos) {
|
|
is_data_block = true;
|
|
}
|
|
|
|
if (is_data_block && tp.find("HEX") != std::string::npos) {
|
|
key_count++;
|
|
}
|
|
}
|
|
|
|
ASSERT_EQ(kNumKey, key_count);
|
|
|
|
raw_file.close();
|
|
|
|
cleanup(opts, file_path);
|
|
for (int i = 0; i < 3; i++) {
|
|
delete[] usage[i];
|
|
}
|
|
}
|
|
|
|
TEST_F(SSTDumpToolTest, SstFileDumperMmapReads) {
|
|
Options opts;
|
|
opts.env = env();
|
|
std::string file_path = MakeFilePath("rocksdb_sst_test.sst");
|
|
createSST(opts, file_path, 10);
|
|
|
|
EnvOptions env_opts;
|
|
uint64_t data_size = 0;
|
|
|
|
// Test all combinations of mmap read options
|
|
for (int i = 0; i < 4; ++i) {
|
|
SaveAndRestore<bool> sar_opts(&opts.allow_mmap_reads, (i & 1) != 0);
|
|
SaveAndRestore<bool> sar_env_opts(&env_opts.use_mmap_reads, (i & 2) != 0);
|
|
|
|
SstFileDumper dumper(opts, file_path, Temperature::kUnknown,
|
|
1024 /*readahead_size*/, true /*verify_checksum*/,
|
|
false /*output_hex*/, false /*decode_blob_index*/,
|
|
env_opts);
|
|
ASSERT_OK(dumper.getStatus());
|
|
std::shared_ptr<const TableProperties> tp;
|
|
ASSERT_OK(dumper.ReadTableProperties(&tp));
|
|
ASSERT_NE(tp.get(), nullptr);
|
|
if (i == 0) {
|
|
// Verify consistency of a populated field with some entropy
|
|
data_size = tp->data_size;
|
|
ASSERT_GT(data_size, 0);
|
|
} else {
|
|
ASSERT_EQ(data_size, tp->data_size);
|
|
}
|
|
}
|
|
|
|
cleanup(opts, file_path);
|
|
}
|
|
|
|
TEST_F(SSTDumpToolTest, SstFileDumperVerifyNumRecords) {
|
|
Options opts;
|
|
opts.env = env();
|
|
|
|
EnvOptions env_opts;
|
|
std::string file_path = MakeFilePath("rocksdb_sst_test.sst");
|
|
{
|
|
createSST(opts, file_path, 10);
|
|
SstFileDumper dumper(opts, file_path, Temperature::kUnknown,
|
|
1024 /*readahead_size*/, true /*verify_checksum*/,
|
|
false /*output_hex*/, false /*decode_blob_index*/,
|
|
env_opts, /*silent=*/true);
|
|
ASSERT_OK(dumper.getStatus());
|
|
ASSERT_OK(dumper.ReadSequential(
|
|
/*print_kv=*/false,
|
|
/*read_num_limit=*/std::numeric_limits<uint64_t>::max(),
|
|
/*has_from=*/false, /*from_key=*/"",
|
|
/*has_to=*/false, /*to_key=*/""));
|
|
cleanup(opts, file_path);
|
|
}
|
|
|
|
{
|
|
// Test with range del
|
|
createSST(opts, file_path, 10, /*range_del=*/true);
|
|
SstFileDumper dumper(opts, file_path, Temperature::kUnknown,
|
|
1024 /*readahead_size*/, true /*verify_checksum*/,
|
|
false /*output_hex*/, false /*decode_blob_index*/,
|
|
env_opts, /*silent=*/true);
|
|
ASSERT_OK(dumper.getStatus());
|
|
ASSERT_OK(dumper.ReadSequential(
|
|
/*print_kv=*/false,
|
|
/*read_num_limit=*/std::numeric_limits<uint64_t>::max(),
|
|
/*has_from=*/false, /*from_key=*/"",
|
|
/*has_to=*/false, /*to_key=*/""));
|
|
cleanup(opts, file_path);
|
|
}
|
|
|
|
{
|
|
SyncPoint::GetInstance()->SetCallBack(
|
|
"PropertyBlockBuilder::AddTableProperty:Start", [&](void* arg) {
|
|
TableProperties* props = reinterpret_cast<TableProperties*>(arg);
|
|
props->num_entries = kNumKey + 2;
|
|
});
|
|
SyncPoint::GetInstance()->EnableProcessing();
|
|
createSST(opts, file_path, 10);
|
|
SstFileDumper dumper(opts, file_path, Temperature::kUnknown,
|
|
1024 /*readahead_size*/, true /*verify_checksum*/,
|
|
false /*output_hex*/, false /*decode_blob_index*/,
|
|
env_opts, /*silent=*/true);
|
|
ASSERT_OK(dumper.getStatus());
|
|
Status s = dumper.ReadSequential(
|
|
/*print_kv=*/false,
|
|
/*read_num_limit==*/std::numeric_limits<uint64_t>::max(),
|
|
/*has_from=*/false, /*from_key=*/"",
|
|
/*has_to=*/false, /*to_key=*/"");
|
|
ASSERT_TRUE(s.IsCorruption());
|
|
ASSERT_TRUE(
|
|
std::strstr("Table property expects 1026 entries when excluding range "
|
|
"deletions, but scanning the table returned 1024 entries",
|
|
s.getState()));
|
|
|
|
// Validation is not performed when read_num, has_from, has_to are set
|
|
ASSERT_OK(dumper.ReadSequential(
|
|
/*print_kv=*/false, /*read_num_limit=*/10,
|
|
/*has_from=*/false, /*from_key=*/"",
|
|
/*has_to=*/false, /*to_key=*/""));
|
|
|
|
ASSERT_OK(dumper.ReadSequential(
|
|
/*print_kv=*/false,
|
|
/*read_num_limit=*/std::numeric_limits<uint64_t>::max(),
|
|
/*has_from=*/true, /*from_key=*/MakeKey(100),
|
|
/*has_to=*/false, /*to_key=*/""));
|
|
|
|
ASSERT_OK(dumper.ReadSequential(
|
|
/*print_kv=*/false,
|
|
/*read_num_limit=*/std::numeric_limits<uint64_t>::max(),
|
|
/*has_from=*/false, /*from_key=*/"",
|
|
/*has_to=*/true, /*to_key=*/MakeKey(100)));
|
|
|
|
cleanup(opts, file_path);
|
|
}
|
|
}
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|
|
|
|
int main(int argc, char** argv) {
|
|
ROCKSDB_NAMESPACE::port::InstallStackTraceHandler();
|
|
::testing::InitGoogleTest(&argc, argv);
|
|
RegisterCustomObjects(argc, argv);
|
|
return RUN_ALL_TESTS();
|
|
}
|