rocksdb/java/rocksjni/rocks_callback_object.cc
Radek Hubner 0bf9079d44 Change Java native methods to static (#11882)
Summary:
This should give us some performance benefit calling native C++ code.
Closes https://github.com/facebook/rocksdb/issues/4786
See https://github.com/evolvedbinary/jni-benchmarks/ for more info.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/11882

Reviewed By: pdillinger

Differential Revision: D53066207

Pulled By: ajkr

fbshipit-source-id: daedef185215d0d8e791cd85bef598900bcb5bf2
2024-01-25 12:36:30 -08:00

30 lines
1.3 KiB
C++

// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
// This source code is licensed under both the GPLv2 (found in the
// COPYING file in the root directory) and Apache 2.0 License
// (found in the LICENSE.Apache file in the root directory).
//
// This file implements the "bridge" between Java and C++ for
// JNI Callbacks from C++ to sub-classes or org.rocksdb.RocksCallbackObject
#include <jni.h>
#include "include/org_rocksdb_RocksCallbackObject.h"
#include "jnicallback.h"
/*
* Class: org_rocksdb_RocksCallbackObject
* Method: disposeInternal
* Signature: (J)V
*/
void Java_org_rocksdb_RocksCallbackObject_disposeInternal(JNIEnv* /*env*/,
jclass /*jcls*/,
jlong handle) {
// TODO(AR) is deleting from the super class JniCallback OK, or must we delete
// the subclass? Example hierarchies:
// 1) Comparator -> BaseComparatorJniCallback + JniCallback ->
// DirectComparatorJniCallback 2) Comparator -> BaseComparatorJniCallback +
// JniCallback -> ComparatorJniCallback
// I think this is okay, as Comparator and JniCallback both have virtual
// destructors...
delete reinterpret_cast<ROCKSDB_NAMESPACE::JniCallback*>(handle);
}