1cfdece85d
Summary: When internal cpp modernizer attempts to format rocksdb code, it will replace macro `ROCKSDB_NAMESPACE` with its default definition `rocksdb` when collapsing nested namespace. We filed a feedback for the tool T180254030 and the team filed a bug for this: https://github.com/llvm/llvm-project/issues/83452. At the same time, they suggested us to run the modernizer tool ourselves so future auto codemod attempts will be smaller. This diff contains: Running `xplat/scripts/codemod_service/cpp_modernizer.sh` in fbcode/internal_repo_rocksdb/repo (excluding some directories in utilities/transactions/lock/range/range_tree/lib that has a non meta copyright comment) without swapping out the namespace macro `ROCKSDB_NAMESPACE` Followed by RocksDB's own `make format` Pull Request resolved: https://github.com/facebook/rocksdb/pull/12398 Test Plan: Auto tests Reviewed By: hx235 Differential Revision: D54382532 Pulled By: jowlyzhang fbshipit-source-id: e7d5b40f9b113b60e5a503558c181f080b9d02fa
76 lines
2.5 KiB
C++
76 lines
2.5 KiB
C++
// Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
//
|
|
// A MergeOperator for rocksdb that implements string append.
|
|
|
|
#include "stringappend.h"
|
|
|
|
#include <cassert>
|
|
#include <memory>
|
|
|
|
#include "rocksdb/merge_operator.h"
|
|
#include "rocksdb/slice.h"
|
|
#include "rocksdb/utilities/options_type.h"
|
|
#include "utilities/merge_operators.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
namespace {
|
|
static std::unordered_map<std::string, OptionTypeInfo>
|
|
stringappend_merge_type_info = {
|
|
{"delimiter",
|
|
{0, OptionType::kString, OptionVerificationType::kNormal,
|
|
OptionTypeFlags::kNone}},
|
|
};
|
|
} // namespace
|
|
// Constructor: also specify the delimiter character.
|
|
StringAppendOperator::StringAppendOperator(char delim_char)
|
|
: delim_(1, delim_char) {
|
|
RegisterOptions("Delimiter", &delim_, &stringappend_merge_type_info);
|
|
}
|
|
|
|
StringAppendOperator::StringAppendOperator(const std::string& delim)
|
|
: delim_(delim) {
|
|
RegisterOptions("Delimiter", &delim_, &stringappend_merge_type_info);
|
|
}
|
|
|
|
// Implementation for the merge operation (concatenates two strings)
|
|
bool StringAppendOperator::Merge(const Slice& /*key*/,
|
|
const Slice* existing_value,
|
|
const Slice& value, std::string* new_value,
|
|
Logger* /*logger*/) const {
|
|
// Clear the *new_value for writing.
|
|
assert(new_value);
|
|
new_value->clear();
|
|
|
|
if (!existing_value) {
|
|
// No existing_value. Set *new_value = value
|
|
new_value->assign(value.data(), value.size());
|
|
} else {
|
|
// Generic append (existing_value != null).
|
|
// Reserve *new_value to correct size, and apply concatenation.
|
|
new_value->reserve(existing_value->size() + delim_.size() + value.size());
|
|
new_value->assign(existing_value->data(), existing_value->size());
|
|
new_value->append(delim_);
|
|
new_value->append(value.data(), value.size());
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
std::shared_ptr<MergeOperator> MergeOperators::CreateStringAppendOperator() {
|
|
return std::make_shared<StringAppendOperator>(',');
|
|
}
|
|
|
|
std::shared_ptr<MergeOperator> MergeOperators::CreateStringAppendOperator(
|
|
char delim_char) {
|
|
return std::make_shared<StringAppendOperator>(delim_char);
|
|
}
|
|
|
|
std::shared_ptr<MergeOperator> MergeOperators::CreateStringAppendOperator(
|
|
const std::string& delim) {
|
|
return std::make_shared<StringAppendOperator>(delim);
|
|
}
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|