Summary: When internal cpp modernizer attempts to format rocksdb code, it will replace macro `ROCKSDB_NAMESPACE` with its default definition `rocksdb` when collapsing nested namespace. We filed a feedback for the tool T180254030 and the team filed a bug for this: https://github.com/llvm/llvm-project/issues/83452. At the same time, they suggested us to run the modernizer tool ourselves so future auto codemod attempts will be smaller. This diff contains: Running `xplat/scripts/codemod_service/cpp_modernizer.sh` in fbcode/internal_repo_rocksdb/repo (excluding some directories in utilities/transactions/lock/range/range_tree/lib that has a non meta copyright comment) without swapping out the namespace macro `ROCKSDB_NAMESPACE` Followed by RocksDB's own `make format` Pull Request resolved: https://github.com/facebook/rocksdb/pull/12398 Test Plan: Auto tests Reviewed By: hx235 Differential Revision: D54382532 Pulled By: jowlyzhang fbshipit-source-id: e7d5b40f9b113b60e5a503558c181f080b9d02fa
129 lines
4.1 KiB
C++
129 lines
4.1 KiB
C++
// Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#include "stringappend2.h"
|
|
|
|
#include <cassert>
|
|
#include <memory>
|
|
#include <string>
|
|
|
|
#include "rocksdb/merge_operator.h"
|
|
#include "rocksdb/slice.h"
|
|
#include "rocksdb/utilities/options_type.h"
|
|
#include "utilities/merge_operators.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
namespace {
|
|
static std::unordered_map<std::string, OptionTypeInfo>
|
|
stringappend2_merge_type_info = {
|
|
{"delimiter",
|
|
{0, OptionType::kString, OptionVerificationType::kNormal,
|
|
OptionTypeFlags::kNone}},
|
|
};
|
|
} // namespace
|
|
|
|
// Constructor: also specify the delimiter character.
|
|
StringAppendTESTOperator::StringAppendTESTOperator(char delim_char)
|
|
: delim_(1, delim_char) {
|
|
RegisterOptions("Delimiter", &delim_, &stringappend2_merge_type_info);
|
|
}
|
|
|
|
StringAppendTESTOperator::StringAppendTESTOperator(const std::string& delim)
|
|
: delim_(delim) {
|
|
RegisterOptions("Delimiter", &delim_, &stringappend2_merge_type_info);
|
|
}
|
|
|
|
// Implementation for the merge operation (concatenates two strings)
|
|
bool StringAppendTESTOperator::FullMergeV2(
|
|
const MergeOperationInput& merge_in,
|
|
MergeOperationOutput* merge_out) const {
|
|
// Clear the *new_value for writing.
|
|
merge_out->new_value.clear();
|
|
|
|
if (merge_in.existing_value == nullptr && merge_in.operand_list.size() == 1) {
|
|
// Only one operand
|
|
merge_out->existing_operand = merge_in.operand_list.back();
|
|
return true;
|
|
}
|
|
|
|
// Compute the space needed for the final result.
|
|
size_t numBytes = 0;
|
|
|
|
for (auto it = merge_in.operand_list.begin();
|
|
it != merge_in.operand_list.end(); ++it) {
|
|
numBytes += it->size() + delim_.size();
|
|
}
|
|
|
|
// Only print the delimiter after the first entry has been printed
|
|
bool printDelim = false;
|
|
|
|
// Prepend the *existing_value if one exists.
|
|
if (merge_in.existing_value) {
|
|
merge_out->new_value.reserve(numBytes + merge_in.existing_value->size());
|
|
merge_out->new_value.append(merge_in.existing_value->data(),
|
|
merge_in.existing_value->size());
|
|
printDelim = true;
|
|
} else if (numBytes) {
|
|
// Without the existing (initial) value, the delimiter before the first of
|
|
// subsequent operands becomes redundant.
|
|
merge_out->new_value.reserve(numBytes - delim_.size());
|
|
}
|
|
|
|
// Concatenate the sequence of strings (and add a delimiter between each)
|
|
for (auto it = merge_in.operand_list.begin();
|
|
it != merge_in.operand_list.end(); ++it) {
|
|
if (printDelim) {
|
|
merge_out->new_value.append(delim_);
|
|
}
|
|
merge_out->new_value.append(it->data(), it->size());
|
|
printDelim = true;
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
bool StringAppendTESTOperator::PartialMergeMulti(
|
|
const Slice& /*key*/, const std::deque<Slice>& /*operand_list*/,
|
|
std::string* /*new_value*/, Logger* /*logger*/) const {
|
|
return false;
|
|
}
|
|
|
|
// A version of PartialMerge that actually performs "partial merging".
|
|
// Use this to simulate the exact behaviour of the StringAppendOperator.
|
|
bool StringAppendTESTOperator::_AssocPartialMergeMulti(
|
|
const Slice& /*key*/, const std::deque<Slice>& operand_list,
|
|
std::string* new_value, Logger* /*logger*/) const {
|
|
// Clear the *new_value for writing
|
|
assert(new_value);
|
|
new_value->clear();
|
|
assert(operand_list.size() >= 2);
|
|
|
|
// Generic append
|
|
// Determine and reserve correct size for *new_value.
|
|
size_t size = 0;
|
|
for (const auto& operand : operand_list) {
|
|
size += operand.size();
|
|
}
|
|
size += (operand_list.size() - 1) * delim_.length(); // Delimiters
|
|
new_value->reserve(size);
|
|
|
|
// Apply concatenation
|
|
new_value->assign(operand_list.front().data(), operand_list.front().size());
|
|
|
|
for (std::deque<Slice>::const_iterator it = operand_list.begin() + 1;
|
|
it != operand_list.end(); ++it) {
|
|
new_value->append(delim_);
|
|
new_value->append(it->data(), it->size());
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
std::shared_ptr<MergeOperator>
|
|
MergeOperators::CreateStringAppendTESTOperator() {
|
|
return std::make_shared<StringAppendTESTOperator>(',');
|
|
}
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|