continuwuation/ruwuma
5
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

feat: enable the stable endpoint for MSC3266 room summaries #25

Merged
nex merged 1 commit from nex/feat/MSC3266 into conduwuit-changes 2025-07-01 14:15:19 +00:00
Conversation 2 Commits 1 Files changed 1 +6 -6
nex commented 2025-07-01 00:30:14 +00:00
Owner
Copy link

This PR enables the stable endpoint for MSC3266, which was stabilised in v1.15.

This PR enables the stable endpoint for MSC3266, which was stabilised in v1.15.
nex added 1 commit 2025-07-01 00:30:14 +00:00
requested review from Owners 2025-07-01 00:30:18 +00:00
Aranjedeath approved these changes 2025-07-01 02:14:45 +00:00
Jade reviewed 2025-07-01 13:24:43 +00:00
crates/ruma-client-api/src/room/get_summary.rs
@ -86,9 +86,9 @@ pub mod msc3266 {
/// Version of the room.
#[serde(
skip_serializing_if = "Option::is_none",
rename = "im.nheko.summary.room_version",
Jade commented 2025-07-01 13:24:43 +00:00
Owner
Copy link

Worried that this might break stuff that hits the unstable endpoint and then expects the unstable prefixes, but not a big concern

Worried that this might break stuff that hits the unstable endpoint and then expects the unstable prefixes, but not a big concern
nex commented 2025-07-01 13:48:59 +00:00
Author
Owner
Copy link

This is in spec now, the unstable prefixes shouldn't be used anymore. If serde has a way to use both in parallel let me know, but afiak we're supposed to drop the unstable prefix as soon as the relevant spec version is released

This is in spec now, the unstable prefixes shouldn't be used anymore. If serde has a way to use both in parallel let me know, but afiak we're supposed to drop the unstable prefix as soon as the relevant spec version is released
Jade commented 2025-07-01 14:06:56 +00:00
Owner
Copy link

I don't think there's much we can do here, save for writing both fields - we can't really fall back with serialisation.

I don't think there's much we can do here, save for writing both fields - we can't really fall back with serialisation.
nex merged commit f9fd0a7080 into conduwuit-changes 2025-07-01 14:15:19 +00:00
nex deleted branch nex/feat/MSC3266 2025-07-01 14:15:19 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Aranjedeath
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: continuwuation/ruwuma#25
No description provided.
Delete branch "nex/feat/MSC3266"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?