Support creating rooms with arbitrary internal room IDs #103

New issue

Closed

opened 2024-01-18 23:43:15 +00:00 by girlbossceo · 2 comments

girlbossceo commented

2024-01-18 23:43:15 +00:00

(Migrated from github.com)

I don't exactly know what Maunium does but apparently just supporting a field like "my_arbitrary_room_id_or_whatever" in the JSON request body for the room creation endpoint(s) is enough.

Will need to add an explicit check for all the current room versions to avoid causing future breakage with auth checks and such when server_name is removed from room IDs, or at least when it goes into testing. I don't exactly know what Maunium does but apparently just supporting a field like `"my_arbitrary_room_id_or_whatever"` in the JSON request body for the room creation endpoint(s) is enough.

girlbossceo commented

2024-01-23 05:33:31 +00:00

(Migrated from github.com)

Will need to add an explicit check for all the current room versions to avoid causing future breakage with auth checks and such when server_name is removed from room IDs, or at least when it goes into testing.

Ended up opting out of this, ruma itself is too dependent on the server_name still. They only made slight changes in their code about this.

> Will need to add an explicit check for all the current room versions to avoid causing future breakage with auth checks and such when server_name is removed from room IDs, or at least when it goes into testing. Ended up opting out of this, ruma itself is too dependent on the server_name still. They only made slight changes in their code about this.

girlbossceo commented

2024-01-26 00:29:10 +00:00

(Migrated from github.com)

https://github.com/girlbossceo/conduwuit/pull/106