feat: Add more granular controls for policy server calling #1127

Merged
nex merged 2 commits from nex/feat/ps-toggle into main 2025-10-16 22:45:24 +00:00
Owner

Adds two new toggles to the configuration, the first of which allows disabling the policy server checks entirely, and the second of which allows disabling checking events created locally. They're both enabled by default for maximum PS efficacy but allowing them to be disabled allows people who frequently cannot contact policy servers, for example those in censored countries, to be able to still use rooms with pace, allows single-user/trusted-only homeservers to disable the preliminary check on their own events, and also gives an escape hatch in case an issue like #1060 happens again, especially with MSCs not in FCP being moving targets.

In future, I think we should gate all MSC implementations behind config flags, even if they default to on.

Adds two new toggles to the configuration, the first of which allows disabling the policy server checks entirely, and the second of which allows disabling checking events created locally. They're both enabled by default for maximum PS efficacy but allowing them to be disabled allows people who frequently cannot contact policy servers, for example those in censored countries, to be able to still use rooms with pace, allows single-user/trusted-only homeservers to disable the preliminary check on their own events, and also gives an escape hatch in case an issue like #1060 happens again, especially with MSCs not in FCP being moving targets. In future, I think we should gate all MSC implementations behind config flags, even if they default to on.
feat: Add more granular controls for policy server calling
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 57s
Checks / Prek / Pre-commit & Formatting (pull_request) Failing after 1m21s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 7m44s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 6m32s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 1m13s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 18m55s
Release Docker Image / Create Max-Perf Manifest (pull_request) Has been cancelled
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Has been cancelled
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Has been cancelled
ef5544d507
nex requested review from Owners 2025-10-16 21:49:22 +00:00
nex added this to the 0.5.0 milestone 2025-10-16 21:49:26 +00:00
Jade approved these changes 2025-10-16 21:53:09 +00:00
style: Fix formatting
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m23s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m38s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 7m22s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 5m58s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Has been cancelled
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Has been cancelled
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Has been cancelled
Release Docker Image / Create Max-Perf Manifest (pull_request) Has been cancelled
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 18m53s
344e51ccb3
nex merged commit d189004d65 into main 2025-10-16 22:45:24 +00:00
nex deleted branch nex/feat/ps-toggle 2025-10-16 22:45:24 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity!1127
No description provided.