LDAP users can have broken MXIDs #1129
Labels
No labels
Bug
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status/Blocked
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
To-Merge
Wont fix
old/ci/cd
old/rust
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
continuwuation/continuwuity#1129
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
When using an LDAP provider, which supplies Continuwuity with a name that contains unusable characters, they are added to the database and the user can somewhat use their client, until the point that it conflicts with other users and servers trying to interact with that user.
Example setup:
!$%^&*# @
(including the space between the # and the @)With that setup, that user can log in with their password, and once logged in will be shown that they have the following handle:
@!$%^&*# @:bearware.dev
(including the space).So far I've found that users containing invalid characters can still do most of the basic tasks if a client can parse it. Cinny's autocomplete will allow the user to send invites and receive invites (though they show up as unknown instead of their username). It will also try to autocomplete for things like @s, but attempting to mention a user with those characters in their username tends to result in it appearing like a clickable link, with results depending on where the characters are in the game. While most chat functions work, if you dont have a client's autocomplete or search functions, it makes it almost impossible to properly invite a user, including with the use of chat commands. The user can also federate (at least, with other continuwuity servers) without extra issue. Neither log from the Continuwuity server shows any output from any of these actions
Those are technically legal user IDs, although I'm not sure the check that is normally run should be allowed to bypass for LDAP registrations
Ah gotcha, I didn't see that the section for historic IDs, good to know. From my perspective using LDAP here, it definitely feels unexpected that the check doesnt run like it would otherwise if you use LDAP, though my usage of LDAP is pretty limited