cosmetic bug: ERROR in media download #1318

New issue

Open

opened 2026-01-27 23:41:49 +00:00 by nex · 1 comment

nex commented

2026-01-27 23:41:49 +00:00

Owner

A minor cosmetic/non-functional regression from #1298:

  2026-01-27T23:37:50.280772Z ERROR conduwuit_router::request: 500 Internal Server Error, method: GET, uri: /_matrix/client/v1/media/download/tapenet.org/CyWpFrYXzysLtmbeHMoGleZD
    at src/router/request.rs:105 on conduwuit:worker ThreadId(2)
  2026-01-27T23:37:50.280867Z ERROR tower_http::trace::on_failure: response failed, classification: Status code: 500 Internal Server Error, latency: 190 ms
    at /home/nex/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tower-http-0.6.8/src/trace/on_failure.rs:93 on conduwuit:worker ThreadId(2)

This should probably be 404 / M_NOT_FOUND, instead the raw federation error of "failed to fetch" is returned:

{"errcode":"M_UNKNOWN","error":"Request error: error sending request"}

This is cosmetic because the end result is the same (can't download media), but it makes unseemly log entries each time

A minor cosmetic/non-functional regression from #1298: ``` 2026-01-27T23:37:50.280772Z ERROR conduwuit_router::request: 500 Internal Server Error, method: GET, uri: /_matrix/client/v1/media/download/tapenet.org/CyWpFrYXzysLtmbeHMoGleZD at src/router/request.rs:105 on conduwuit:worker ThreadId(2) 2026-01-27T23:37:50.280867Z ERROR tower_http::trace::on_failure: response failed, classification: Status code: 500 Internal Server Error, latency: 190 ms at /home/nex/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tower-http-0.6.8/src/trace/on_failure.rs:93 on conduwuit:worker ThreadId(2) ``` This should probably be `404 / M_NOT_FOUND`, instead the raw federation error of "failed to fetch" is returned: ``` {"errcode":"M_UNKNOWN","error":"Request error: error sending request"} ``` This is cosmetic because the end result is the same (can't download media), but it makes unseemly log entries each time

👍 1