continuwuation/continuwuity

Fork

You've already forked continuwuity

Code Issues 99 Pull requests 30 Releases 25 Packages 3 Activity Actions

bug: Suspicious incorrect behaviour in federation `get_missing_events` endpoint #1336

New issue

Closed

opened 2026-02-05 20:41:26 +00:00 by nex · 0 comments

nex commented

2026-02-05 20:41:26 +00:00

Owner

Copy link

It seems our get_missing_events handler just returns the same events N times rather than actually walking the tree to find the missing events. This is probably bad since get_missing_events is sometimes necessary to allow remote servers to authorise events after outages or in netsplit rooms

synapse_get_missing_events.json

9.6 KiB

continuwuity_get_missing_events.json

8.4 KiB

nex added the

labels

2026-02-05 20:41:26 +00:00

nex referenced this issue from a pull request that will close it,

2026-02-05 21:29:51 +00:00

fix: Get_missing_events returns the same event N times #1338

nex closed this issue

2026-02-05 21:56:48 +00:00

No Branch/Tag specified

main

renovate/rust-patch-updates

renovate/cargo-bins-cargo-binstall-1.x

renovate/rspress-plugin-client-redirects-2.x-lockfile

ginger/oobe

nex/fix/remote-restricted-joins

tcpipuk/docker-docs

renovate/rspress-plugin-sitemap-2.x-lockfile

renovate/rspress-core-2.x-lockfile

renovate/ruma-digest

aranje/illegal-car-mods

jade/get-started

jade/liveit-guide

jade/docs-guide

jade/http3

nex/feat/msc4406-sender-ignored

ginger/fix-local-invites

renovate/rand-0.x

nex/fix/tpi

jade/deadlock-detection

jade/snafu

renovate/axum-server-0.x

renovate/rspress-plugin-preview-2.x-lockfile

nex/feat/room-deletion

nex/feat/msc4322-media-redaction

ginger/stitched-order

jade/build-info

nex/stateres-refactor

ginger/deps/update-rspress

jade/admin-announce-improvements

ginger/xtask-improvements

jade/improve-admin-config-display

nex/fix/better-stateres-error-logs

jade/sender-timeouts

nex/feat/custom-v12-room-ids

ginger/update-metadata

nex/feat/admin-force-logout

tom/max-perf-docs

nex/fix/invalid-appservice-reg

nex/feat/antispam

nex/feat/account-locking

jade/logging-cleanup

jade/remove-legacy-appservice-auth

nex/fix/key-query

jade/update-prek

nex/fix/room-summaries

ginger/restrict-admin-commands

ginger/enable-console-by-default

jade/tag-fixes

jade/otlp

nex/meta/pull-req-template

nex/fix/fed-invite-compliance

nex/feat/build-commit

nex/feat/join-logging

jade/mailmap-updates

jade/hack-ci-tmp

jade/v12-stable

jade/relations

renovate/axum-monorepo

ginger/database-refactor

jade/fix-ldap-uiaa

nex/fix/validation

ginger/nuke-invalid-msc4133-fields-in-migration

ginger/downgrade-artifact-actions

oddlid/reload-fix

jade/fix-assert

ginger/sync-v3-cleanup

ginger/remove-absolute-action-urls

jade/website

nex/fix/backoff

ginger/fix-mdbook-for-0.5

ginger/no-docker-on-prs

backport/v0.5.0-rc.8-1

nex/fed-improvements

dahsa_uwu/axum-0.8

jade/rust-1.90

jade/mirror-dockerhub

jade/clippy-fixes

jade/fix-support

jade/clean-images

jade/wal-compression-type

jade/flake-clone

ginger/upload-rpms-on-schedule

nex/fix/incoming-fetch

nex/fix/upgrade

tom/ci-fedora-rpm

jade/ci-release-fix

jade/rocksdb-10-5

ginger/fix-msc4133-migration

ginger/migrate-busted-tz

hydra/public

nex/feat/manual-extremities

nex/feat/async-media

nex/feat/fast-joins-hack-do-not-use-DO-NOT-USE

nex/feat/better-logging

trigger-ci-so-latest-isnt-on-illegal-car-mods

nex/feat/pins-backfill

jade/tuwunel-2025-06-old

jade/ai-slop-db-docs

nex/fix-create-auth

jade/version-stats

jade/read-receipts

jade/rust-toolchain-no-targets

jade/logging-features

jade/syncv5-typing

jade/msc2815

jade/purge-sync-tokens

morguldir/see-eye

jade/css-small-screen

nex/wip-751

tuwunel-rebase

test

oddlid/rename-admin-room-bot

strawberry/nix-ci-stuff

strawberry/valgrind

phonemain

strawberry/morgs-snake-sync-jason-main

newer-media-endpoints

folly-coroutines-async-io

federation-retry-timer-port

bad-attempt-at-extracting-homeserver-signing-key

room-deletion-attempt-do-not-use

v0.5.4

v0.5.3

v0.5.2

v0.5.1

v0.5.0

v0.5.0-rc.8.1

v0.5.0-rc.8

v0.5.0-rc.7

v0.5.0-rc.6

v0.5.0-rc.5

v0.5.0-rc4

v0.5.0-rc3

v0.5.0-rc2

v0.5.0-rc

v0.4.7-rc

v0.4.6

v0.4.6-rc

v0.4.5-rc

v0.4.5

v0.4.4

v0.4.3

v0.4.2

v0.4.1

v0.3.4

v0.3.3

v0.3.2

v0.3.1

v0.3.0

Labels

Clear labels

Blocked

This pull request or issue is currently blocked from being merged/closed

Bug

Something isn't working as intended

Cherry-picking

Commits picked from other conduit projects

Database

This requires or includes changes to the database

Dependencies

Something dependency related

Dependencies/Renovate

Automatic dependency upgrades by Renovate

Difficulty

Easy

Low difficulty to implement - touches few parts of the codebase, low complexity

Difficulty

Hard

High difficulty to implement - touches many parts of the codebase, high complexity

Difficulty

Medium

Medium difficulty to implement - touches more parts of the codebase, higher complexity

Documentation

Improvements or additions to documentation

Enhancement

New feature or request

Good first issue

Good for newcomers

Help wanted

Additional eyes and keyboards are required for this one

Inherited

Issues that have been inhereted from the project pre-fork

Matrix/Administration

Features pertaining to homeserver administration

Matrix/Appservices

Features pertaining to the appservice API

Matrix/Auth

Features pertaining to authentication

Matrix/Client

Features pertaining to client-to-server interactions

Matrix/Core

Issues relating to core matrix functionality, such as state resolution and PDU formats

Matrix/Federation

Features pertaining to server-to-server interactions

Matrix/Hydra

Matrix/MSC

Features pertaining to unstable matrix features

Matrix/Media

Features pertaining to media interactions

Rows
Columns

bug: Suspicious incorrect behaviour in federation get_missing_events endpoint #1336

bug: Suspicious incorrect behaviour in federation `get_missing_events` endpoint #1336