continuwuation/continuwuity
continuwuation/continuwuity
15
84
Fork 97
Code Issues 127 Pull requests 23 Releases 28 Packages 3 Activity Actions 5

bug: IPv6 literals are not validated correctly by the resolver #1587

New issue
Open
opened 2026-03-28 01:06:52 +00:00 by nex · 2 comments
nex commented 2026-03-28 01:06:52 +00:00
Owner
Copy link

Pretty sure this forgets to strip the square brackets around the IPv6 address, causing the parser to explode:

Lines 382 to 384 in 9209b84
let ip = IPAddress::parse(dest.host()).map_err(|e| {
err!(BadServerResponse(debug_error!("Failed to parse IP literal from string: {e}")))
})?; 

!admin debug resolve-true-destination [2a01:4f8:1c1e:a4f6::1]

Failed to parse IP literal from string: Invalid IP [2a01:4f8:1c1e:a4f6::1]

!admin debug resolve-true-destination [2a01:4f8:1c1e:a4f6::1]:8448

Failed to parse IP literal from string: Invalid IP [2a01:4f8:1c1e:a4f6::1]
Pretty sure this forgets to strip the square brackets around the IPv6 address, causing the parser to explode: https://forgejo.ellis.link/continuwuation/continuwuity/src/commit/9209b847f69041a1c7f2de6d8d8cdd922126d3c7/src/service/resolver/actual.rs#L382-L384 ``` !admin debug resolve-true-destination [2a01:4f8:1c1e:a4f6::1] Failed to parse IP literal from string: Invalid IP [2a01:4f8:1c1e:a4f6::1] ``` ``` !admin debug resolve-true-destination [2a01:4f8:1c1e:a4f6::1]:8448 Failed to parse IP literal from string: Invalid IP [2a01:4f8:1c1e:a4f6::1] ```
Jade commented 2026-03-28 01:18:59 +00:00
Owner
Copy link

Need to rip out the resolver anyway, new one fixes this.

Need to rip out the resolver anyway, [new one fixes this](https://forgejo.ellis.link/continuwuation/resolvematrix/src/branch/main/src/server.rs#L690).
s1lv3r commented 2026-04-08 11:44:59 +00:00
Contributor
Copy link

This should be fixed by #1505 (the entire actual.rs file gets nuked)

This should be fixed by #1505 (the entire actual.rs file gets nuked)
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
renovate/ruma-digest
renovate/node-patch-updates
renovate/reqwest-0.x
aranje/illegal-car-mods
ginger/ruma-upstreaming
renovate/ctor-0.x
renovate/serde_html_form-0.x
renovate/rand_core-0.x
jade/changelog-labels
nex/fix/v12-publishing
jade/build-info
jade/purge-sync-tokens
ginger/terms-and-conditions
ginger/remove-sliding-sync-proxy
nex/fix/pusher-association
nex/feat/policy-servers-2-electric-boogaloo
ginger/email-support
jade/community-guidelines
nex/fix/federation-format
jade/git-deps-updates
jade/changelog-check
jade/rust-1-92
ginger/password-reset
nex/experiment/push-gateway-logs
ginger/msc3575-obliteration
nex/feat/block-busted-rooms
nex/fix/informative-startup-errs
ginger/no-left-room-initial-sync
jade/docker-entrypoint
jade/dehydrated-devices
ginger/complement-fixes
nex/fix/stale-destination-cache
nex/experiment/sync-mutex
tcpipuk/docker-docs
jade/snafu
jade/rand-update
nex/stateres-refactor
ginger/779-in-troubleshooting
jade/liveit-guide
jade/http3
nex/feat/admin-hide-empty-rooms
ginger/oobe
nex/fix/debian-thingy
jade/ldap-admin-check
nex/fix/remote-restricted-joins
nex/feat/msc4406-sender-ignored
jade/deadlock-detection
nex/feat/room-shutdown
jade/get-started
jade/docs-guide
ginger/fix-local-invites
nex/fix/tpi
nex/feat/room-deletion
nex/feat/msc4322-media-redaction
ginger/stitched-order
ginger/deps/update-rspress
jade/admin-announce-improvements
ginger/xtask-improvements
jade/improve-admin-config-display
nex/fix/better-stateres-error-logs
jade/sender-timeouts
nex/feat/custom-v12-room-ids
ginger/update-metadata
nex/feat/admin-force-logout
tom/max-perf-docs
nex/fix/invalid-appservice-reg
nex/feat/antispam
nex/feat/account-locking
jade/logging-cleanup
jade/remove-legacy-appservice-auth
nex/fix/key-query
jade/update-prek
nex/fix/room-summaries
ginger/restrict-admin-commands
ginger/enable-console-by-default
jade/tag-fixes
jade/otlp
nex/meta/pull-req-template
nex/fix/fed-invite-compliance
nex/feat/build-commit
nex/feat/join-logging
jade/mailmap-updates
jade/hack-ci-tmp
jade/v12-stable
jade/relations
ginger/database-refactor
jade/fix-ldap-uiaa
nex/fix/validation
ginger/nuke-invalid-msc4133-fields-in-migration
ginger/downgrade-artifact-actions
oddlid/reload-fix
jade/fix-assert
ginger/sync-v3-cleanup
ginger/remove-absolute-action-urls
jade/website
nex/fix/backoff
ginger/fix-mdbook-for-0.5
ginger/no-docker-on-prs
backport/v0.5.0-rc.8-1
nex/fed-improvements
jade/rust-1.90
jade/mirror-dockerhub
jade/clippy-fixes
jade/fix-support
jade/clean-images
jade/wal-compression-type
jade/flake-clone
ginger/upload-rpms-on-schedule
nex/fix/incoming-fetch
nex/fix/upgrade
tom/ci-fedora-rpm
jade/ci-release-fix
jade/rocksdb-10-5
ginger/fix-msc4133-migration
ginger/migrate-busted-tz
hydra/public
nex/feat/manual-extremities
nex/feat/async-media
nex/feat/fast-joins-hack-do-not-use-DO-NOT-USE
nex/feat/better-logging
trigger-ci-so-latest-isnt-on-illegal-car-mods
nex/feat/pins-backfill
jade/tuwunel-2025-06-old
jade/ai-slop-db-docs
nex/fix-create-auth
jade/version-stats
jade/read-receipts
jade/rust-toolchain-no-targets
jade/logging-features
jade/syncv5-typing
jade/msc2815
morguldir/see-eye
jade/css-small-screen
nex/wip-751
tuwunel-rebase
test
oddlid/rename-admin-room-bot
strawberry/nix-ci-stuff
strawberry/valgrind
phonemain
strawberry/morgs-snake-sync-jason-main
newer-media-endpoints
folly-coroutines-async-io
federation-retry-timer-port
bad-attempt-at-extracting-homeserver-signing-key
room-deletion-attempt-do-not-use
v0.5.7
v0.5.7-alpha.2
v0.5.7-alpha.1
v0.5.6
v0.5.6-alpha
v0.5.5
v0.5.4
v0.5.3
v0.5.2
v0.5.1
v0.5.0
v0.5.0-rc.8.1
v0.5.0-rc.8
v0.5.0-rc.7
v0.5.0-rc.6
v0.5.0-rc.5
v0.5.0-rc4
v0.5.0-rc3
v0.5.0-rc2
v0.5.0-rc
v0.4.7-rc
v0.4.6
v0.4.6-rc
v0.4.5-rc
v0.4.5
v0.4.4
v0.4.3
v0.4.2
v0.4.1
v0.3.4
v0.3.3
v0.3.2
v0.3.1
v0.3.0
Labels
Clear labels   
Blocked

This pull request or issue is currently blocked from being merged/closed

  
Bug

Something isn't working as intended

  
Changelog
Added
Changelog entry added

  
Changelog
Missing
No changelog when one is needed

  
Changelog
None
Changelog is unnecesary for this change

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Dependencies/Renovate

Automatic dependency upgrades by Renovate

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

Issues relating to core matrix functionality, such as state resolution and PDU formats

  
Matrix/E2EE

Issues related to end to end encryption

  
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/Hydra

Issues related to room version 12 and related changes (temporary label)

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Matrix/T&S

Changes or issues related to trust & safety tooling

  
Merge

This PR is ready to be merged

  
Merge/Manual

This PR should be manually merged

  
Merge/Squash

This PR should be squashed when it is merged

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/CI

Issues related to CI changes

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status
Confirmed
This issue has enough information and is confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
Support

Questions or support requests

  
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Blocked
Bug
Changelog
Added
Changelog
Missing
Changelog
None
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/E2EE
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Matrix/T&S
Merge
Merge/Manual
Merge/Squash
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Support
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity#1587
No description provided.