Query notaries in parallel #1730
Labels
No labels
Blocked
Bug
Changelog
Added
Changelog
Missing
Changelog
None
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/E2EE
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Matrix/T&S
Merge
Merge/Manual
Merge/Squash
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Support
Wont fix
old/ci/cd
old/rust
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
continuwuation/continuwuity#1730
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Right now, each Notary Server is queried in sequence, if the one before it did not have the key. This is good for performance, but bad for security, since the first notary Server can serve you arbitrary keys.
I think it would be better to query all configured trusted servers in parallel and use the response the majority responded with, since that is much more likely to be the right key.
I am aware that these Servers are supposed to be trusted, but in reality you often do not really have "trusted servers", and it would still be good to put less trust on them.
Relevant code (I think): https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/src/service/server_keys/acquire.rs#L195-L223
Querying notaries in parallel is a planned enhancement but we can't do that majority thing suggested for security reasons