main branch no longer delivers transactions to appservices #1890
Labels
No labels
Abandoned
Blocked
Bug
Changelog
Added
Changelog
Missing
Changelog
None
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/E2EE
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Matrix/T&S
Merge
Merge/Manual
Merge/Squash
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Support
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
continuwuation/continuwuity#1890
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I found out earlier that my messages haven’t been sending from matrix to various mautrix bridges. It appears that the transactions are never sent to the bridge (but transactions from the bridge are processed!)
i bisected the changes made and this was the result:
git bisect log
Interestingly, the one commit affecting appservice sending directly was good.
the issue is consistent for me (regardless of how often i restart continuwuity it doesn’t deliver appservice transactions on the affected versions, but do on the unaffected versions)
nothing relevant is logged and based on git bisect output it appears that the regression was introduced in
199f6eb67bsetup: custom continuwuity currently using
27367bac(affected) on nixosbridge: mautrix-telegram [
github.com/mautrix/telegram@5bfc5bb0cf](latest main branch version)appservice registration uses localhost http instead of going over the network somehow
Issue found, lost an
appservice.rooms.is_match(room_id.as_str())conditionI think the issue is that the appservice_in_room condition got lost too. lemme patch both