main branch no longer delivers transactions to appservices #1890

Open
opened 2026-06-30 18:10:26 +00:00 by DarkKirb · 2 comments

I found out earlier that my messages haven’t been sending from matrix to various mautrix bridges. It appears that the transactions are never sent to the bridge (but transactions from the bridge are processed!)

i bisected the changes made and this was the result:

git bisect log
# status: waiting for both good and bad commits
# good: [21e93f8feb00410e3a55f1766578346eb371aa5f] chore: changelog
git bisect good 21e93f8feb00410e3a55f1766578346eb371aa5f
# status: waiting for bad commit, 1 good commit known
# bad: [27367bac18409815d79f02cae3ba3ec60cb00cdb] chore(deps): update github-actions-non-major
git bisect bad 27367bac18409815d79f02cae3ba3ec60cb00cdb
# bad: [ae572ec1085410a0b069b854a16d8f2eb8bcbf4f] style: Refactor key_backups service
git bisect bad ae572ec1085410a0b069b854a16d8f2eb8bcbf4f
# bad: [ecbe035b361a292d8b02b421b3ddf0a94b201a9a] style: Document & refactor rooms/short service
git bisect bad ecbe035b361a292d8b02b421b3ddf0a94b201a9a
# good: [a3994fe1a3d0061c33e5448663582702bcedc806] style: Document & refactor server_keys service
git bisect good a3994fe1a3d0061c33e5448663582702bcedc806
# bad: [6603798d60d9710cdfd1d1ce91dc3d2709836d38] style: Document & refactor rooms/state_compressor service
git bisect bad 6603798d60d9710cdfd1d1ce91dc3d2709836d38
# bad: [199f6eb67b29c3af5ce2f0d61cf0f4420422c1ca] style: Document & refactor rooms/user and rooms/timeline services
git bisect bad 199f6eb67b29c3af5ce2f0d61cf0f4420422c1ca
# good: [aa2f506996840bd9b667709f2c44807d9bc62ea2] style: Document & refactor sending service
git bisect good aa2f506996840bd9b667709f2c44807d9bc62ea2
# first bad commit: [199f6eb67b29c3af5ce2f0d61cf0f4420422c1ca] style: Document & refactor rooms/user and rooms/timeline services

Interestingly, the one commit affecting appservice sending directly was good.

the issue is consistent for me (regardless of how often i restart continuwuity it doesn’t deliver appservice transactions on the affected versions, but do on the unaffected versions)

nothing relevant is logged and based on git bisect output it appears that the regression was introduced in 199f6eb67b

setup: custom continuwuity currently using 27367bac (affected) on nixos
bridge: mautrix-telegram [github.com/mautrix/telegram@5bfc5bb0cf](latest main branch version)
appservice registration uses localhost http instead of going over the network somehow

I found out earlier that my messages haven’t been sending from matrix to various mautrix bridges. It appears that the transactions are never sent to the bridge (but transactions from the bridge are processed!) i bisected the changes made and this was the result: <details> <summary>git bisect log</summary> <pre> # status: waiting for both good and bad commits # good: [21e93f8feb00410e3a55f1766578346eb371aa5f] chore: changelog git bisect good 21e93f8feb00410e3a55f1766578346eb371aa5f # status: waiting for bad commit, 1 good commit known # bad: [27367bac18409815d79f02cae3ba3ec60cb00cdb] chore(deps): update github-actions-non-major git bisect bad 27367bac18409815d79f02cae3ba3ec60cb00cdb # bad: [ae572ec1085410a0b069b854a16d8f2eb8bcbf4f] style: Refactor key_backups service git bisect bad ae572ec1085410a0b069b854a16d8f2eb8bcbf4f # bad: [ecbe035b361a292d8b02b421b3ddf0a94b201a9a] style: Document & refactor rooms/short service git bisect bad ecbe035b361a292d8b02b421b3ddf0a94b201a9a # good: [a3994fe1a3d0061c33e5448663582702bcedc806] style: Document & refactor server_keys service git bisect good a3994fe1a3d0061c33e5448663582702bcedc806 # bad: [6603798d60d9710cdfd1d1ce91dc3d2709836d38] style: Document & refactor rooms/state_compressor service git bisect bad 6603798d60d9710cdfd1d1ce91dc3d2709836d38 # bad: [199f6eb67b29c3af5ce2f0d61cf0f4420422c1ca] style: Document & refactor rooms/user and rooms/timeline services git bisect bad 199f6eb67b29c3af5ce2f0d61cf0f4420422c1ca # good: [aa2f506996840bd9b667709f2c44807d9bc62ea2] style: Document & refactor sending service git bisect good aa2f506996840bd9b667709f2c44807d9bc62ea2 # first bad commit: [199f6eb67b29c3af5ce2f0d61cf0f4420422c1ca] style: Document & refactor rooms/user and rooms/timeline services </pre> </details> Interestingly, the one commit affecting appservice sending directly was good. the issue is consistent for me (regardless of how often i restart continuwuity it doesn’t deliver appservice transactions on the affected versions, but do on the unaffected versions) nothing relevant is logged and based on git bisect output it appears that the regression was introduced in 199f6eb67b29c3af5ce2f0d61cf0f4420422c1ca setup: custom continuwuity currently using 27367bac (affected) on nixos bridge: mautrix-telegram [https://github.com/mautrix/telegram/commit/5bfc5bb0cf365783daaf65453161e4a012d59719](latest main branch version) appservice registration uses localhost http instead of going over the network somehow
Owner

Issue found, lost an appservice.rooms.is_match(room_id.as_str()) condition

Issue found, lost an `appservice.rooms.is_match(room_id.as_str())` condition
Author

I think the issue is that the appservice_in_room condition got lost too. lemme patch both

I think the issue is that the appservice_in_room condition got lost too. lemme patch both
Sign in to join this conversation.
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity#1890
No description provided.