Fix up CI, including making release builds with different features and variants available as artifacts #2

Closed
opened 2023-11-30 05:51:42 +00:00 by girlbossceo · 2 comments
girlbossceo commented 2023-11-30 05:51:42 +00:00 (Migrated from github.com)

Also might consider removing the Docker stuff, I'm not interested in packaging container stuff unless someone wants to help with that

Also might consider removing the Docker stuff, I'm not interested in packaging container stuff unless someone wants to help with that
CobaltCause commented 2023-12-21 01:39:10 +00:00 (Migrated from github.com)

Since #8, there is now CI for:

  • rustfmt'ing
  • rustdoc lints
  • clippy lints
  • rust tests
Since #8, there is now CI for: * rustfmt'ing * rustdoc lints * clippy lints * rust tests
girlbossceo commented 2024-01-31 21:25:34 +00:00 (Migrated from github.com)

Still missing publishing to GitHub Container registry and Docker, and I would like to add additional targets like x86_64-unknown-linux-musl-sha256-media so it builds with the sha256_media feature but I'm so burnt out from this nix CI stuff so I'll maybe deal with it another time.

All artifacts outputted only have default features. I don't think many people are using sha256_media anyways except for me.

I was also left with no choice but to revert back to latest stable rust-rocksdb because of incredibly frustrating linker issues, but considering they said they would release a new version soon (https://github.com/rust-rocksdb/rust-rocksdb/issues/858#issuecomment-1918976791) I think this is fine as a temporary thing.

As is, it should be working the same as upstream and should be good enough.

Still missing publishing to GitHub Container registry and Docker, and I would like to add additional targets like `x86_64-unknown-linux-musl-sha256-media` so it builds with the `sha256_media` feature but I'm so burnt out from this nix CI stuff so I'll maybe deal with it another time. All artifacts outputted only have default features. I don't think many people are using sha256_media anyways except for me. I was also left with no choice but to revert back to latest stable rust-rocksdb because of incredibly frustrating linker issues, but considering they said they would release a new version soon (https://github.com/rust-rocksdb/rust-rocksdb/issues/858#issuecomment-1918976791) I think this is fine as a temporary thing. As is, it should be working the same as upstream and should be good enough.
This discussion has been locked. Commenting is limited to contributors.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity#2
No description provided.