Assertion failed: event passed to `get_missing_events` is not missing any events #2018

New issue

Open

opened 2026-07-17 21:55:07 +00:00 by thetayloredman · 0 comments

thetayloredman commented

2026-07-17 21:55:07 +00:00

Contributor

In some unknown situation, this debug assertion in get_missing_events can fail and panic with the following:

thread 'conduwuit:worker' (57136) panicked at src/service/rooms/event_handler/fetch_and_handle_outliers.rs:163:4:
assertion `left != right` failed: event passed to get_missing_events is not missing any events (wasteful call)
  left: 0
 right: 0

This seemed to occur after the server was offline for a moment. The relevant logs are attached.

Outlier PDU: $PeepB7wTZYIwV2XECPccPm7v2h0RIaGwCjwKd89mJVE

{
  "auth_events": [
    "$xtqWJ5HAp8rQxURMRrECxMYpPoCBvi4o-zdRvFoZPLM",
    "$EDlE-3kXsDT-HXJfCxqHM86t8-jBf6BARXLZKCDmDvQ"
  ],
  "content": {
    "m.relates_to": {
      "event_id": "$BxhNQHLOsSEg0R_cwqT2zO4k3pSTqONF3DmCvcyHTpw",
      "key": "😭",
      "rel_type": "m.annotation"
    }
  },
  "depth": 12638,
  "event_id": "$PeepB7wTZYIwV2XECPccPm7v2h0RIaGwCjwKd89mJVE",
  "hashes": {
    "sha256": "T0+BccrhQKTvYHDF2CLo4BdPndWLy4d4ZE+OLQZfvFY"
  },
  "origin_server_ts": 1784322448515,
  "prev_events": [
    "$MbmE2u3K9R0L62mYm4q7MFbNu2Dmclby7pxnvXCDbEY"
  ],
  "room_id": "!kgoc2ebwy1GOVtzOr5_-tXVTvzSHgtGaMSI_i59vogs",
  "sender": "@logn:zirco.dev",
  "signatures": {
    "policyserv.zirco.dev": {
      "ed25519:policy_server": "3fBHDJppLWmdvSPcPvwBeezqCqS6Ww0RTmQrEmhGYWdLiLymw6vuqt+ky5HI9s9PF9U6rBE7cVBR8tqgPP30DA"
    },
    "zirco.dev": {
      "ed25519:a_mkrB": "eVzuWskYS19LsR4xWBl7hJyI91WqIY06PVCaOANBc9wryG8qWuYSG73znj2fUs7Os0+vPP03a4D659Eq1kxACA"
    }
  },
  "type": "m.reaction"
}

The prev_event $MbmE2u3K9R0L62mYm4q7MFbNu2Dmclby7pxnvXCDbEY reports "PDU not found locally."

In some unknown situation, [this debug assertion in `get_missing_events`](https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/src/service/rooms/event_handler/fetch_and_handle_outliers.rs#L163-L166) can fail and panic with the following: ``` thread 'conduwuit:worker' (57136) panicked at src/service/rooms/event_handler/fetch_and_handle_outliers.rs:163:4: assertion `left != right` failed: event passed to get_missing_events is not missing any events (wasteful call) left: 0 right: 0 ``` This seemed to occur after the server was offline for a moment. The relevant logs are attached. <details> <summary>Outlier PDU: <code>$PeepB7wTZYIwV2XECPccPm7v2h0RIaGwCjwKd89mJVE</code></summary> ```json { "auth_events": [ "$xtqWJ5HAp8rQxURMRrECxMYpPoCBvi4o-zdRvFoZPLM", "$EDlE-3kXsDT-HXJfCxqHM86t8-jBf6BARXLZKCDmDvQ" ], "content": { "m.relates_to": { "event_id": "$BxhNQHLOsSEg0R_cwqT2zO4k3pSTqONF3DmCvcyHTpw", "key": "😭", "rel_type": "m.annotation" } }, "depth": 12638, "event_id": "$PeepB7wTZYIwV2XECPccPm7v2h0RIaGwCjwKd89mJVE", "hashes": { "sha256": "T0+BccrhQKTvYHDF2CLo4BdPndWLy4d4ZE+OLQZfvFY" }, "origin_server_ts": 1784322448515, "prev_events": [ "$MbmE2u3K9R0L62mYm4q7MFbNu2Dmclby7pxnvXCDbEY" ], "room_id": "!kgoc2ebwy1GOVtzOr5_-tXVTvzSHgtGaMSI_i59vogs", "sender": "@logn:zirco.dev", "signatures": { "policyserv.zirco.dev": { "ed25519:policy_server": "3fBHDJppLWmdvSPcPvwBeezqCqS6Ww0RTmQrEmhGYWdLiLymw6vuqt+ky5HI9s9PF9U6rBE7cVBR8tqgPP30DA" }, "zirco.dev": { "ed25519:a_mkrB": "eVzuWskYS19LsR4xWBl7hJyI91WqIY06PVCaOANBc9wryG8qWuYSG73znj2fUs7Os0+vPP03a4D659Eq1kxACA" } }, "type": "m.reaction" } ``` </details> The `prev_event` `$MbmE2u3K9R0L62mYm4q7MFbNu2Dmclby7pxnvXCDbEY` reports "PDU not found locally."

continuwuity.log

127 KiB