bug: `/relations` recurses even without `recurse` #2469

New issue

Closed

opened 2026-11-07 15:44:25 +00:00 by Henry-Hiles · 0 comments

Henry-Hiles commented

2026-11-07 15:44:25 +00:00

Member

What is the bug?

As title says, recursion in relations when not wanted.

Steps to reproduce

call /relations without recurse, watch it recurse

Server name and version

federated.nexus + local repro, 02aed4fb23

Additional context

	`// Spec (v1.10) recommends depth of at least 3`
	`let depth: u8 = if recurse { 3 } else { 1 };`

 		let mut stack: Vec<_> = pdus
 			.iter()
 			.filter(|_| max_depth > 0)
 			.map(|pdu| (pdu.clone(), 1))
 			.collect();

 			for relation in relations {
 				if stack_pdu.1 < max_depth {
 					stack.push((relation.clone(), stack_pdu.1.saturating_add(1)));
 				}
 				pdus.push(relation);

### What is the bug? As title says, recursion in relations when not wanted. ### Steps to reproduce call `/relations` without `recurse`, watch it recurse ### Server name and version federated.nexus + local repro, https://forgejo.ellis.link/continuwuation/continuwuity/commit/02aed4fb23504f54ed068c51175959c2cc71d8d0 ### Additional context https://forgejo.ellis.link/continuwuation/continuwuity/src/commit/02aed4fb23504f54ed068c51175959c2cc71d8d0/src/api/client/relations.rs#L150-L151 https://forgejo.ellis.link/continuwuation/continuwuity/src/commit/02aed4fb23504f54ed068c51175959c2cc71d8d0/src/service/rooms/pdu_metadata/mod.rs#L84-L88 https://forgejo.ellis.link/continuwuation/continuwuity/src/commit/02aed4fb23504f54ed068c51175959c2cc71d8d0/src/service/rooms/pdu_metadata/mod.rs#L103-L108

Henry-Hiles added the

Bug

Status

Needs Investigation

labels

2026-11-07 15:44:25 +00:00

Henry-Hiles referenced this issue from a pull request that will close it,

2026-11-07 15:57:28 +00:00

fix: Correct relations pagination and recursion #2465