bug: Continuwuity server doesn't authenticate Cubitrix client #2536
Labels
No labels
Abandoned
Blocked
Bug
Changelog
Added
Changelog
Missing
Changelog
None
Cherry-picking
Compliance
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/E2EE
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Matrix/T&S
Merge
Merge/Manual
Merge/Squash
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Support
bob the builder
No milestone
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
continuwuation/continuwuity#2536
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What is the bug?
Not exactly a bug to be honest, but rather an interoperability issue.
I created a PR to fix this issue: !2535
Cubitrix sends the
redirect URIwith a specified port to/_continuwuity/oauth2/client/register.Today, the OAuth logic explicitly rejects URIs with ports, as in
src/service/oauth/client_metadata.rs#L94I understand the actual port is specified later during the
login()authorization request, which follows the specs. However, rejecting the URI entirely causes client registration to fail, which isn't a great user experience.Would it make sense to simply strip the port during registration instead of returning an error? This would preserve the existing behavior while improving compatibility with clients that include an explicit port.
For reference, the same Cubitrix login flow works fine when using
matrix.orgas the homeserver.Steps to reproduce
Server name and version
continuwuity 26.9.1 (
046074b)Additional context
No response
This sounds like a client issue to me, and should be fixed by the client.
This is a problem with the Cubitrix client. Continuwuity implements OAuth metadata validation as described in the Matrix specification.