add confirm option + error for open reg, remove false_fn, change rocksdb default log level to warn #28

Merged

girlbossceo merged 9 commits from open-reg-confirmation into main

2023-12-25 22:07:25 +00:00

girlbossceo commented

2023-12-23 04:34:08 +00:00

(Migrated from github.com)

this option and start warning/error will make sure the user is fully aware if their server is configured for open reg. remove false_fn as just default always evaluates to false, and move default rocksdb log level to warn as info is still outputting useless db stats to LOG file.

Solves https://github.com/girlbossceo/conduwuit/issues/23

CobaltCause (Migrated from github.com) reviewed

2023-12-24 06:23:08 +00:00

src/main.rs

This should probably be a warn!()

This should probably be a `warn!()`

src/service/globals/mod.rs

Does this actually get called anywhere?

girlbossceo (Migrated from github.com) reviewed

2023-12-24 06:40:49 +00:00

src/service/globals/mod.rs

No, though I think there are a fair amount of options that have functions like these that never get called anywhere. I can remove it here but might need to clean these up, I always added them there just to follow the style of adding new config options.

girlbossceo (Migrated from github.com) reviewed

2023-12-24 06:42:07 +00:00

src/main.rs

I made it an error to make it more obvious in logs, and just in case they only log errors. Considered just doing println or something.

I made it an error to make it more obvious in logs, and just in case they only log errors. Considered just doing `println` or something.

CobaltCause (Migrated from github.com) reviewed

2023-12-24 08:02:29 +00:00

src/main.rs

It's not technically an error to configure your HS this way. Using println!() probably isn't great in the case of more advanced logging configurations that deal directly with tracing, it might get lost. I think the option's name should make it clear enough.

It's not technically an *error* to configure your HS this way. Using `println!()` probably isn't great in the case of more advanced logging configurations that deal directly with `tracing`, it might get lost. I think the option's name should make it clear enough.