continuwuation/continuwuity

Watch

feat: retroactively inject `prev_content` when backfilling state events #569

New issue

Closed

opened 2024-09-06 22:52:15 +00:00 by frebib · 3 comments

frebib commented

2024-09-06 22:52:15 +00:00

(Migrated from github.com)

Following the information in https://github.com/matrix-org/matrix-rust-sdk/issues/3960 it appears that prev_content is missing in a state event, causing the client to display the wrong membership transition

Following the information in https://github.com/matrix-org/matrix-rust-sdk/issues/3960 it appears that prev_content is missing in a state event, causing the client to display the wrong membership transition

girlbossceo commented

2024-09-07 00:31:14 +00:00

(Migrated from github.com)

Just for reference, this appears to be reproducible on Synapse too based on my (light and unscientific) testing by observing client behaviour on constellatory.net (Synapse), puppygock.gay (conduwuit), and girlboss.ceo (conduwuit).

Just for reference, this appears to be reproducible on Synapse too based on my (light and unscientific) testing by observing client behaviour on constellatory.net (Synapse), puppygock.gay (conduwuit), and girlboss.ceo (conduwuit).

nex added the

label

2025-04-14 23:37:51 +00:00

nex added the

label

2025-05-31 00:04:18 +00:00

nex added

Matrix/Federation

and removed

labels

2025-10-12 22:08:01 +00:00

nex commented

2025-10-12 22:08:07 +00:00

Owner

The fix for this would be to, while processing a backfill chunk, order the state events returned, and work backwards from the last known event of that type, and updating the unsigned data in the database. probably not too difficult but sounds hard to optimise

The fix for this would be to, while processing a backfill chunk, order the state events returned, and work backwards from the last known event of that type, and updating the unsigned data in the database. probably not too difficult but sounds hard to optimise

nex changed title from ~~prev_content is sometimes missing from state events~~ to feat: retroactively inject prev_content when backfilling state events

2025-10-12 22:08:44 +00:00

nex commented

2025-10-12 22:09:03 +00:00

Owner

Marking this as a feature request as this is currently behaviour no other server implements and thus isn't really a bug

Marking this as a feature request as this is currently behaviour no other server implements and thus isn't really a bug

nex referenced this issue from a pull request that will close it,

2026-09-20 23:45:00 +00:00

refactor: Don't embed unsigned in storage #2270

nex closed this issue

2026-09-27 18:42:52 +00:00

This discussion has been locked. Commenting is limited to contributors.

No labels

Dependencies/Renovate

Good first issue

Matrix/Administration

Matrix/Appservices

Matrix/Federation

Needs Investigation

bob the builder

No milestone

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

continuwuation/continuwuity#569

No description provided.