continuwuation/continuwuity
8
20
Fork 18
Code Issues 82 Pull requests 8 Projects Releases 17 Packages 1 Activity Actions

bans are too persistent #855

New issue
Closed
opened 2025-06-18 16:26:57 +00:00 by nex · 5 comments
nex commented 2025-06-18 16:26:57 +00:00
Owner
Copy link

Sometimes, when a user is banned and then unbanned, we don't seem to (receive? validate? allow?) the unban, meaning the ban gets stuck, and and subsequent join attempts fail. Somehow, this even means accepting an invite results in a "you're banned" error.

This is worked around by having a second account join the room to receive the updated state (why dont we get this anyway?)

Sometimes, when a user is banned and then unbanned, we don't seem to (receive? validate? allow?) the unban, meaning the ban gets stuck, and and subsequent join attempts fail. Somehow, this even means accepting an invite results in a "you're banned" error. This is worked around by having a second account join the room to receive the updated state (why dont we get this anyway?)
nex added the
Bug
Matrix/Client
Matrix/Federation
Status
Needs Investigation
 labels 2025-06-18 16:26:57 +00:00
Jade commented 2025-06-19 21:29:32 +00:00
Owner
Copy link

If no accounts in a room or on the server then we don't receive events from the room - so the state that we have is out of date. I need to look into this more, but it's likely that we should ignore any room state that we already have when trying to join a room from that state

If no accounts in a room or on the server then we don't receive events from the room - so the state that we have is out of date. I need to look into this more, but it's likely that we should ignore any room state that we already have when trying to join a room from that state
nex commented 2025-06-19 21:42:45 +00:00
Author
Owner
Copy link

That would make sense if this were a persistent issue, but it isn't. When a membership is changed, we tell the target server even if they aren't in the room, so I'm not too sure how this is happening in the first place

That would make sense if this were a persistent issue, but it isn't. When a membership is changed, we tell the target server even if they aren't in the room, so I'm not too sure how this is happening in the first place
Jade commented 2025-06-19 22:00:51 +00:00
Owner
Copy link

A step through debugger on an instance of this would be helpful

A step through debugger on an instance of this would be helpful
nex commented 2025-06-20 15:30:44 +00:00
Author
Owner
Copy link

A step-through debugger would probably solve most of our problems 🧌

A step-through debugger would probably solve most of our problems 🧌
nex commented 2025-06-28 14:54:21 +00:00
Author
Owner
Copy link

Travis suggested that https://github.com/matrix-org/synapse/pull/15323 may be related, and it does indeed look like the same thing we're running into (i.e. host not in room with dead state). Mirroring the synapse changes into our own code might fix the issue

Travis suggested that https://github.com/matrix-org/synapse/pull/15323 may be related, and it does indeed look like the same thing we're running into (i.e. host not in room with dead state). Mirroring the synapse changes into our own code might fix the issue
nex added
Status
Confirmed
 and removed
Status
Needs Investigation
 labels 2025-06-28 18:56:20 +00:00
nex closed this issue 2025-06-29 12:14:21 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
jade/musl-images
illegal-car-mods
nex/serving-policy
trigger-ci-so-latest-isnt-on-illegal-car-mods
jade/parking_lot
jade/docs-updates-20250701
nex/fix/msc4307
nex/feat/pins-backfill
jade/upload-ci-binaries
jade/admin-command-docs
jade/tuwunel-2025-06
jade/tuwunel-2025-06-old
jade/ai-slop-db-docs
nex/fix-create-auth
jade/version-stats
jade/read-receipts
dahsa_uwu/axum-0.8
jade/rust-toolchain-no-targets
jade/logging-features
jade/syncv5-typing
jade/msc2815
jade/relations
jade/purge-sync-tokens
morguldir/see-eye
jade/css-small-screen
nex/wip-751
tuwunel-rebase
test
oddlid/rename-admin-room-bot
strawberry/nix-ci-stuff
strawberry/valgrind
strawberry/morgs-snake-sync-jason-main
newer-media-endpoints
folly-coroutines-async-io
federation-retry-timer-port
bad-attempt-at-extracting-homeserver-signing-key
room-deletion-attempt-do-not-use
v0.5.0-rc.6
v0.5.0-rc.5
v0.5.0-rc4
v0.5.0-rc3
v0.5.0-rc2
v0.5.0-rc
v0.4.7-rc
v0.4.6
v0.4.6-rc
v0.4.5-rc
v0.4.5
v0.4.4
v0.4.3
v0.4.2
v0.4.1
v0.3.4
v0.3.3
v0.3.2
v0.3.1
v0.3.0
Labels
Clear labels   
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

   
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status
Confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Bug
Cherry-picking
Database
Dependencies
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/Federation
Matrix/MSC
Matrix/Media
Meta
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: continuwuation/continuwuity#855
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?