bug: Nix package build fails as test wants resolv.conf #2495
Labels
No labels
Abandoned
Blocked
Bug
Changelog
Added
Changelog
Missing
Changelog
None
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/E2EE
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Matrix/T&S
Merge
Merge/Manual
Merge/Squash
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Support
bob the builder
compliance
No milestone
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
continuwuation/continuwuity#2495
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What is the bug?
admitted_joins_do_not_disappear_after_a_mergewants a systemresolv.confand errors out otherwise.This breaks the nix package builds, including the static binary build for the alpha.
Steps to reproduce
nix build https://forgejo.ellis.link/continuwuation/continuwuityServer name and version
N/A,
93173313eaAdditional context
Mentioned in https://matrix.to/#/!c10y-8Hm3mAW99j9KEKoWPQH2M_FxGwG-EVHK06iLKg/$nyYKlU8FiupYYVlMiS1ZGeGheJtHtZ3JHqCNj039lfU?via=continuwuity.org&via=matrix.org&via=continuwuity.rocks.
bug: Nix failing to build as test wantsto bug: Nix build fails as test wantsresolv.confresolv.confbug: Nix build fails as test wantsto bug: Nix package build fails as test wantsresolv.confresolv.confTLDR for why this happens: When creating a DNS resolver, the code tries to read /etc/resolv.conf and fails early if it doesn't exist, even if you have set
CONTINUWUITY_DNS_SERVERS.Fix will be to only fail if both the file doesn't exist and the config parameter hasn't been set, and then setting the config param in the test.