feat: Update default cache ttl to 24 hours #20

s1lv3r · 2026-07-05T00:42:44Z

s1lv3r commented

2026-07-05 00:42:44 +00:00

See-Also: https://matrix.to/#/!ksTlboXVgcyWjv5GrlEeKyQuJ8ZCprnwQx2b6-BQ44Q/%24uPMp45RGebI2A6UNOUgT3LVQTrFibTzWZ_Cnz5iL-WY?via=wolfgirl.pet&via=explodie.org&via=matrix.org through https://matrix.to/#/!ksTlboXVgcyWjv5GrlEeKyQuJ8ZCprnwQx2b6-BQ44Q/%24Fp4mcdlNrY43BQXG3FrNHBIqumqe-NGtXA0_99jx6uo?via=wolfgirl.pet&via=explodie.org&via=matrix.org

s1lv3r added 1 commit

2026-07-05 00:42:44 +00:00

feat: Update default cache ttl to 24 hours

Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m57s

Details

Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 3m7s

Details

Checks / Prek / Pre-commit & Formatting (push) Successful in 1m54s

Details

Checks / Prek / Clippy and Cargo Tests (push) Failing after 3m4s

Details

79ccc3e479

See-Also: https://matrix.to/#/!ksTlboXVgcyWjv5GrlEeKyQuJ8ZCprnwQx2b6-BQ44Q/%24uPMp45RGebI2A6UNOUgT3LVQTrFibTzWZ_Cnz5iL-WY?via=wolfgirl.pet&via=explodie.org&via=matrix.org through https://matrix.to/#/!ksTlboXVgcyWjv5GrlEeKyQuJ8ZCprnwQx2b6-BQ44Q/%24Fp4mcdlNrY43BQXG3FrNHBIqumqe-NGtXA0_99jx6uo?via=wolfgirl.pet&via=explodie.org&via=matrix.org

nex requested changes

2026-07-05 00:44:06 +00:00

Dismissed

nex left a comment

woof

src/server.rs

					
				@ -172,3 +172,3 @@

				        }

				        let cache = self.resolution_cache.unwrap_or(Cache::new(

				            self.cache_ttl.unwrap_or(Duration::from_secs(300)),

				            self.cache_ttl.unwrap_or(Duration::from_secs(60 * 60 * 24)),

Duration::from_hours(24) ?

`Duration::from_hours(24)` ?

MSRV error:

cargo clippy.............................................................Failed
- hook id: cargo-clippy
- exit code: 101
  Checking resolvematrix v0.1.0 (/home/s1lv3r/kode/resolvematrix)
  error: current MSRV (Minimum Supported Rust Version) is `1.88.0` but this item is stable since `1.91.0`
     --> src/server.rs:174:38
      |
  174 |             self.cache_ttl.unwrap_or(Duration::from_hours(24)),
      |                                      ^^^^^^^^^^^^^^^^^^^^
      |
      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#incompatible_msrv
      = note: `-D clippy::incompatible-msrv` implied by `-D warnings`
      = help: to override `-D warnings` add `#[allow(clippy::incompatible_msrv)]`
  error: could not compile `resolvematrix` (lib) due to 1 previous error

MSRV error: ``` cargo clippy.............................................................Failed - hook id: cargo-clippy - exit code: 101 Checking resolvematrix v0.1.0 (/home/s1lv3r/kode/resolvematrix) error: current MSRV (Minimum Supported Rust Version) is `1.88.0` but this item is stable since `1.91.0` --> src/server.rs:174:38 | 174 | self.cache_ttl.unwrap_or(Duration::from_hours(24)), | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#incompatible_msrv = note: `-D clippy::incompatible-msrv` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::incompatible_msrv)]` error: could not compile `resolvematrix` (lib) due to 1 previous error ```