chore: Add more tests for `Cache`, fix edge case in `Cache::get(server_name)` #29

Merged

ginger merged 1 commit from zoe/additional-tests into main

2026-07-09 16:47:25 +00:00

s1lv3r commented

2026-07-08 21:33:35 +00:00

Member

More tests added to reach 100% line coverage when running tests with coverage. Also adds some more doc comments on methods.

The edgecase fix is that .get() would previously remove a cached entry if it was expired, without removing the associated hostname mapping. This could possibly result in a CacheLookup::ExpiredOverride being returned when there is no cache entry at all, and the correct return value is CacheLookup::Miss.

The fix here is to also remove the hostname mapping, correctly making CacheLookup::Miss be returned.

More tests added to reach 100% line coverage when running tests with coverage. Also adds some more doc comments on methods. The edgecase fix is that `.get()` would previously remove a cached entry if it was expired, without removing the associated hostname mapping. This could possibly result in a `CacheLookup::ExpiredOverride` being returned when there is no cache entry at all, and the correct return value is `CacheLookup::Miss`. The fix here is to also remove the hostname mapping, correctly making `CacheLookup::Miss` be returned.

s1lv3r added 1 commit

2026-07-08 21:33:35 +00:00

chore: Add more tests for Cache, fix edge case in Cache::get(server_name)

Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 42s

Details

Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 1m51s

Details

Checks / Prek / Pre-commit & Formatting (push) Successful in 1m48s

Details

Checks / Prek / Clippy and Cargo Tests (push) Successful in 2m24s

Details

6ef266e76a

More tests added to reach 100% line coverage when running tests with
coverage. Also adds some more doc comments on methods.

The edgecase fix is that `.get()` would previously remove a cached
entry if it was expired, without removing the associated hostname
mapping. This could possibly result in a `CacheLookup::ExpiredOverride`
being returned when there is no cache entry at all, and the correct
return value is `CacheLookup::Miss`.

The fix here is to also remove the hostname mapping, correctly making
`CacheLookup::Miss` be returned.

s1lv3r scheduled this pull request to auto merge when all checks succeed

2026-07-09 11:03:46 +00:00