feat: Create MatrixResolver::create_dns_resolver() #30

s1lv3r · 2026-07-09T23:43:32Z

s1lv3r commented

2026-07-09 23:43:32 +00:00

Returns a MatrixDnsResolver which correctly implements DNS caching for correct SNI behavior.

Returns a `MatrixDnsResolver` which correctly implements DNS caching for correct SNI behavior.

s1lv3r added 1 commit

2026-07-09 23:43:32 +00:00

feat: Create MatrixResolver::create_dns_resolver()

Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m12s

Details

Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 3m41s

Details

397294dd7f

Returns a `MatrixDnsResolver` which correctly implements DNS caching
for correct SNI behavior.

s1lv3r scheduled this pull request to auto merge when all checks succeed

2026-07-09 23:43:35 +00:00

s1lv3r changed title from ~~feat: Create MatrixResolver::create_dns_resolver()~~ to WIP: feat: Create MatrixResolver::create_dns_resolver()

2026-07-09 23:43:57 +00:00

s1lv3r changed title from ~~WIP: feat: Create MatrixResolver::create_dns_resolver()~~ to feat: Create MatrixResolver::create_dns_resolver()

2026-07-09 23:55:16 +00:00

s1lv3r force-pushed zoe/add-create-dns-resolver from 397294dd7f

Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m12s

Details

Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 3m41s

Details

to bc4e487dde

Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 47s

Details

Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 1m36s

Details

Checks / Prek / Clippy and Cargo Tests (push) Has been cancelled

Details

Checks / Prek / Pre-commit & Formatting (push) Has been cancelled

Details

2026-07-09 23:55:23 +00:00

Compare

s1lv3r scheduled this pull request to auto merge when all checks succeed

2026-07-09 23:55:31 +00:00

Henry-Hiles approved these changes

2026-07-10 00:00:28 +00:00

Henry-Hiles left a comment

LGTM

Jade reviewed

2026-07-10 00:16:23 +00:00

src/server.rs

					
				@ -268,0 +269,4 @@

				    ///

				    /// See more details in `MatrixDnsResolver`'s doc comment

				    pub fn create_dns_resolver(self: &Arc<Self>) -> MatrixDnsResolver {

				        MatrixDnsResolver::new(self.resolver.clone(), self.cache.clone(), self.clone())

I set up the client builder stuff with the intention that our method of SNI wouldn't be exposed, so if reqwest fixed their missing feature it wouldn't require a breaking change

I agree, but unless you wanna rewrite i think literally most of resolvematrix around this one change, this might be the easiest solution.

I also attempted to create a MatrixDnsResolver manually, but its so tightly coupled to the dns resolver, the cache, and the matrixresolver that its basically impossible

I agree, but unless you wanna rewrite i think literally most of resolvematrix around this one change, this might be the easiest solution. I also attempted to create a MatrixDnsResolver manually, but its so tightly coupled to the dns resolver, the cache, _and_ the matrixresolver that its basically impossible