Summary: **Context/Summary:** It's very easy to make mistake in removing deprecated option such as deleting the corresponding entry in type info that breaks backward compatibility or missing tests to test backward compatibility. Example: https://github.com/facebook/rocksdb/pull/14350#discussion_r2834554287. Added a claude md file for that. Pull Request resolved: https://github.com/facebook/rocksdb/pull/14360 Test Plan: In claude code, prompted for deprecated option removal with this claude md file in a repo separated from my previous deprecation efforts as much as possible and received correct change at one try. Reviewed By: pdillinger Differential Revision: D93920127 Pulled By: hx235 fbshipit-source-id: 1977ce7404b0188f84258552b4843e70394a5aea
440 B
440 B
Removing Deprecated Options from RocksDB
Keep in these files:
- KEEP entry in type_info (
options/cf_options.ccoroptions/db_options.cc) withOptionVerificationType::kDeprecatedfor loading old option files - KEEP or add test in
options/options_test.ccOptionsOldApiTest::GetOptionsFromMapTestfor loading old option files
Documentation:
- Add release note to
HISTORY.mdandunreleased_history/