basic policy server support #27

Merged

nex merged 8 commits from nex/policy-servers-or-smthn into conduwuit-changes

2025-07-17 02:13:51 +00:00

nex commented

2025-07-16 04:26:39 +00:00

Owner

needs merging so that the continuwuity policy server branch can be not 3 decades behind main. Ideally a squash given the poor commit messages.

nex added 7 commits 2025-07-16 04:26:40 +00:00

Something something policy server e00a6ec065

Seems `cargo +nightly fmt` reformatted some other stuff too

fix policyserv event definition dcdaaf903d

implement request for policyserver 781606d1fa

support sending the PDU body 1faaf474b1

GET -> POST 605a2f6253

foprgpr tje org.matrix.msc4284 8ea4885e34

style: Re-run formatter e9e709aba5

nex added 1 commit 2025-07-16 04:30:57 +00:00

style: Replace cloned docstring 3adafffe9a

requested review from Jade

2025-07-16 04:32:03 +00:00

Jade force-pushed nex/policy-servers-or-smthn from 3adafffe9a to 0de510869e

2025-07-16 22:56:20 +00:00

Compare

Jade force-pushed nex/policy-servers-or-smthn from 0de510869e to afbc58fb6c

2025-07-16 23:28:18 +00:00

Compare

Jade approved these changes 2025-07-16 23:36:45 +00:00

Jade left a comment

Owner

I'm not seeing any issues from a quick skim.

AI slop says:

  1. Commit Message Quality: aa9ac1a1 foprgpr tje org.matrix.msc4284 appears to have typos
  2. API Stability: Uses unstable MSC endpoint - consider if this should be feature-gated
  3. Validation: No validation on recommendation field values ("ok"/"spam")
  4. Documentation: Limited rustdoc comments for public API

But that's all forgivable, I think, as long as we squash

I'm not seeing any issues from a quick skim. AI slop says: ``` 1. Commit Message Quality: aa9ac1a1 foprgpr tje org.matrix.msc4284 appears to have typos 2. API Stability: Uses unstable MSC endpoint - consider if this should be feature-gated 3. Validation: No validation on recommendation field values ("ok"/"spam") 4. Documentation: Limited rustdoc comments for public API ``` But that's all forgivable, I think, as long as we squash

nex commented

2025-07-17 02:07:10 +00:00

Author

Owner

"foprgpr tje org.matrix.msc4284 appears to have typos" thanks, captain obvious 🧌
I think we should drop feature-gates going forward anyway, there's not much use for them when we maintain the fork ourselves
ok/spam are the only specced values, however namespaced values are also permitted according to the MSC.
tell the AI slop to write its own damn docs 😹

I'll squash merge

1. "`foprgpr tje org.matrix.msc4284` appears to have typos" thanks, captain obvious 🧌 2. I think we should drop feature-gates going forward anyway, there's not much use for them when we maintain the fork ourselves 3. `ok`/`spam` are the only specced values, however namespaced values are also permitted according to the MSC. 4. tell the AI slop to write its own damn docs 😹 I'll squash merge

❤️ 1

nex merged commit b753738047 into conduwuit-changes

2025-07-17 02:13:51 +00:00

nex deleted branch nex/policy-servers-or-smthn

2025-07-17 02:13:51 +00:00

nex referenced this pull request from a commit

2025-07-17 02:13:53 +00:00

basic policy server support (#27)