continuwuation/ruwuma
6
0
Fork 8
Code Issues Pull requests 4 Projects Releases Packages Wiki Activity

MSC4143: Fix response .../org.matrix.msc4143/rtc/transports #53

Merged
Jade merged 2 commits from spaetz/ruwuma:shortbread_glenfiddich into conduwuit-changes 2026-04-16 18:40:43 +00:00
Conversation 3 Commits 2 Files changed 1 +3 -3
spaetz commented 2026-04-11 16:10:02 +00:00
Contributor
Copy link

OBS: This is a completely untested PR, as I don't know how to compile a local ruwuma and test it with a local c10y. However, from glancing at the code, it does look correct. (famous last words)

The /_matrix/client/unstable/org.matrix.msc4143/rtc/transports endpoint
returns a JSON array titled rtc_foci. MSC4143 specifies that this should
be rtc_transports

fixes: continuwuation/continuwuity#1602

OBS: This is a completely untested PR, as I don't know how to compile a local ruwuma and test it with a local c10y. However, from glancing at the code, it does look correct. (famous last words) The /_matrix/client/unstable/org.matrix.msc4143/rtc/transports endpoint returns a JSON array titled rtc_foci. MSC4143 specifies that this should be rtc_transports fixes: https://forgejo.ellis.link/continuwuation/continuwuity/issues/1602 <!-- PR checklist, not strictly necessary but generally useful unless you're just fixing a typo or something like that: - Run `cargo xtask ci` locally before posting the PR: **DONE** - Documented public API changes in CHANGELOG.md files: **NA** --> 
The /_matrix/client/unstable/org.matrix.msc4143/rtc/transports endpoint
returns a JSON array titled rtc_foci. MSC4143 specifies that this should
be rtc_transports

fixes: continuwuation/continuwuity#1602
Jade commented 2026-04-11 16:12:16 +00:00
Owner
Copy link

This may need a corresponding commit in Continuwuity merged at the same time afaict because of the struct fields being public

This may need a corresponding commit in Continuwuity merged at the same time afaict because of the struct fields being public
spaetz commented 2026-04-11 16:12:20 +00:00
Author
Contributor
Copy link

cargo xtask ci
fails with

Error: command exited with non-zero code `rustup run 1.81 cargo check --workspace --all-features --exclude ruma --exclude ruma-macros --exclude ruma-signatures --exclude xtask`: 1

BTW

cargo xtask ci fails with ``` Error: command exited with non-zero code `rustup run 1.81 cargo check --workspace --all-features --exclude ruma --exclude ruma-macros --exclude ruma-signatures --exclude xtask`: 1 ``` BTW
Jade approved these changes 2026-04-16 18:40:11 +00:00
Jade merged commit d00b51a866 into conduwuit-changes 2026-04-16 18:40:43 +00:00
spaetz deleted branch shortbread_glenfiddich 2026-04-16 18:45:54 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Jade
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/ruwuma!53
No description provided.