continuwuation/continuwuity
continuwuation/continuwuity
12
41
Fork 41
Code Issues 92 Pull requests 18 Releases 24 Packages 3 Activity Actions 1

Setting default_room_version to 12 breaks continuwuity. #1219

New issue
Closed
opened 2025-12-10 19:52:38 +00:00 by nyanbinary · 7 comments
nyanbinary commented 2025-12-10 19:52:38 +00:00
Contributor
Copy link

What the title says, it refuses to start up if set to version 12/fails to start.

What the title says, it refuses to start up if set to version 12/fails to start.
nex commented 2025-12-10 21:50:46 +00:00
Owner
Copy link

Can't reproduce this on main (6a8b988b36) with default_room_version = "12". Which version of continuwuity are you using?

Can't reproduce this on main (6a8b988b36ff85ae5ee8500c7cb1c65da550620b) with `default_room_version = "12"`. Which version of continuwuity are you using?
log.txt
146 KiB
nyanbinary commented 2025-12-10 21:56:52 +00:00
Author
Contributor
Copy link

Using main as well. Using the Nix module could it be something with that?

Using main as well. Using the Nix module could it be something with that?
Aranjedeath commented 2025-12-10 22:12:53 +00:00
Owner
Copy link

I am noting that one post uses quotes around the room version and the other did not (post in main matrix room). Is this the problem? Does nix module quote the version? not quote? require one or the other?

I am noting that one post uses quotes around the room version and the other did not (post in main matrix room). Is this the problem? Does nix module quote the version? not quote? require one or the other?
nex commented 2025-12-10 22:30:11 +00:00
Owner
Copy link

Quotes are required as the room version is not an integer but a string - if a layer is removing the quotes and inadvertently changing the type of the value provided to an integer, then the crash is expected.

I think the docstring for the room version parameter doesn't actually highlight that the quotes are required, which might be an oversight.

Quotes are required as the room version is not an integer but a string - if a layer is removing the quotes and inadvertently changing the type of the value provided to an integer, then the crash is expected. I think the docstring for the room version parameter doesn't actually highlight that the quotes are required, which might be an oversight.
Henry-Hiles commented 2025-12-10 22:32:07 +00:00
Copy link

I believe the nix module should copy the values verbatim, so quoting the version should also show up as quoted in the TOML.

I believe the nix module should copy the values verbatim, so quoting the version should also show up as quoted in the TOML.
Aviac commented 2025-12-11 08:08:56 +00:00
Member
Copy link

Fortunately we have a nixos test. I'll try to verify it there :)

Fortunately we have a nixos test. I'll try to verify it there :)
Aviac commented 2025-12-11 08:19:04 +00:00
Member
Copy link

Yeah so setting it to "12" let's the test pass and setting it to 12 makes it fail. I'll add it in a small PR along with the docs

Yeah so setting it to `"12"` let's the test pass and setting it to `12` makes it fail. I'll add it in a small PR along with the docs
Jade closed this issue 2025-12-16 16:23:00 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
renovate/rspress-plugin-client-redirects-2.x-lockfile
renovate/rust-patch-updates
renovate/rspress-plugin-preview-2.x-lockfile
renovate/rspress-core-2.x-lockfile
nex/stateres-refactor
ginger/deps/update-rspress
jade/admin-announce-improvements
aranje/illegal-car-mods
ginger/xtask-improvements
jade/improve-admin-config-display
nex/fix/better-stateres-error-logs
renovate/crate-ci-committed-1.x
jade/sender-timeouts
nex/feat/custom-v12-room-ids
ginger/update-metadata
renovate/rand-0.x
renovate/crate-ci-typos-1.x
nex/feat/admin-force-logout
renovate/lddtree-0.x
tom/max-perf-docs
renovate/github-actions-non-major
nex/fix/invalid-appservice-reg
nex/feat/antispam
nex/feat/account-locking
jade/logging-cleanup
jade/remove-legacy-appservice-auth
nex/fix/key-query
jade/update-prek
nex/fix/room-summaries
ginger/restrict-admin-commands
ginger/enable-console-by-default
jade/tag-fixes
jade/otlp
renovate/cargo-bins-cargo-binstall-1.x
nex/meta/pull-req-template
nex/fix/fed-invite-compliance
nex/feat/complement
nex/feat/build-commit
nex/feat/join-logging
jade/mailmap-updates
jade/hack-ci-tmp
jade/v12-stable
jade/relations
renovate/axum-monorepo
ginger/database-refactor
jade/fix-ldap-uiaa
nex/fix/validation
ginger/nuke-invalid-msc4133-fields-in-migration
ginger/downgrade-artifact-actions
oddlid/reload-fix
jade/fix-assert
ginger/sync-v3-cleanup
renovate/ruma-digest
ginger/remove-absolute-action-urls
renovate/https-code.forgejo.org-actions-checkout-6.x
renovate/actions-checkout-6.x
jade/website
renovate/https-code.forgejo.org-actions-checkout-digest
nex/fix/backoff
renovate/bytes-1.x-lockfile
ginger/fix-mdbook-for-0.5
ginger/no-docker-on-prs
nex/mods
backport/v0.5.0-rc.8-1
renovate/hyper-1.x-lockfile
nex/fed-improvements
dahsa_uwu/axum-0.8
jade/rust-1.90
jade/mirror-dockerhub
jade/clippy-fixes
jade/fix-support
jade/clean-images
jade/wal-compression-type
jade/flake-clone
ginger/upload-rpms-on-schedule
nex/fix/incoming-fetch
nex/fix/upgrade
tom/ci-fedora-rpm
jade/ci-release-fix
jade/rocksdb-10-5
ginger/fix-msc4133-migration
ginger/migrate-busted-tz
hydra/public
nex/feat/manual-extremities
nex/feat/async-media
nex/feat/fast-joins-hack-do-not-use-DO-NOT-USE
nex/feat/better-logging
trigger-ci-so-latest-isnt-on-illegal-car-mods
nex/feat/pins-backfill
jade/tuwunel-2025-06-old
jade/ai-slop-db-docs
nex/fix-create-auth
jade/version-stats
jade/read-receipts
jade/rust-toolchain-no-targets
jade/logging-features
jade/syncv5-typing
jade/msc2815
jade/purge-sync-tokens
morguldir/see-eye
jade/css-small-screen
nex/wip-751
tuwunel-rebase
test
oddlid/rename-admin-room-bot
strawberry/nix-ci-stuff
strawberry/valgrind
phonemain
strawberry/morgs-snake-sync-jason-main
newer-media-endpoints
folly-coroutines-async-io
federation-retry-timer-port
bad-attempt-at-extracting-homeserver-signing-key
room-deletion-attempt-do-not-use
v0.5.3
v0.5.2
v0.5.1
v0.5.0
v0.5.0-rc.8.1
v0.5.0-rc.8
v0.5.0-rc.7
v0.5.0-rc.6
v0.5.0-rc.5
v0.5.0-rc4
v0.5.0-rc3
v0.5.0-rc2
v0.5.0-rc
v0.4.7-rc
v0.4.6
v0.4.6-rc
v0.4.5-rc
v0.4.5
v0.4.4
v0.4.3
v0.4.2
v0.4.1
v0.3.4
v0.3.3
v0.3.2
v0.3.1
v0.3.0
Labels
Clear labels   
Blocked

This pull request or issue is currently blocked from being merged/closed

  
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Dependencies/Renovate

Automatic dependency upgrades by Renovate

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

Issues relating to core matrix functionality, such as state resolution and PDU formats

  
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/Hydra

Issues related to room version 12 and related changes (temporary label)

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/CI

Issues related to CI changes

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status
Confirmed
This issue has enough information and is confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
Support

Questions or support requests

  
To-Merge

   
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Blocked
Bug
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Support
To-Merge
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity#1219
No description provided.