continuwuation/continuwuity
continuwuation/continuwuity
12
41
Fork 41
Code Issues 92 Pull requests 18 Releases 24 Packages 3 Activity Actions 2

Clarification and Tests for default_room_version #1221

Merged
ginger merged 3 commits from Aviac/continuwuity:default-room-version-clarifications into main 2025-12-16 14:19:43 +00:00
Conversation 3 Commits 3 Files changed 3 +129 -97
Aviac commented 2025-12-11 08:38:47 +00:00
Member
Copy link

"Fixes" #1219

"Fixes" https://forgejo.ellis.link/continuwuation/continuwuity/issues/1219
test: add test for config with default_room_version
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 58s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m29s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 12m36s
Details
2cf0923386
 
This commit refactors the test a bit to run the basic test script with
different configs. Currently we have two configs we test:

- the bare minimum to make it run (base)
- base + default_room_version set to "12"
nex approved these changes 2025-12-13 16:06:48 +00:00
Dismissed
nex left a comment
Owner
Copy link

Looks good to me, thanks!

Looks good to me, thanks!
nex requested changes 2025-12-13 16:07:29 +00:00
nex left a comment
Owner
Copy link

Wait no it's not, you need to edit src/core/config/mod.rs or something like that to change the description of config variables, conduwuit-example.toml is auto-generated on cargo build so this will get overridden

Wait no it's not, you need to edit `src/core/config/mod.rs` or something like that to change the description of config variables, `conduwuit-example.toml` is auto-generated on `cargo build` so this will get overridden
fix: Update comment in src/core/config/mod.rs
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Update flake hashes / update-flake-hashes (pull_request) Successful in 55s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m43s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m43s
Details
dee936813c
ginger requested review from nex 2025-12-15 14:57:21 +00:00
ginger approved these changes 2025-12-16 14:19:25 +00:00
ginger scheduled this pull request to auto merge when all checks succeed 2025-12-16 14:19:33 +00:00
ginger canceled auto merging this pull request when all checks succeed 2025-12-16 14:19:37 +00:00
ginger merged commit 64e187e5b4 into main 2025-12-16 14:19:43 +00:00
ginger added this to the 0.5.0 milestone 2025-12-16 14:19:52 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
nex
ginger
Labels
Clear labels   
Blocked

This pull request or issue is currently blocked from being merged/closed

  
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Dependencies/Renovate

Automatic dependency upgrades by Renovate

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

Issues relating to core matrix functionality, such as state resolution and PDU formats

  
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/Hydra

Issues related to room version 12 and related changes (temporary label)

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/CI

Issues related to CI changes

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status
Confirmed
This issue has enough information and is confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
Support

Questions or support requests

  
To-Merge

   
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Blocked
Bug
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Support
To-Merge
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
0.5.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity!1221
No description provided.