fix(sync): Wake local target user after membership changes are committed #2039

Merged

nex merged 1 commit from eleboucher/continuwuity:fix/wake-local-member-sync into main

2026-07-26 14:12:38 +00:00

eleboucher commented

2026-07-24 15:03:30 +00:00

Contributor

Previously, an invitee's sync was never woken by wake_all_joined (they aren't joined yet), and update_membership's wake fires from within append_pdu, before set_room_state commits. As a result, receiving or accepting a local invite wasn't reflected in the affected user's sync until a later poll, which could leave a room appearing stuck between the invited and joined states. The fix adds a post-commit sync.wake for the local target user of any m.room.member event, in both the local (build_and_append_pdu) and federation (append_incoming_pdu) paths.

Pull request checklist:

This pull request targets the main branch, and the branch is named something other than
main.
I have written an appropriate pull request title and my description is clear.
I understand I am responsible for the contents of this pull request.
I have followed the contributing guidelines:
- My contribution follows the code style, if applicable.
- I ran pre-commit checks before opening/drafting this pull request.
- I have tested my contribution (or proof-read it for documentation-only changes)
  myself, if applicable. This includes ensuring code compiles.
- My commit messages follow the commit message format and are descriptive.

Previously, an invitee's sync was never woken by wake_all_joined (they aren't joined yet), and update_membership's wake fires from within append_pdu, before set_room_state commits. As a result, receiving or accepting a local invite wasn't reflected in the affected user's sync until a later poll, which could leave a room appearing stuck between the invited and joined states. The fix adds a post-commit sync.wake for the local target user of any m.room.member event, in both the local (build_and_append_pdu) and federation (append_incoming_pdu) paths.     **Pull request checklist:**  - [x] This pull request targets the `main` branch, and the branch is named something other than `main`. - [x] I have written an appropriate pull request title and my description is clear. - [x] I understand I am responsible for the contents of this pull request. - I have followed the [contributing guidelines][c1]: - [x] My contribution follows the [code style][c2], if applicable. - [x] I ran [pre-commit checks][c1pc] before opening/drafting this pull request. - [x] I have [tested my contribution][c1t] (or proof-read it for documentation-only changes) myself, if applicable. This includes ensuring code compiles. - [x] My commit messages follow the [commit message format][c1cm] and are descriptive.  [c1]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md [c2]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/docs/development/code_style.mdx [c1pc]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#pre-commit-checks [c1t]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#running-tests-locally [c1cm]: https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/CONTRIBUTING.md#commit-messages

Rows
Columns