Accepting a local invite seems to cause user to be in half-joined state for some clients #2038
Labels
No labels
Abandoned
Blocked
Bug
Changelog
Added
Changelog
Missing
Changelog
None
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/E2EE
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Matrix/T&S
Merge
Merge/Manual
Merge/Squash
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Support
bob the builder
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
continuwuation/continuwuity#2038
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Continuwuity logs a warning when I try to join a space on my own homeserver via an invite sent by an Out Of Your Element bridge set up on that same homeserver:
The join fails on Element X and Element Web, and on Sable (both nightly and 1.20.0) it half succeeds: It looks like I've joined the space, and the space shows "3 members" as opposed to the previous 2, but it only actually lists 2 members; I'm not among them. However, I can join the rooms that are part of the space. When checking on Element X and Element Web, the space that I've half-joined on Sable doesn't show up, but the rooms that I've subsequently joined on Sable do. Furthermore, closing Sable and reopening it leads to me not being part of the space on Sable anymore, and the invite that I've already half-accepted through Sable once again appears in my inbox. I can "half-accept" it again, but I continue having the same issues.
Seemingly relatedly, when creating DMs with other users on my homeserver, they are not actually invited to said DMs room; I always have to manually invite them to the room. This does not happen with users on other, federated homeservers; with those everything regarding DMs creation works as expected.
I suspect that this issue might be related to #1895.
My homeserver is running current continuwuity:main via Podman Quadlet, and I have Sliding Sync enabled on Sable (nightly and 1.20.0).
I can no longer reproduce the issues described in this issue with other clients after leaving the spaces that I've "half-joined" with Sable previously, so I'm inclined to believe that this is an issue specific to Sable being used on a Continuwuity homeserver. I've therefore created an issue on Sable's repository. I wonder though, could this be a regression of Continuwuity related to Sliding Sync?
I believe #2039 and the same author's PR for Sable would fix this. I'll report back once those are both merged.
The PR for Sable did indeed fix this issue from affecting the client's usability too much, but there still needs to be a server-side fix. #2039 seems to provide that.
That log seems unrelated to the issue you're facing if the operation is still happening at all. The log indicates the client forgot to attach an
Authorizationheader, which would reject the entire request, not allow it to "partially succeed" etc.Does #2039 certainly fix the issue?
I am no longer getting the log during testing with the Sable PR merged, but I still get the "half-joined" state described in #2039. I don't really have a way to test #2039 though, I'd love to test it if I can. (I'm using Podman Quadlets.)
Local invite fails with "Failed to extract authorization"to Accepting a local invite seems to cause user to be in half-joined state for some clients