[global.well_known] client should be considered MUST-populate post OAuth adoption #2116
Labels
No labels
Abandoned
Blocked
Bug
Changelog
Added
Changelog
Missing
Changelog
None
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/E2EE
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Matrix/T&S
Merge
Merge/Manual
Merge/Squash
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Support
bob the builder
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
continuwuation/continuwuity#2116
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What it says on the tin. Regardless of homeserver delegation to another domain or use of a separate port, or whether you have a separate web server serving your .well-known/matrix/ basics, this now MUST be populated in at least the server settings—whether in the TOML file or via the
CONTINUWUITY_WELL_KNOWN__CLIENTenv var—or else it's impossible to sign in with new clients. Even I fell victim to this classic blunder when setting up my first new client post-26.6.0, and we've had at least one or two newcomer adopters miss this as well.This is at least a matter of some light edits to
src/core/config/mod.rscomments andconduwuit-example.toml; that said, it might be "best" in the long run if c10y failed to start if this setting is unconfigured (to force deployers to put a value in there).The well known requirement is already documented here.
Could we have a graceful fallback where, without client
.well-known, Continuwuity will usehttps://server_name:443for OAuth? This would be consistent with generic/dockerized deployment pagesIf I remember my post-upgrade issue with this correctly, the fallback you describe is already present, but that simply does not work in delegated situations.
@stratself wrote in #2116 (comment):
I'd be for a fallback, but it would have to be
:$CONTINUWUITY_PORT, not static:443I disagree with
:$CONTINUWUITY_PORTas none of our docs (and nobody in general) expose c10y without a reverse proxy. This would essentially make[matrix.well_known].clienta soft requirement.:443is already the default for Client-Server API as well