Replace serde_yaml for registering Appservice YAML files #231

New issue

Closed

opened 2024-03-25 02:18:08 +00:00 by girlbossceo · 2 comments

girlbossceo commented

2024-03-25 02:18:08 +00:00

(Migrated from github.com)

It is now deprecated https://github.com/dtolnay/serde-yaml/releases/tag/0.9.34

No priority because this is only used to register appservices and the entire functionality is just to parse from/to strings.

It is now deprecated https://github.com/dtolnay/serde-yaml/releases/tag/0.9.34 No priority because this is only used to register appservices and the entire functionality is just to parse from/to strings. <img width="418" alt="image" src="https://github.com/girlbossceo/conduwuit/assets/112147643/63aebb1a-fdd1-4a27-80de-34893a4934d1">

girlbossceo commented

2024-03-26 10:22:31 +00:00

(Migrated from github.com)

May actually want to prioritise this sooner or later as someone will eventually file a rustsec advisory on serde_yaml and CI's cargo audit will start failing.

Also, yaml-rust is unmaintained and has a rustsec advisory so can't use that one: https://github.com/chyh1990/yaml-rust/issues/200

May actually want to prioritise this sooner or later as someone will eventually file a rustsec advisory on serde_yaml and CI's cargo audit will start failing. Also, yaml-rust is unmaintained and has a rustsec advisory so can't use that one: https://github.com/chyh1990/yaml-rust/issues/200

girlbossceo commented

2024-11-04 00:56:20 +00:00

(Migrated from github.com)

This probably isn't important to fix/do. serde_yaml is used for literally 1-2 tiny things. If someone wants to replace serde_yaml anyways a minimal PR can be accepted.