continuwuation/continuwuity

Fork 34

chore: replace serde-yml with serde-saphyr #1151

Merged

Jade merged 1 commit from Aviac/continuwuity:replace-serde-yml into main

2025-11-09 10:56:34 +00:00

Aviac commented

2025-11-09 10:30:52 +00:00

Member

Fixes #231, I guess (?)

serde-yml has an un-addressed security issue
saphyr is a pretty recent and active crate that deals with YAML parsing
based on that, someone recently created serde-saphyr

The change was pretty straightforward and mostly "just a search and replace". The new crate has it's Error type split
into serialization and derserialization errors. Hence I created one Continuwuity-Error variant for each instead of just
having a single Yaml variant. This was already done previously with the Toml errors so I thought this would be
rather acceptable.

Fixes #231, I guess (?) --- - serde-yml has an un-addressed [security issue][sec-issue] - [saphyr][saphyr] is a pretty recent and active crate that deals with YAML parsing - based on that, someone recently created [serde-saphyr][serde-saphyr] --- The change was pretty straightforward and mostly "just a search and replace". The new crate has it's `Error` type split into serialization and derserialization errors. Hence I created one Continuwuity-Error variant for each instead of just having a single `Yaml` variant. This was already done previously with the `Toml` errors so I thought this would be rather acceptable. [sec-issue]: https://github.com/advisories/GHSA-gfxp-f68g-8x78 [saphyr]: https://github.com/saphyr-rs/saphyr [serde-saphyr]: https://github.com/saphyr-rs/saphyr/issues/66#issuecomment-3353212289

Aviac added 1 commit

2025-11-09 10:30:52 +00:00

chore: replace serde-yml with serde-saphyr

Documentation / Build and Deploy Documentation (pull_request) Has been skipped

Details

Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m41s

Details

Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 2m30s

Details

Update flake hashes / update-flake-hashes (pull_request) Successful in 11s

Details

Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 6m31s

Details

Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 5s

Details

Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 15m54s

Details

Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 13m58s

Details

Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 13m58s

Details

Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 4s

Details

Documentation / Build and Deploy Documentation (push) Successful in 43s

Details

Checks / Prek / Pre-commit & Formatting (push) Successful in 2m15s

Details

Release Docker Image / Build linux-amd64 (release) (push) Successful in 4m38s

Details

Release Docker Image / Build linux-arm64 (release) (push) Successful in 5m58s

Details

Release Docker Image / Create Multi-arch Release Manifest (push) Successful in 16s

Details

Checks / Prek / Clippy and Cargo Tests (push) Successful in 16m4s

Details

Release Docker Image / Build linux-amd64 (max-perf) (push) Successful in 12m42s

Details

Release Docker Image / Build linux-arm64 (max-perf) (push) Successful in 12m49s

Details

Release Docker Image / Create Max-Perf Manifest (push) Successful in 13s

Details

866769c054

- serde-yml has an un-addressed [security issue][sec-issue]
- [saphyr][saphyr] is a pretty recent and active crate that deals with YAML parsing
- based on that, someone recently created [serde-saphyr][serde-saphyr]

---

The change was pretty straightforward and mostly "just a search and replace". The new crate has it's `Error` type split
into serialization and derserialization errors. Hence I created one Continuwuity-Error variant for each instead of just
having a single `Yaml` variant. This was already done previously with the `Toml` errors so I thought this would be
rather acceptable.

[sec-issue]: https://github.com/advisories/GHSA-gfxp-f68g-8x78
[saphyr]: https://github.com/saphyr-rs/saphyr
[serde-saphyr]: https://github.com/saphyr-rs/saphyr/issues/66#issuecomment-3353212289

Jade approved these changes

2025-11-09 10:56:06 +00:00

Jade commented

2025-11-09 10:56:27 +00:00

Owner

Thank you!

❤️ 1

Jade merged commit 866769c054 into main

2025-11-09 10:56:34 +00:00

nex added the

Dependencies

Rows
Columns