'limited' flag is set on sync v3 room joins #839

New issue

Open

opened 2025-05-25 00:53:34 +00:00 by Jade · 2 comments

Jade commented

2025-05-25 00:53:34 +00:00

Owner

https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/src/api/client/sync/v3.rs#L873-L878

Here, joined_since_last_sync is true if the user is joining the room for the "first time" in terms of this sync (e.g., initial sync, or joined since the last sync since token). The specification describes the limited flag as indicating that the server has omitted some events from the current batch due to a large number of events occurring since the last sync, creating a "gap" that the client can backfill.

Setting limited to true just because joined_since_last_sync is true might be a misinterpretation - given clients already have a pagination token here.

Investigate client behaviour?

Related to #779 ?

https://forgejo.ellis.link/continuwuation/continuwuity/src/branch/main/src/api/client/sync/v3.rs#L873-L878 Here, joined_since_last_sync is true if the user is joining the room for the "first time" in terms of this sync (e.g., initial sync, or joined since the last sync since token). The specification describes the limited flag as indicating that the server has omitted some events from the current batch due to a large number of events occurring since the last sync, creating a "gap" that the client can backfill. Setting limited to true just because joined_since_last_sync is true might be a misinterpretation - given clients already have a pagination token here. Investigate client behaviour? Related to https://forgejo.ellis.link/continuwuation/continuwuity/issues/779 ?

Jade added the

Bug

Matrix/Client

labels 2025-05-25 00:53:34 +00:00

nex commented

2025-05-25 23:41:52 +00:00

Owner

Even if this is related to 799, not sure fixing this would fix that too - 799's issue is the room state never makes it down sync. Definitely worth looking into though

nex commented

2025-05-30 23:57:11 +00:00

Owner

okay what im gathering is our sync watcher is just a bit borky over all

nex added the

Status

Needs Investigation

label 2025-05-31 00:00:48 +00:00

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: continuwuation/continuwuity#839

No description provided.

Rows
Columns