continuwuation/continuwuity
10
27
Fork 25
Code Issues 89 Pull requests 28 Projects Releases 18 Packages 3 Activity Actions

bug: membership changes do not come down sync appropriately #779

New issue
Open
opened 2025-04-20 18:34:27 +00:00 by nex · 4 comments
nex commented 2025-04-20 18:34:27 +00:00
Owner
Copy link

Sometimes, joining a room does not come down /sync immediately, and requires another event to be sent in the room before it makes its way down to clients. When this happens, the room state is additionally not sent down, only relevant memberships.

An initial sync does not have this issue.

Update: This also affects leaving rooms, resulting in rooms becoming stuck in clients, and a [403 / M_FORBIDDEN] M_FORBIDDEN: Event is not authorized error on trying to leave again.

Sometimes, joining a room does not come down /sync immediately, and requires another event to be sent in the room before it makes its way down to clients. When this happens, the room state is additionally not sent down, only relevant memberships. An initial sync does not have this issue. Update: This also affects leaving rooms, resulting in rooms becoming stuck in clients, and a `[403 / M_FORBIDDEN] M_FORBIDDEN: Event is not authorized` error on trying to leave again.
👍 4
nex added this to the 0.5.0 milestone 2025-04-30 15:28:10 +00:00
nex commented 2025-05-12 23:52:57 +00:00
Author
Owner
Copy link

Only appears to happen on sync v3 (client/v3/sync), SS & SSS are seemingly unaffected

Only appears to happen on sync v3 (client/v3/sync), SS & SSS are seemingly unaffected
nex commented 2025-07-09 17:24:20 +00:00
Author
Owner
Copy link

Recategorising this issue as high priority instead of blocking, as the issue has both been improved by #840, and also hugely under-reported, so it doesn't seem to be affecting that many users.

Given the fix currently is "clear client cache", it seems silly to block the 0.5.0 release on this bug that not many people seem to experience [anymore].

Given the impact this bug has when it is run into though, it remains a high priority.

Warning

If you are experiencing this bug, please give this issue a 👍

Recategorising this issue as high priority instead of blocking, as the issue has both been improved by #840, and also hugely under-reported, so it doesn't seem to be affecting that many users. Given the fix currently is "clear client cache", it seems silly to block the 0.5.0 release on this bug that not many people seem to experience [anymore]. Given the impact this bug has when it is run into though, it remains a high priority. > [!warning] > **If you are experiencing this bug, please give this issue a 👍**
👍 3
nex commented 2025-07-15 01:55:58 +00:00
Author
Owner
Copy link

In addition to clearing the client cache, restarting the server also fixes this issue.

In addition to clearing the client cache, restarting the server also fixes this issue.
nex changed title from bug: joins do not come down sync appropriately to bug: membership changes do not come down sync appropriately 2025-08-27 13:28:12 +00:00
nex commented 2025-08-27 14:13:24 +00:00
Author
Owner
Copy link

Seems to be being reported far more frequently now, I think it's worth bumping this to blocking again so that we dont miss this when we finally go for 0.5.0

Seems to be being reported far more frequently now, I think it's worth bumping this to *blocking* again so that we dont miss this when we finally go for 0.5.0
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
tom/ci-fedora-rpm
nex/feat/provide-fast-joins
hydra/public
nex/feat/force-leave-room
renovate/actions-checkout-5.x
nex/feat/manual-extremities
illegal-car-mods
jade/dep-updates
jade/renovate-config-changes
renovate/termimad-0.x
renovate/cargo_toml-0.x
nex/fix/sync/leave-omission
renovate/toml-0.x
renovate/rand-0.x
renovate/nix-0.x
renovate/minicbor-serde-0.x
renovate/ctor-0.x
renovate/axum-client-ip-0.x
renovate/axum-monorepo
jade/rocksdb-10-5
nex/fed-improvements
tom/fixes
nex/feat/async-media
nex/feat/4277-harmonized-reporting-endpoints
nex/feat/fast-joins-hack-do-not-use-DO-NOT-USE
jade/musl-images
nex/feat/better-logging
trigger-ci-so-latest-isnt-on-illegal-car-mods
jade/parking_lot
jade/docs-updates-20250701
nex/fix/msc4307
nex/feat/pins-backfill
jade/upload-ci-binaries
jade/admin-command-docs
jade/tuwunel-2025-06
jade/tuwunel-2025-06-old
jade/ai-slop-db-docs
nex/fix-create-auth
jade/version-stats
jade/read-receipts
dahsa_uwu/axum-0.8
jade/rust-toolchain-no-targets
jade/logging-features
jade/syncv5-typing
jade/msc2815
jade/relations
jade/purge-sync-tokens
morguldir/see-eye
jade/css-small-screen
nex/wip-751
tuwunel-rebase
test
oddlid/rename-admin-room-bot
strawberry/nix-ci-stuff
strawberry/valgrind
strawberry/morgs-snake-sync-jason-main
newer-media-endpoints
folly-coroutines-async-io
federation-retry-timer-port
bad-attempt-at-extracting-homeserver-signing-key
room-deletion-attempt-do-not-use
v0.5.0-rc.7
v0.5.0-rc.6
v0.5.0-rc.5
v0.5.0-rc4
v0.5.0-rc3
v0.5.0-rc2
v0.5.0-rc
v0.4.7-rc
v0.4.6
v0.4.6-rc
v0.4.5-rc
v0.4.5
v0.4.4
v0.4.3
v0.4.2
v0.4.1
v0.3.4
v0.3.3
v0.3.2
v0.3.1
v0.3.0
Labels
Clear labels   
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Dependencies/Renovate

Automatic dependency upgrades by Renovate

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

   
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status
Confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
To-Merge

   
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Bug
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/Federation
Matrix/MSC
Matrix/Media
Meta
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
To-Merge
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
0.5.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: continuwuation/continuwuity#779
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?