continuwuation/continuwuity
continuwuation/continuwuity
14
76
Fork 81
Code Issues 106 Pull requests 38 Releases 27 Packages 3 Activity Actions

WIP: feat: implement transactional wrappers around room joins and other key code blocks writing to the database #1455

Draft
gamesguru wants to merge 1 commit from gamesguru/continuwuity:guru/experiment/rocksdb-transactional-wrappers into main
pull from: gamesguru/continuwuity:guru/experiment/rocksdb-transactional-wrappers
merge into: continuwuation:main
Conversation 4 Commits 1 Files changed 8 +202 -45
gamesguru commented 2026-02-25 11:32:41 +00:00
Contributor
Copy link

Largely subsumed by and tested in the stateless sync and guru/nightly branches.

This pull request hopefully prevents the race condition of !1142.

Pull request checklist

  • This pull request targets the main branch, and the branch is named something other than
    main.
  • I have written an appropriate pull request title and my description is clear.
  • I understand I am responsible for the contents of this pull request.
  • I have followed the [contributing guidelines][c1]:
    • My contribution follows the [code style][c2], if applicable.
    • I ran [pre-commit checks][c1pc] before opening/drafting this pull request.
    • I have [tested my contribution][c1t] (or proof-read it for documentation-only changes)
      myself, if applicable. This includes ensuring code compiles.
    • My commit messages follow the [commit message format][c1cm] and are descriptive.
    • I have written a [news fragment][n1] for this PR, if applicable.

Misc commit msgs

  • edits in join.rs to support better transactions
  • add a test to ensure the database nested transaction panic works as expected
Largely subsumed by and tested in the stateless sync and guru/nightly branches. This pull request hopefully prevents the race condition of !1142. ## Pull request checklist - [x] This pull request targets the `main` branch, and the branch is named something other than `main`. - [x] I have written an appropriate pull request title and my description is clear. - [x] I understand I am responsible for the contents of this pull request. - I have followed the [contributing guidelines][c1]: - [x] My contribution follows the [code style][c2], if applicable. - [x] I ran [pre-commit checks][c1pc] before opening/drafting this pull request. - [ ] I have [tested my contribution][c1t] (or proof-read it for documentation-only changes) myself, if applicable. This includes ensuring code compiles. - [x] My commit messages follow the [commit message format][c1cm] and are descriptive. - [ ] I have written a [news fragment][n1] for this PR, if applicable<!--(can be done after hitting open!)-->. ## Misc commit msgs - edits in join.rs to support better transactions - add a test to ensure the database nested transaction panic works as expected
❤️ 2
feat: implement transactional wrappers around room joins and other key code blocks writing to the database
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 15m40s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 24m23s
Details
7b846ccffe
 
edits in join.rs to support better transactions

lint fixes

add a test to ensure the database nested transaction panic works as expected

add news fragment
nex added this to the next milestone 2026-02-25 12:42:26 +00:00
nex requested reviews from Jade, nex, ginger 2026-02-25 12:42:33 +00:00
melogale commented 2026-02-26 01:34:57 +00:00
First-time contributor
Copy link

Unfortunately, this doesn't fix !779. I still need to clear cache in Cinny to make a room join go through.

Unfortunately, this doesn't fix !779. I still need to clear cache in Cinny to make a room join go through.
gamesguru commented 2026-02-26 02:04:23 +00:00
Author
Contributor
Copy link

@melogale okay thanks for checking. Wishful thinking on my part. Sounds like @Jade may have something they worked on independently. Are you able to provide steps to reproduce? Or provide any relevant errors or logs? Did you observe any problems on this branch? I may test it out, it seems safe.

The main focus of this PR then shifts to preventing the race condition and server log spam admins would see from joining busted rooms, see the other issue, !1142

@melogale okay thanks for checking. Wishful thinking on my part. Sounds like @Jade may have something they worked on independently. Are you able to provide steps to reproduce? Or provide any relevant errors or logs? Did you observe any problems on this branch? I may test it out, it seems safe. The main focus of this PR then shifts to preventing the race condition and server log spam admins would see from joining busted rooms, see the other issue, !1142
melogale commented 2026-02-26 03:57:29 +00:00
First-time contributor
Copy link

I've this branch deployed for nuirons.org and so far there are no breakages at least. So if it works for !1142, it's still awesome. Forgive the log dump: I still know nothing about matrix. This is on the end of the dm-inviter immediately after sending the dm-request.

[Perf]: Mark Request as sent 6 took 0ms index-B47ftdGJ.js:11:164450
[Perf]: BackupRoomKeys: Get keys to backup from rust crypto-sdk took 1ms index-B47ftdGJ.js:11:164450
Backup: Ending loop for version 8082. index-B47ftdGJ.js:11:164450
FetchHttpApi: <-- GET https://matrix.nuirons.org/_matrix/client/v3/sync?filter=xxx&timeout=xxx&org.matrix.msc4222.use_state_after=xxx&since=xxx [16800ms 200] index-B47ftdGJ.js:11:164450
FetchHttpApi: --> GET https://matrix.nuirons.org/_matrix/client/v3/sync?filter=xxx&timeout=xxx&org.matrix.msc4222.use_state_after=xxx&since=xxx index-B47ftdGJ.js:11:164450
FetchHttpApi: <-- GET https://matrix.nuirons.org/_matrix/client/v3/sync?filter=xxx&timeout=xxx&org.matrix.msc4222.use_state_after=xxx&since=xxx [7777ms 200] index-B47ftdGJ.js:11:164450
FetchHttpApi: --> GET https://matrix.nuirons.org/_matrix/client/v3/sync?filter=xxx&timeout=xxx&org.matrix.msc4222.use_state_after=xxx&since=xxx index-B47ftdGJ.js:11:164450
FetchHttpApi: <-- GET https://matrix.nuirons.org/_matrix/client/v3/sync?filter=xxx&timeout=xxx&org.matrix.msc4222.use_state_after=xxx&since=xxx [59ms 200] index-B47ftdGJ.js:11:164450

[MatrixRTCSessionManager] Got room state event for unknown room !jMP1RcSSLddEtaWB6N:nuirons.org! 5 index-B47ftdGJ.js:11:164450

Autoplay is only allowed when approved by the user, the site is activated by the user, or media is muted. index-B47ftdGJ.js:117:25699
Uncaught (in promise) DOMException: The play method is not allowed by the user agent or the platform in the current context, possibly because the user denied permission.
FetchHttpApi: --> GET https://matrix.nuirons.org/_matrix/client/v3/sync?filter=xxx&timeout=xxx&org.matrix.msc4222.use_state_after=xxx&since=xxx index-B47ftdGJ.js:11:164450
FetchHttpApi: --> GET https://matrix.nuirons.org/_matrix/client/v3/devices index-B47ftdGJ.js:11:164450
FetchHttpApi: <-- GET https://matrix.nuirons.org/_matrix/client/v3/devices [25ms 200] index-B47ftdGJ.js:11:164450
joinRoom[!jMP1RcSSLddEtaWB6N:nuirons.org]: preJoinMembership=invite, inviter=@ariagale:nuirons.org, opts={} index-B47ftdGJ.js:11:164450
FetchHttpApi: --> POST https://matrix.nuirons.org/_matrix/client/v3/join/!jMP1RcSSLddEtaWB6N%3Anuirons.org index-B47ftdGJ.js:11:164450
FetchHttpApi: <-- POST https://matrix.nuirons.org/_matrix/client/v3/join/!jMP1RcSSLddEtaWB6N%3Anuirons.org [16ms 200] index-B47ftdGJ.js:11:164450
FetchHttpApi: --> PUT https://matrix.nuirons.org/_matrix/client/v3/user/%40melogale%3Anuirons.org/account_data/m.direct index-B47ftdGJ.js:11:164450
FetchHttpApi: <-- GET https://matrix.nuirons.org/_matrix/client/v3/sync?filter=xxx&timeout=xxx&org.matrix.msc4222.use_state_after=xxx&since=xxx [5073ms 200] index-B47ftdGJ.js:11:164450
FetchHttpApi: --> GET https://matrix.nuirons.org/_matrix/client/v3/sync?filter=xxx&timeout=xxx&org.matrix.msc4222.use_state_after=xxx&since=xxx index-B47ftdGJ.js:11:164450
FetchHttpApi: <-- PUT https://matrix.nuirons.org/_matrix/client/v3/user/%40melogale%3Anuirons.org/account_data/m.direct [16ms 200] index-B47ftdGJ.js:11:164450
FetchHttpApi: <-- GET https://matrix.nuirons.org/_matrix/client/v3/sync?filter=xxx&timeout=xxx&org.matrix.msc4222.use_state_after=xxx&since=xxx [22ms 200] index-B47ftdGJ.js:11:164450
FetchHttpApi: --> GET https://matrix.nuirons.org/_matrix/client/unstable/im.nheko.summary/summary/!jMP1RcSSLddEtaWB6N%3Anuirons.org index-B47ftdGJ.js:11:164450
FetchHttpApi: --> GET https://matrix.nuirons.org/_matrix/client/v3/sync?filter=xxx&timeout=xxx&org.matrix.msc4222.use_state_after=xxx&since=xxx index-B47ftdGJ.js:11:164450
FetchHttpApi: <-- GET https://matrix.nuirons.org/_matrix/client/unstable/im.nheko.summary/summary/!jMP1RcSSLddEtaWB6N%3Anuirons.org [43ms 200] index-B47ftdGJ.js:11:164450
joinRoom[!jMP1RcSSLddEtaWB6N:nuirons.org]: preJoinMembership=invite, inviter=@ariagale:nuirons.org, opts={}

I've this branch deployed for nuirons.org and so far there are no breakages at least. So if it works for !1142, it's still awesome. Forgive the log dump: I still know nothing about matrix. This is on the end of the dm-inviter immediately after sending the dm-request. [Perf]: Mark Request as sent 6 took 0ms index-B47ftdGJ.js:11:164450 [Perf]: BackupRoomKeys: Get keys to backup from rust crypto-sdk took 1ms index-B47ftdGJ.js:11:164450 Backup: Ending loop for version 8082. index-B47ftdGJ.js:11:164450 FetchHttpApi: <-- GET https://matrix.nuirons.org/_matrix/client/v3/sync?filter=xxx&timeout=xxx&org.matrix.msc4222.use_state_after=xxx&since=xxx [16800ms 200] index-B47ftdGJ.js:11:164450 FetchHttpApi: --> GET https://matrix.nuirons.org/_matrix/client/v3/sync?filter=xxx&timeout=xxx&org.matrix.msc4222.use_state_after=xxx&since=xxx index-B47ftdGJ.js:11:164450 FetchHttpApi: <-- GET https://matrix.nuirons.org/_matrix/client/v3/sync?filter=xxx&timeout=xxx&org.matrix.msc4222.use_state_after=xxx&since=xxx [7777ms 200] index-B47ftdGJ.js:11:164450 FetchHttpApi: --> GET https://matrix.nuirons.org/_matrix/client/v3/sync?filter=xxx&timeout=xxx&org.matrix.msc4222.use_state_after=xxx&since=xxx index-B47ftdGJ.js:11:164450 FetchHttpApi: <-- GET https://matrix.nuirons.org/_matrix/client/v3/sync?filter=xxx&timeout=xxx&org.matrix.msc4222.use_state_after=xxx&since=xxx [59ms 200] index-B47ftdGJ.js:11:164450 **[MatrixRTCSessionManager] Got room state event for unknown room !jMP1RcSSLddEtaWB6N:nuirons.org! 5 index-B47ftdGJ.js:11:164450** Autoplay is only allowed when approved by the user, the site is activated by the user, or media is muted. index-B47ftdGJ.js:117:25699 Uncaught (in promise) DOMException: The play method is not allowed by the user agent or the platform in the current context, possibly because the user denied permission. FetchHttpApi: --> GET https://matrix.nuirons.org/_matrix/client/v3/sync?filter=xxx&timeout=xxx&org.matrix.msc4222.use_state_after=xxx&since=xxx index-B47ftdGJ.js:11:164450 FetchHttpApi: --> GET https://matrix.nuirons.org/_matrix/client/v3/devices index-B47ftdGJ.js:11:164450 FetchHttpApi: <-- GET https://matrix.nuirons.org/_matrix/client/v3/devices [25ms 200] index-B47ftdGJ.js:11:164450 joinRoom[!jMP1RcSSLddEtaWB6N:nuirons.org]: preJoinMembership=invite, inviter=@ariagale:nuirons.org, opts={} index-B47ftdGJ.js:11:164450 FetchHttpApi: --> POST https://matrix.nuirons.org/_matrix/client/v3/join/!jMP1RcSSLddEtaWB6N%3Anuirons.org index-B47ftdGJ.js:11:164450 FetchHttpApi: <-- POST https://matrix.nuirons.org/_matrix/client/v3/join/!jMP1RcSSLddEtaWB6N%3Anuirons.org [16ms 200] index-B47ftdGJ.js:11:164450 FetchHttpApi: --> PUT https://matrix.nuirons.org/_matrix/client/v3/user/%40melogale%3Anuirons.org/account_data/m.direct index-B47ftdGJ.js:11:164450 FetchHttpApi: <-- GET https://matrix.nuirons.org/_matrix/client/v3/sync?filter=xxx&timeout=xxx&org.matrix.msc4222.use_state_after=xxx&since=xxx [5073ms 200] index-B47ftdGJ.js:11:164450 FetchHttpApi: --> GET https://matrix.nuirons.org/_matrix/client/v3/sync?filter=xxx&timeout=xxx&org.matrix.msc4222.use_state_after=xxx&since=xxx index-B47ftdGJ.js:11:164450 FetchHttpApi: <-- PUT https://matrix.nuirons.org/_matrix/client/v3/user/%40melogale%3Anuirons.org/account_data/m.direct [16ms 200] index-B47ftdGJ.js:11:164450 FetchHttpApi: <-- GET https://matrix.nuirons.org/_matrix/client/v3/sync?filter=xxx&timeout=xxx&org.matrix.msc4222.use_state_after=xxx&since=xxx [22ms 200] index-B47ftdGJ.js:11:164450 FetchHttpApi: --> GET https://matrix.nuirons.org/_matrix/client/unstable/im.nheko.summary/summary/!jMP1RcSSLddEtaWB6N%3Anuirons.org index-B47ftdGJ.js:11:164450 FetchHttpApi: --> GET https://matrix.nuirons.org/_matrix/client/v3/sync?filter=xxx&timeout=xxx&org.matrix.msc4222.use_state_after=xxx&since=xxx index-B47ftdGJ.js:11:164450 FetchHttpApi: <-- GET https://matrix.nuirons.org/_matrix/client/unstable/im.nheko.summary/summary/!jMP1RcSSLddEtaWB6N%3Anuirons.org [43ms 200] index-B47ftdGJ.js:11:164450 joinRoom[!jMP1RcSSLddEtaWB6N:nuirons.org]: preJoinMembership=invite, inviter=@ariagale:nuirons.org, opts={}
❤️ 1
gamesguru commented 2026-02-26 04:09:13 +00:00
Author
Contributor
Copy link

@melogale If you have it still running, can you try joining a broken room (issue 1142)? If the server logs start spamming, you would need to issue an admin command to force leave the room, or else deal with the flood of logs til your admin can.

I appreciate your efforts and bravery! I'm setting up my a development box to help aid in the guinea pig testing!

It's great to here there haven't been any obvious issues or bugs introduced on this PR with joins or other database modifications that these transactional wrappers touch!

Here's an example room that should likely still be broken,

WARN conduwuit_api::client::sync::v3: error loading joined room err=Room !eBgZCVRnRRkKchiYzS:monero.social has no state room_id=!eBgZCVRnRRkKchiYzS:monero.social
WARN conduwuit_api::client::sync::v3: error loading joined room err=Room !eBgZCVRnRRkKchiYzS:monero.social has no state room_id=!eBgZCVRnRRkKchiYzS:monero.social
  ERROR conduwuit_api::client::sync::v3::joined: Room !eBgZCVRnRRkKchiYzS:monero.social has no state
    at src/api/client/sync/v3/joined.rs:355 on conduwuit:worker ThreadId(2)

WARN conduwuit_api::client::sync::v3: error loading joined room err=Room !eBgZCVRnRRkKchiYzS:monero.social has no state room_id=!eBgZCVRnRRkKchiYzS:monero.social
  ERROR conduwuit_api::client::sync::v3::joined: Room !eBgZCVRnRRkKchiYzS:monero.social has no state
    at src/api/client/sync/v3/joined.rs:355 on conduwuit:worker ThreadId(2)

WARN conduwuit_api::client::sync::v3: error loading joined room err=Room !eBgZCVRnRRkKchiYzS:monero.social has no state room_id=!eBgZCVRnRRkKchiYzS:monero.social
  ERROR conduwuit_api::client::sync::v3::joined: Room !eBgZCVRnRRkKchiYzS:monero.social has no state
    at src/api/client/sync/v3/joined.rs:355 on conduwuit:worker ThreadId(4)
@melogale If you have it still running, can you try joining a broken room (issue 1142)? If the server logs start spamming, you would need to issue an admin command to force leave the room, or else deal with the flood of logs til your admin can. I appreciate your efforts and bravery! I'm setting up my a development box to help aid in the guinea pig testing! It's great to here there haven't been any obvious issues or bugs introduced on this PR with joins or other database modifications that these transactional wrappers touch! Here's an example room that should likely still be broken, ```log WARN conduwuit_api::client::sync::v3: error loading joined room err=Room !eBgZCVRnRRkKchiYzS:monero.social has no state room_id=!eBgZCVRnRRkKchiYzS:monero.social WARN conduwuit_api::client::sync::v3: error loading joined room err=Room !eBgZCVRnRRkKchiYzS:monero.social has no state room_id=!eBgZCVRnRRkKchiYzS:monero.social ERROR conduwuit_api::client::sync::v3::joined: Room !eBgZCVRnRRkKchiYzS:monero.social has no state at src/api/client/sync/v3/joined.rs:355 on conduwuit:worker ThreadId(2) WARN conduwuit_api::client::sync::v3: error loading joined room err=Room !eBgZCVRnRRkKchiYzS:monero.social has no state room_id=!eBgZCVRnRRkKchiYzS:monero.social ERROR conduwuit_api::client::sync::v3::joined: Room !eBgZCVRnRRkKchiYzS:monero.social has no state at src/api/client/sync/v3/joined.rs:355 on conduwuit:worker ThreadId(2) WARN conduwuit_api::client::sync::v3: error loading joined room err=Room !eBgZCVRnRRkKchiYzS:monero.social has no state room_id=!eBgZCVRnRRkKchiYzS:monero.social ERROR conduwuit_api::client::sync::v3::joined: Room !eBgZCVRnRRkKchiYzS:monero.social has no state at src/api/client/sync/v3/joined.rs:355 on conduwuit:worker ThreadId(4) ```
Jade changed title from feat: implement transactional wrappers around room joins and other key code blocks writing to the database to WIP: feat: implement transactional wrappers around room joins and other key code blocks writing to the database 2026-03-03 18:32:20 +00:00
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Has been skipped
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 15m40s
Required
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 24m23s
Required
Details
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u guru/experiment/rocksdb-transactional-wrappers:gamesguru-guru/experiment/rocksdb-transactional-wrappers
git switch gamesguru-guru/experiment/rocksdb-transactional-wrappers
Sign in to join this conversation.
Reviewers
No reviewers
Jade
nex
ginger
Labels
Clear labels   
Blocked

This pull request or issue is currently blocked from being merged/closed

  
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Dependencies/Renovate

Automatic dependency upgrades by Renovate

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

Issues relating to core matrix functionality, such as state resolution and PDU formats

  
Matrix/E2EE

   
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/Hydra

Issues related to room version 12 and related changes (temporary label)

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Matrix/T&S

Changes or issues related to trust & safety tooling

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/CI

Issues related to CI changes

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status
Confirmed
This issue has enough information and is confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
Support

Questions or support requests

  
To-Merge

   
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Blocked
Bug
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/E2EE
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Matrix/T&S
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Support
To-Merge
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
next
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity!1455
No description provided.