Legacy sync cleanup, removal of legacy SS #1132

Open
ginger wants to merge 37 commits from ginger/sync-v3-cleanup into main
Owner

Fixes !361, fixes !839, generally improves performance and fixes weird edge cases in clients. Please test this PR out if you can!

Fixes !361, fixes !839, generally improves performance and fixes weird edge cases in clients. Please test this PR out if you can!
fix(sync/v3): Cleanup part 1: mostly fix redundant data in state
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m7s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m6s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 10m1s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 9m23s
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 18m36s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 26s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 14m46s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 14m34s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 14s
8cc0c8a683
ginger force-pushed ginger/sync-v3-cleanup from 8cc0c8a683
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m7s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m6s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 10m1s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 9m23s
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 18m36s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 26s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 14m46s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 14m34s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 14s
to 8cfd0f56bf
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m6s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m2s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 9m9s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 9m17s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 17s
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 16m9s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 24m57s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 19m7s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 15s
2025-10-20 22:09:51 +00:00
Compare
Author
Owner

This breaks SSS right now -- initial syncs load the timeline from some random point months back in the room's history.

This breaks SSS right now -- initial syncs load the timeline from some random point months back in the room's history.
fix: Correctly send limited timelines again
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 54s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m42s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 6m41s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 7m48s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 16s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 18m19s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 14m32s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 14m27s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 15s
9ce3f35585
Author
Owner

SSS is working again yippee

SSS is working again yippee
Owner

Not sure how you feel about incorporating #842/files ? There isn't too much code, although it does rely on continuwuation/ruwuma@a3a59ebdfd

Not sure how you feel about incorporating https://forgejo.ellis.link/continuwuation/continuwuity/pulls/842/files#diff-9f684633f9f58d3977eff84a4456712d59c23a54 ? There isn't too much code, although it does rely on https://forgejo.ellis.link/continuwuation/ruwuma/commit/a3a59ebdfd98b4d18237f6e274ed44591585af7d
Author
Owner

@Jade wrote in #1132 (comment):

Not sure how you feel about incorporating #842/files ? There isn't too much code, although it does rely on continuwuation/ruwuma@a3a59ebdfd

Incorporate in what sense?

@Jade wrote in https://forgejo.ellis.link/continuwuation/continuwuity/pulls/1132#issuecomment-21208: > Not sure how you feel about incorporating #842/files ? There isn't too much code, although it does rely on [`continuwuation/ruwuma@a3a59ebdfd`](https://forgejo.ellis.link/continuwuation/ruwuma/commit/a3a59ebdfd98b4d18237f6e274ed44591585af7d) Incorporate in what sense?
ginger changed title from WIP: Sync v3 cleanup to WIP: Legacy sync cleanup, removal of legacy SS 2025-10-22 20:11:20 +00:00
Owner

Merging it, basically (given it conflicts with the refactoring here)

Merging it, basically (given it conflicts with the refactoring here)
Author
Owner

@Jade wrote in #1132 (comment):

Merging it, basically (given it conflicts with the refactoring here)

I can do that yeah

@Jade wrote in https://forgejo.ellis.link/continuwuation/continuwuity/pulls/1132#issuecomment-21212: > Merging it, basically (given it conflicts with the refactoring here) I can do that yeah
nex requested review from nex 2025-10-23 03:04:07 +00:00
nex added this to the 0.5.0 milestone 2025-10-23 03:04:09 +00:00
fix(sync/v3): Further cleanup + improve incremental sync consistency
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 46s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m34s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 6m44s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 7m23s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 15s
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 14m34s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 13m46s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 13m48s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 14s
ac0238d06a
@ -0,0 +76,4 @@
a token which identifies the state of the room at a point in time.
2. `load_timeline` is called to fetch timeline events that happened since `since`.
3.
*/
Owner
  1. forget to write the rest of the comment :3
3. forget to write the rest of the comment :3
Author
Owner

i forgor 💀

i forgor 💀
ginger marked this conversation as resolved
- Remove most usages of `update_membership` in favor
  of directly calling the `mark_as_*` functions
- Store the leave membership event as the value in the
  `userroomid_leftstate` table
- Use the `userroomid_leftstate` table to synchronize the
  timeline and state for left rooms if possible
fix: Set limited to true for newly joined rooms again
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 47s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m38s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 2m46s
Update flake hashes / update-flake-hashes (pull_request) Failing after 1m46s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 3m19s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 21s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 1m41s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 1m56s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 13s
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 11m21s
6794951ee3
Author
Owner

@ginger wrote in #1132 (comment):

!839 still appears to be a problem when leaving rooms. I suspect we're eliding membership events when we shouldn't.

This is now fixed, but clients sometimes get confused when leaving a room -- there are situations where we can send a join membership event for the user in state but a leave membership event in timeline, which is correct behavior because state should only go up to the start of timeline, but Cinny (at least) gets confused and doesn't remove the room from its UI.

@ginger wrote in https://forgejo.ellis.link/continuwuation/continuwuity/pulls/1132#issuecomment-21215: > !839 still appears to be a problem when leaving rooms. I suspect we're eliding membership events when we shouldn't. This is now fixed, but clients sometimes get confused when leaving a room -- there are situations where we can send a `join` membership event for the user in `state` but a `leave` membership event in `timeline`, which is correct behavior because `state` should only go up to the start of `timeline`, but Cinny (at least) gets confused and doesn't remove the room from its UI.
Author
Owner

Additionally, if an invite is cancelled by the user that sent it the room will still appear as invited until an initial sync is performed.

Additionally, if an invite is cancelled by the user that sent it the room will still appear as `invited` until an initial sync is performed.
feat: Typing notifications in simplified sliding sync
Some checks failed
Release Docker Image / define-variables (push) Successful in 3s
Rust Checks / Format (push) Successful in 1m7s
Documentation / Build and Deploy Documentation (pull_request) Successful in 40s
Rust Checks / Clippy (push) Failing after 5m21s
Rust Checks / Cargo Test (push) Successful in 6m8s
Release Docker Image / build-image (linux/arm64, linux-arm64) (push) Successful in 15m17s
Release Docker Image / build-image (linux/amd64, linux-amd64) (push) Successful in 16m0s
Release Docker Image / merge (push) Successful in 22s
4c01274886
What's missing? Being able to use separate rooms & lists for typing
indicators.
At the moment, we use the same ones as we use for the timeline, as
todo_rooms is quite intertwined. We need to disentangle this to get that
functionality, although I'm not sure if clients use it.
chore: Merge remote-tracking branch 'upstream/jade/syncv5-typing' into ginger/sync-v3-cleanup
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 46s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m41s
Update flake hashes / update-flake-hashes (pull_request) Failing after 1m6s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 3m27s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 3m2s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 31s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 1m50s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 2m3s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 16s
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 15m0s
d0680f6d61
Merge branch 'main' into ginger/sync-v3-cleanup
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 54s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m45s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 6m36s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 6m55s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 25s
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 20m22s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 14m43s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 14m28s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 14s
5207051635
Author
Owner

@ginger wrote in #1132 (comment):

Additionally, if an invite is cancelled by the user that sent it the room will still appear as invited until an initial sync is performed.

I don't think there's anything we can do about this -- the S2S spec doesn't seem to include a way to retract invites over federation.

@ginger wrote in https://forgejo.ellis.link/continuwuation/continuwuity/pulls/1132#issuecomment-21306: > Additionally, if an invite is cancelled by the user that sent it the room will still appear as `invited` until an initial sync is performed. I don't think there's anything we can do about this -- the S2S spec doesn't seem to include a way to retract invites over federation.
Jade force-pushed ginger/sync-v3-cleanup from 5207051635
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 54s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m45s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 6m36s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 6m55s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 25s
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 20m22s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 14m43s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 14m28s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 14s
to 25211ec56d
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 48s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m50s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 7m6s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 6m40s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 29s
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 16m46s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 13m6s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 13m14s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 17s
2025-10-28 14:02:41 +00:00
Compare
chore: Clippy fixes
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m17s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m26s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 5m54s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 6m38s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 15s
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 14m25s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 21m36s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 18m19s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 14s
7b1dbcbb81
fix: Use prepare_lazily_loaded_members for joined rooms
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 59s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m44s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 6m23s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 6m12s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 14s
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 13m46s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 13m12s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 13m9s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 14s
22f7ad3d59
Also, don't take read receipts into consideration for lazy loading.
Synapse doesn't do this and they're making initial syncs very large.
chore: Remove unneeded comment
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m1s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m19s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 8m53s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 8m41s
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 18m4s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 16s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 23m45s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 26m49s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 15s
2a0beac32b
ginger force-pushed ginger/sync-v3-cleanup from 2a0beac32b
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m1s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m19s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 8m53s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 8m41s
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 18m4s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 16s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 23m45s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 26m49s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 15s
to a6e92eff11
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 47s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m40s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 7m27s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 5m41s
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 16m43s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 19s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 17m17s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 17m20s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 15s
2025-10-28 17:46:50 +00:00
Compare
ginger changed title from WIP: Legacy sync cleanup, removal of legacy SS to Legacy sync cleanup, removal of legacy SS 2025-10-28 17:47:48 +00:00
ci: Don't force override rust version by default
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 44s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m25s
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 5m31s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 4m56s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 4m34s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 16s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 22m48s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 22m50s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 14s
cd783221d9
nex self-assigned this 2025-10-28 18:47:32 +00:00
nex requested changes 2025-11-02 01:25:24 +00:00
Dismissed
nex left a comment
Owner

pretty solid honestly, been running for most of the week and haven't run into any issues myself. Just a couple things and I think it should be good to go really.

pretty solid honestly, been running for most of the week and haven't run into any issues myself. Just a couple things and I think it should be good to go really.
@ -1199,0 +1202,4 @@
# The default of 10 is reasonable for most use cases.
#
#incremental_sync_max_timeline_size = 10
Owner

Why 10? The specced limit is 100 and most clients take 20-50 at a time, 10 seems quite low especially for high-traffic rooms (such as the ping room)

Why 10? The specced limit is 100 and most clients take 20-50 at a time, 10 seems quite low especially for high-traffic rooms (such as the ping room)
Author
Owner

10 was the old hard-coded value and I assumed the Ancient Maintainers knew what they were doing when they selected it 🧌 what do you think a more reasonable value would be?

10 was the old hard-coded value and I assumed the Ancient Maintainers knew what they were doing when they selected it 🧌 what do you think a more reasonable value would be?
ginger marked this conversation as resolved
@ -480,0 +480,4 @@
// TODO: this call does not appear to do anything because `update_membership`
// doesn't call `mark_as_knock`. investigate further, ideally with the aim of
// removing this call entirely -- Ginger thinks `update_membership` should only
// be called from `force_state` and `append_pdu`.
Owner

federated knocks and invites don't give you real PDUs so I'm not entirely sure the named functions can be used

federated knocks and invites don't give you real PDUs so I'm not entirely sure the named functions can be used
Author
Owner

mark_as_invited and mark_as_knocked both (iirc) take only the stripped state as an argument. update_membership was previously heavily overloaded to handle all of that in one function, hence me attempting to only use it in the two places where the caches need to be updated from an arbitrary PDU.

`mark_as_invited` and `mark_as_knocked` both (iirc) take only the stripped state as an argument. `update_membership` was previously heavily overloaded to handle all of that in one function, hence me attempting to only use it in the two places where the caches need to be updated from an arbitrary PDU.
nex marked this conversation as resolved
@ -0,0 +184,4 @@
.into();
let is_encrypted_room = services
.rooms
Owner

It's worth noting that this only happens when every membership for the user has been state reset out of the room entirely, as if they were never in it in the first place. This should be incredibly rare, but [M]

It's worth noting that this only happens when *every* membership for the user has been state reset out of the room entirely, as if they were never in it in the first place. This *should* be incredibly rare, but [M]
@ -0,0 +201,4 @@
timeline_start_shortstatehash,
is_encrypted_room,
)
.await;
Owner

nitpick: This is one hell of a statement, could it be made more readable? for maintainability's sakes

nitpick: This is one hell of a statement, could it be made more readable? for maintainability's sakes
ginger marked this conversation as resolved
@ -0,0 +262,4 @@
origin_server_ts: utils::millis_since_unix_epoch()
.try_into()
.expect("Timestamp is valid js_int value"),
kind: TimelineEventType::RoomMember,
Owner

Any reason the event ID can't be calculated? We know from the policy server bugs that calculating on a partial PDU is totally viable

Any reason the event ID can't be calculated? We know from the policy server bugs that calculating on a partial PDU is totally viable
Author
Owner

The PDU we're returning on this code path doesn't actually exist in the room's DAG or our database, so we have to make up an ID. This should only happen if the room was banned or the user left it before this PR was merged (so there's no cached leave state). I'm going to investigate trawling the database to fix up old leaves as part of a migration, but there's no easy way around it for banned rooms.

The PDU we're returning on this code path doesn't actually exist in the room's DAG or our database, so we have to make up an ID. This should only happen if the room was banned or the user left it before this PR was merged (so there's no cached leave state). I'm going to investigate trawling the database to fix up old leaves as part of a migration, but there's no easy way around it for banned rooms.
nex marked this conversation as resolved
Owner

Might be worth omitting offline users in the initial sync since

a. most people dont care about offline uesrs
b. I think offline is the default state?

Might be worth omitting offline users in the initial sync since a. most people dont care about offline uesrs b. I think offline is the default state?
Author
Owner

Initial sync already sends pretty few users with LL enabled, I doubt this would be much of a performance win.

Initial sync already sends pretty few users with LL enabled, I doubt this would be much of a performance win.
nex marked this conversation as resolved
@ -445,1 +440,3 @@
.and_then(|val: Raw<Vec<AnyStrippedStateEvent>>| val.deserialize_as().map_err(Into::into))
// old databases may have garbage data as values in the `userroomid_leftstate` table from before
// the leave event was stored there. they still need to be included, so we return Ok(None) for deserialization failures.
.unwrap_or(None)
Owner

no migration instead?

no migration instead?
ginger marked this conversation as resolved
Owner

Oh also clippy nightly needs running (see: Checks / Prek / Clippy and Cargo Tests failing)

Oh also clippy nightly needs running (see: `Checks / Prek / Clippy and Cargo Tests` failing)
Owner

marking as blocking since this is one of the few remaining major changes before a release can be considered

marking as blocking since this is one of the few remaining major changes before a release can be considered
@ -0,0 +451,4 @@
}
lazily_loaded_members
}
Owner

Clippy wants you to skip the assignment here, although I think the variable name makes it clearer, so feel free to #[allow(clippy::let-and-return)]

Clippy wants you to skip the assignment here, although I think the variable name makes it clearer, so feel free to `#[allow(clippy::let-and-return)]`
ginger marked this conversation as resolved
chore(sync/v3): Fix clippy lints
Some checks failed
Release Docker Image / Build linux-amd64 (release) (pull_request) Failing after 53s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m27s
Release Docker Image / Build linux-arm64 (release) (pull_request) Failing after 27s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Has been skipped
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Has been skipped
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Has been skipped
Release Docker Image / Create Max-Perf Manifest (pull_request) Has been skipped
Documentation / Build and Deploy Documentation (pull_request) Successful in 3m53s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m43s
b745f6b31f
feat(sync/v3): Remove TL size config option in favor of using the sync filter
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 49s
Release Docker Image / Build linux-amd64 (release) (pull_request) Failing after 43s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m23s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 7m47s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 9m15s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Has been skipped
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Has been skipped
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Has been skipped
Release Docker Image / Create Max-Perf Manifest (pull_request) Has been skipped
2588e0a763
fix(sync/v3): Fix invite filtering for federated invites
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 50s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m36s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 7m23s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 6m43s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 15s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 11m10s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 14m5s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 14m1s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 13s
8da6360429
fix(sync/v3): Implement a migration for the userroomid_leftstate table
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 49s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m28s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 5m7s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 5m21s
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 6m11s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 16s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 12m46s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 12m46s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 13s
832f9bc39b
fix(sync/v3): Cache shortstatehashes to speed up migration
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 48s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m30s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 5m30s
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 6m4s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 5m28s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 15s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 12m49s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 12m56s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 18s
8fc300b332
chore(sync/v3): Sacrifice a goat to clippy
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 47s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m18s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 5m49s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 5m41s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 7m16s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 23s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 14m10s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 14m19s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 20s
e5c59583b9
fix(sync/v3): Do not include the last membership event when syncing left rooms
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 49s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m20s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 5m7s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 7m37s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 4m12s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 13s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 12m13s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 12m13s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 13s
a52fba2c3d
fix(sync/v3): Add a workaround for matrix-js-sdk/5071
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 46s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m35s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 6m43s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 6m45s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 21s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 9m1s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 14m19s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 14m16s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 14s
d111a0ef6f
fix: Correct error message
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m17s
Checks / Prek / Pre-commit & Formatting (pull_request) Failing after 2m20s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 5m47s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 5m46s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 15s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m17s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 13m2s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 12m57s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 13s
2ba091ed6d
ginger changed title from Legacy sync cleanup, removal of legacy SS to WIP: Legacy sync cleanup, removal of legacy SS 2025-11-07 22:27:03 +00:00
Author
Owner

re-WIPed because I'm working on a refactor but it's busted rn

re-WIPed because I'm working on a refactor but it's busted rn
nex dismissed nex's review 2025-11-08 23:37:01 +00:00
Reason:

stale

Owner

Re-request review from me when you've unbusted it 🫶

Re-request review from me when you've unbusted it 🫶
nex removed their assignment 2025-11-08 23:37:27 +00:00
refactor(sync/v3): Split load_joined_room into smaller functions
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 42s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m36s
Update flake hashes / update-flake-hashes (pull_request) Successful in 26s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 6m56s
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 7m11s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 6m59s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 19s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 17m16s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 17m39s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 16s
2fa93904fa
chore(sync/v3): More goat sacrifices
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 45s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m17s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 5m1s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m3s
Update flake hashes / update-flake-hashes (pull_request) Successful in 11s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 4m34s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 15s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 16m45s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 16m9s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 15s
623f138f6e
ginger force-pushed ginger/sync-v3-cleanup from 623f138f6e
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 45s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m17s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 5m1s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 8m3s
Update flake hashes / update-flake-hashes (pull_request) Successful in 11s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 4m34s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 15s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 16m45s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 16m9s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 15s
to 0f36806b19
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 45s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m32s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 6m27s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 6m40s
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 8m57s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 13s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 17m52s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 17m31s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 15s
2025-11-10 17:52:52 +00:00
Compare
ginger changed title from WIP: Legacy sync cleanup, removal of legacy SS to Legacy sync cleanup, removal of legacy SS 2025-11-10 17:53:04 +00:00
Author
Owner

should be ready for review again, I'm going to avoid making any more big changes because this diff is already huge and if I continue tweaking shit it'll never get merged

should be ready for review again, I'm going to avoid making any more big changes because this diff is already huge and if I continue tweaking shit it'll never get merged
fix: Bump max startup time to ten minutes in the systemd unit
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 58s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m19s
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 3m38s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 4m46s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 4m40s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 14s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 23m30s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 23m36s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 13s
d29ad99f8d
nex self-assigned this 2025-11-10 19:40:02 +00:00
Owner

TODO review (forgejo won't let me re-request my own review)

TODO review (forgejo won't let me re-request my own review)
Owner

@ginger wrote in #1132 (comment):

should be ready for review again, I'm going to avoid making any more big changes because this diff is already huge and if I continue tweaking shit it'll never get merged

dw about the diff too much, the important thing is that the commits make sense so that a blame doesn't follow back to one gigantic commit saying "merged the thing". More than happy to review gigantic diffs lol

@ginger wrote in https://forgejo.ellis.link/continuwuation/continuwuity/pulls/1132#issuecomment-21507: > should be ready for review again, I'm going to avoid making any more big changes because this diff is already huge and if I continue tweaking shit it'll never get merged dw about the diff too much, the important thing is that the commits make sense so that a blame doesn't follow back to one gigantic commit saying "merged the thing". More than happy to review gigantic diffs lol
Jade requested reviews from Jade, Owners 2025-11-10 22:39:58 +00:00
ginger force-pushed ginger/sync-v3-cleanup from d29ad99f8d
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 58s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m19s
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 3m38s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 4m46s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 4m40s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 14s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 23m30s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 23m36s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 13s
to 779be80928
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 56s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m23s
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 6m21s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 7m27s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 6m38s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 14s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 26m32s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 27m18s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 14s
2025-11-11 14:02:00 +00:00
Compare
ginger force-pushed ginger/sync-v3-cleanup from 779be80928
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 56s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m23s
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 6m21s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 7m27s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 6m38s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 14s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 26m32s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 27m18s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 14s
to 6925b9380d
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 45s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m23s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 6m20s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 6m53s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 14s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 10m52s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 20m6s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 22m13s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 21s
2025-11-11 16:07:51 +00:00
Compare
fix: Nitpicky comment reword
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 54s
Checks / Prek / Pre-commit & Formatting (pull_request) Failing after 1m36s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 5m37s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 5m35s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 16s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 7m33s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 11m31s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 11m43s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 15s
9f2f235ca0
chore: Formatting
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 51s
Release Docker Image / Build linux-amd64 (release) (pull_request) Has been cancelled
Release Docker Image / Build linux-arm64 (release) (pull_request) Has been cancelled
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Has been cancelled
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Has been cancelled
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Has been cancelled
Release Docker Image / Create Max-Perf Manifest (pull_request) Has been cancelled
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m22s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 6m48s
Update flake hashes / update-flake-hashes (pull_request) Successful in 11s
2c6ac4bf70
ginger force-pushed ginger/sync-v3-cleanup from 2c6ac4bf70
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 51s
Release Docker Image / Build linux-amd64 (release) (pull_request) Has been cancelled
Release Docker Image / Build linux-arm64 (release) (pull_request) Has been cancelled
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Has been cancelled
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Has been cancelled
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Has been cancelled
Release Docker Image / Create Max-Perf Manifest (pull_request) Has been cancelled
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m22s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 6m48s
Update flake hashes / update-flake-hashes (pull_request) Successful in 11s
to 79dc973900
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 47s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m27s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 6m8s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 5m27s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 16s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 13m59s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 16m50s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 16m57s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 16s
2025-11-12 15:06:20 +00:00
Compare
ginger force-pushed ginger/sync-v3-cleanup from 79dc973900
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 47s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m27s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 6m8s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 5m27s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 16s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 13m59s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 16m50s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 16m57s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 16s
to 51aa173a6e
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 48s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m25s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 6m14s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 6m55s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 23s
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 13m50s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 13m43s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 13m48s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 15s
2025-11-13 18:28:03 +00:00
Compare
chore(sync/v3): Remove unused imports
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 42s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m19s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 7m38s
Update flake hashes / update-flake-hashes (pull_request) Successful in 18s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 6m49s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 15s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 13m31s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 27m39s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 28m1s
Release Docker Image / Create Max-Perf Manifest (pull_request) Failing after 14s
a6e5dfcd50
ginger force-pushed ginger/sync-v3-cleanup from a6e5dfcd50
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 42s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m19s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 7m38s
Update flake hashes / update-flake-hashes (pull_request) Successful in 18s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 6m49s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 15s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 13m31s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 27m39s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 28m1s
Release Docker Image / Create Max-Perf Manifest (pull_request) Failing after 14s
to 5a3446641c
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m2s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m57s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 8m2s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 7m51s
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 15m30s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 19s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 21m58s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 22m51s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 16s
2025-11-14 15:16:09 +00:00
Compare
ginger force-pushed ginger/sync-v3-cleanup from 5a3446641c
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m2s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m57s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 8m2s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 7m51s
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 15m30s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 19s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 21m58s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 22m51s
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 16s
to b16a1615d5
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 59s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m29s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 6m14s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 5m9s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 16s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 13m37s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 13m52s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 13m58s
Release Docker Image / Create Max-Perf Manifest (pull_request) Failing after 10s
2025-11-16 22:18:04 +00:00
Compare
ginger force-pushed ginger/sync-v3-cleanup from b16a1615d5
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 59s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m29s
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 6m14s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 5m9s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 16s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 13m37s
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 13m52s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 13m58s
Release Docker Image / Create Max-Perf Manifest (pull_request) Failing after 10s
to 1a2547541c
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Failing after 10s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m23s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 7m15s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Has been skipped
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 18m17s
Release Docker Image / Build linux-amd64 (release) (pull_request) Failing after 1m16s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Has been skipped
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Has been skipped
Release Docker Image / Create Max-Perf Manifest (pull_request) Has been skipped
2025-11-17 13:48:13 +00:00
Compare
ginger force-pushed ginger/sync-v3-cleanup from 1a2547541c
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Failing after 10s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m23s
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 7m15s
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Has been skipped
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 18m17s
Release Docker Image / Build linux-amd64 (release) (pull_request) Failing after 1m16s
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Has been skipped
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Has been skipped
Release Docker Image / Create Max-Perf Manifest (pull_request) Has been skipped
to 38aa833077
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m14s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m42s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 20m44s
2025-11-21 16:51:48 +00:00
Compare
ginger force-pushed ginger/sync-v3-cleanup from 38aa833077
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m14s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m42s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 20m44s
to bfa03b7c82
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 48s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m22s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 28m15s
2025-11-25 17:21:14 +00:00
Compare
ginger force-pushed ginger/sync-v3-cleanup from bfa03b7c82
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 48s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m22s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 28m15s
to 15196ad249
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m26s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m56s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 36m7s
2025-11-28 20:20:13 +00:00
Compare
ginger force-pushed ginger/sync-v3-cleanup from 15196ad249
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m26s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m56s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 36m7s
to b70d6487d5
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 57s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m10s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 32m25s
2025-11-28 20:25:26 +00:00
Compare
ginger force-pushed ginger/sync-v3-cleanup from b70d6487d5
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 57s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 2m10s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 32m25s
to 17346ff778
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m2s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m46s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 30m42s
2025-11-28 20:25:49 +00:00
Compare
ginger force-pushed ginger/sync-v3-cleanup from 17346ff778
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 1m2s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m46s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 30m42s
to c376fce725
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 57s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 3m13s
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 22m5s
2025-12-03 16:04:33 +00:00
Compare
All checks were successful
Documentation / Build and Deploy Documentation (pull_request) Successful in 57s
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 3m13s
Required
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 22m5s
Required
Details
This pull request is blocked because it's outdated.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin ginger/sync-v3-cleanup:ginger/sync-v3-cleanup
git switch ginger/sync-v3-cleanup
Sign in to join this conversation.
No reviewers
nex
continuwuation/Owners
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity!1132
No description provided.