continuwuation/continuwuity
8
20
Fork 18
Code Issues 82 Pull requests 8 Projects Releases 17 Packages 1 Activity Actions

Always calculate state diff IDs in syncv3 #840

Merged
nex merged 1 commit from nex/fix-join-sync-state into main 2025-06-28 23:11:19 +00:00
Conversation 2 Commits 1 Files changed 1 +1 -3
nex commented 2025-05-26 00:24:42 +00:00
Owner
Copy link

this seemingly at least partially fixes #779 by always calculating the state diff between the sync tokens, rather than checking only if they have changed.
It appears that joins still don't come down sync immediately, but they at least now include all of the relevant state for clients. Fixes the "unnamed room" bug on many clients, and consequently fixes the bug where unsuspecting clients don't know a room is encrypted.

Would like if this could be battle tested to ensure that it does not induce additional load

this seemingly at least partially fixes #779 by always calculating the state diff between the sync tokens, rather than checking only if they have changed. It appears that joins still don't come down sync immediately, but they at least now include all of the relevant state for clients. Fixes the "unnamed room" bug on many clients, and consequently fixes the bug where unsuspecting clients don't know a room is encrypted. Would like if this could be battle tested to ensure that it does not induce additional load
nex added this to the 0.5.0 milestone 2025-05-26 00:24:42 +00:00
nex added the
Bug
Matrix/Client
 labels 2025-05-26 00:24:42 +00:00
nex added 1 commit 2025-05-26 00:24:43 +00:00
Always calculate state diff IDs in syncv3
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 40s
Details
Release Docker Image / define-variables (push) Successful in 2s
Details
Rust Checks / Format (push) Successful in 21s
Details
Rust Checks / Clippy (push) Successful in 5m31s
Details
Rust Checks / Cargo Test (push) Successful in 6m14s
Details
Release Docker Image / build-image (linux/amd64, linux-amd64) (push) Failing after 46s
Details
Release Docker Image / build-image (linux/arm64, linux-arm64) (push) Successful in 20m43s
Details
Release Docker Image / merge (push) Has been skipped
Details
fe853c9ac8 
seemingly fixes #779
nex commented 2025-06-14 22:38:04 +00:00
Author
Owner
Copy link

Haven't had time to properly see if this actually improved anything or if it was the placebo effect, but I didn't notice any new issues arise, so I'm gonna mark this as ready to merge.

It doesn't fix the issue, but it helps it, so.

Haven't had time to properly see if this actually improved anything or if it was the placebo effect, but I didn't notice any new issues arise, so I'm gonna mark this as ready to merge. It doesn't fix the issue, but it helps it, so.
nex force-pushed nex/fix-join-sync-state from fe853c9ac8 to 2bab5755dc 2025-06-14 22:38:14 +00:00 Compare
requested review from Owners 2025-06-14 22:38:25 +00:00
nex force-pushed nex/fix-join-sync-state from 2bab5755dc to 52e042cb06 2025-06-28 20:37:43 +00:00 Compare
removed review request for Owners 2025-06-28 23:11:14 +00:00
nex merged commit 52e042cb06 into main 2025-06-28 23:11:19 +00:00
nex deleted branch nex/fix-join-sync-state 2025-06-28 23:11:19 +00:00
Aranjedeath approved these changes 2025-06-29 01:23:43 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Aranjedeath
Labels
Clear labels   
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

   
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status
Confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Bug
Cherry-picking
Database
Dependencies
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/Federation
Matrix/MSC
Matrix/Media
Meta
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
0.5.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: continuwuation/continuwuity#840
No description provided.
Delete branch "nex/fix-join-sync-state"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?