Always calculate state diff IDs in syncv3 #840

Merged

nex merged 1 commit from nex/fix-join-sync-state into main 2025-06-28 23:11:19 +00:00

Conversation 2 Commits 1 Files changed 1 +1 -3

nex commented 2025-05-26 00:24:42 +00:00

Owner

Copy link

this seemingly at least partially fixes #779 by always calculating the state diff between the sync tokens, rather than checking only if they have changed.
It appears that joins still don't come down sync immediately, but they at least now include all of the relevant state for clients. Fixes the "unnamed room" bug on many clients, and consequently fixes the bug where unsuspecting clients don't know a room is encrypted.

Would like if this could be battle tested to ensure that it does not induce additional load

this seemingly at least partially fixes #779 by always calculating the state diff between the sync tokens, rather than checking only if they have changed. It appears that joins still don't come down sync immediately, but they at least now include all of the relevant state for clients. Fixes the "unnamed room" bug on many clients, and consequently fixes the bug where unsuspecting clients don't know a room is encrypted. Would like if this could be battle tested to ensure that it does not induce additional load

nex added this to the 0.5.0-old milestone 2025-05-26 00:24:42 +00:00

nex added the

Bug

Matrix/Client

labels 2025-05-26 00:24:42 +00:00

nex commented 2025-06-14 22:38:04 +00:00

Author

Owner

Copy link

Haven't had time to properly see if this actually improved anything or if it was the placebo effect, but I didn't notice any new issues arise, so I'm gonna mark this as ready to merge.

It doesn't fix the issue, but it helps it, so.

Haven't had time to properly see if this actually improved anything or if it was the placebo effect, but I didn't notice any new issues arise, so I'm gonna mark this as ready to merge. It doesn't fix the issue, but it helps it, so.

nex force-pushed nex/fix-join-sync-state from fe853c9ac8 to 2bab5755dc 2025-06-14 22:38:14 +00:00 Compare

nex requested review from Owners 2025-06-14 22:38:25 +00:00

nex force-pushed nex/fix-join-sync-state from 2bab5755dc to 52e042cb06 2025-06-28 20:37:43 +00:00 Compare

nex removed review request for Owners 2025-06-28 23:11:14 +00:00

nex merged commit 52e042cb06 into main 2025-06-28 23:11:19 +00:00

nex deleted branch nex/fix-join-sync-state 2025-06-28 23:11:19 +00:00

Aranjedeath approved these changes 2025-06-29 01:23:43 +00:00

nex referenced this pull request 2025-07-09 17:24:20 +00:00

bug: membership changes do not come down sync appropriately #779

Jade modified the milestone from 0.5.0-old to v0.5.0-rc.7 2025-07-25 12:45:10 +00:00

Jade modified the milestone from v0.5.0-rc.7 to 0.5.0-old 2025-07-25 12:48:30 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Aranjedeath

Labels

Clear labels   

Bug

Something isn't working as intended

  

Cherry-picking

Commits picked from other conduit projects

  

Database

This requires or includes changes to the database

  

Dependencies

Something dependency related

  

Dependencies/Renovate

Automatic dependency upgrades by Renovate

  

Difficulty

Easy

Low difficulty to implement - touches few parts of the codebase, low complexity

  

Difficulty

Hard

High difficulty to implement - touches many parts of the codebase, high complexity

  

Difficulty

Medium

Medium difficulty to implement - touches more parts of the codebase, higher complexity

  

Documentation

Improvements or additions to documentation

  

Enhancement

New feature or request

  

Good first issue

Good for newcomers

  

Help wanted

Additional eyes and keyboards are required for this one

  

Inherited

Issues that have been inhereted from the project pre-fork

  

Matrix/Administration

Features pertaining to homeserver administration

  

Matrix/Appservices

Features pertaining to the appservice API

  

Matrix/Auth

Features pertaining to authentication

  

Matrix/Client

Features pertaining to client-to-server interactions

  

Matrix/Core

Issues relating to core matrix functionality, such as state resolution and PDU formats

  

Matrix/Federation

Features pertaining to server-to-server interactions

  

Matrix/Hydra

Issues related to room version 12 and related changes (temporary label)

  

Matrix/MSC

Features pertaining to unstable matrix features

  

Matrix/Media

Features pertaining to media interactions

  

Meta

Related to housekeeping, maintenance, or other repo-meta.

  

Meta/CI

Issues related to CI changes

  

Meta/Packaging

Packaging

  

Priority

Blocking

This issue is blocking the next release

  

Priority

High

This issue is very important

  

Priority

Low

This issue is of a rather low priority

  

Security

This item is related to general security

  

Status/Blocked

This pull request or issue is currently blocked from being merged/closed

  

Status

Confirmed

This issue has enough information and is confirmed

  

Status

Duplicate

This issue or pull request already exists

  

Status

Invalid

This issue doesn't seem right

  

Status

Needs Investigation

This issue needs further investigation

  

To-Merge

  

Wont fix

This will not be worked on

  

old/ci/cd

Ci/CD

Archived

  

old/rust

Pull requests that update Rust code

Archived

No labels

Bug

Cherry-picking

Database

Dependencies

Dependencies/Renovate

Difficulty

Easy

Difficulty

Hard

Difficulty

Medium

Documentation

Enhancement

Good first issue

Help wanted

Inherited

Matrix/Administration

Matrix/Appservices

Matrix/Auth

Matrix/Client

Matrix/Core

Matrix/Federation

Matrix/Hydra

Matrix/MSC

Matrix/Media

Meta

Meta/CI

Meta/Packaging

Priority

Blocking

Priority

High

Priority

Low

Security

Status/Blocked

Status

Confirmed

Status

Duplicate

Status

Invalid

Status

Needs Investigation

To-Merge

Wont fix

old/ci/cd

old/rust

Milestone

Clear milestone

No items

No milestone

0.5.0-old

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

continuwuation/continuwuity!840

No description provided.