continuwuation/continuwuity
9
20
Fork 18
Code Issues 82 Pull requests 8 Projects Releases 17 Packages 1 Activity Actions 5

WIP: feat: Add bundled aggregations support #847

Draft
Jade wants to merge 3 commits from jade/relations into main
pull from: jade/relations
merge into: continuwuation:main
Conversation 0 Commits 3 Files changed 20 +959 -80
Jade commented 2025-06-03 23:15:59 +00:00
Owner
Copy link

It should be good to merge.

It should be good to merge.
Jade added the
Enhancement
Matrix/Client
 labels 2025-06-03 23:15:59 +00:00
Jade added 2 commits 2025-06-03 23:16:00 +00:00 
Also fixes:
- Transaction IDs leaking in event route
- Age not being set for event relations or threads
- Both of the above for search results

Notes down concern with relations table
feat: Add bundled aggregations support
All checks were successful
Release Docker Image / define-variables (push) Successful in 2s
Details
Rust Checks / Format (push) Successful in 40s
Details
Documentation / Build and Deploy Documentation (pull_request) Successful in 42s
Details
Rust Checks / Clippy (push) Successful in 7m9s
Details
Rust Checks / Cargo Test (push) Successful in 7m40s
Details
Release Docker Image / build-image (linux/amd64, linux-amd64) (push) Successful in 11m57s
Details
Release Docker Image / build-image (linux/arm64, linux-arm64) (push) Successful in 28m30s
Details
Release Docker Image / merge (push) Successful in 42s
Details
980e2bb8d5 
Add support for the m.replace and m.reference bundled
aggregations.
This should fix plenty of subtle client issues.
Threads are not included in the new code as they have
historically been written to the database. Replacing the
old system would result in issues when switching away from
continuwuity, so saved for later.
Some TODOs have been left re event visibility and ignored users.
These should be OK for now, though.
Jade added 1 commit 2025-06-05 18:34:09 +00:00
fix: Filter out invalid replacements from bundled aggregations
Some checks failed
Release Docker Image / define-variables (push) Successful in 12s
Details
Rust Checks / Format (push) Successful in 1m1s
Details
Documentation / Build and Deploy Documentation (pull_request) Successful in 49s
Details
Release Docker Image / build-image (linux/amd64, linux-amd64) (push) Failing after 2m3s
Details
Rust Checks / Clippy (push) Successful in 4m46s
Details
Rust Checks / Cargo Test (push) Successful in 5m15s
Details
Release Docker Image / build-image (linux/arm64, linux-arm64) (push) Successful in 14m2s
Details
Release Docker Image / merge (push) Has been skipped
Details
74cf5445cc
Jade added 1 commit 2025-06-13 13:29:19 +00:00
ci: Fix extra bracket in commit shorthash
All checks were successful
Release Docker Image / define-variables (push) Successful in 2s
Details
Rust Checks / Format (push) Successful in 55s
Details
Documentation / Build and Deploy Documentation (pull_request) Successful in 58s
Details
Rust Checks / Clippy (push) Successful in 4m30s
Details
Rust Checks / Cargo Test (push) Successful in 5m3s
Details
Release Docker Image / build-image (linux/arm64, linux-arm64) (push) Successful in 13m23s
Details
Release Docker Image / build-image (linux/amd64, linux-amd64) (push) Successful in 16m10s
Details
Release Docker Image / merge (push) Successful in 23s
Details
e4a0337e56
Jade force-pushed jade/relations from e4a0337e56 to 5a861d406a 2025-06-14 18:40:33 +00:00 Compare
Jade changed title from feat: Add bundled aggregations support to WIP: feat: Add bundled aggregations support 2025-06-25 23:41:17 +00:00
Some checks are pending
Release Docker Image / define-variables (push) Successful in 4s
Details
Rust Checks / Format (push) Successful in 1m3s
Details
Rust Checks / Clippy (push) Successful in 4m57s
Details
Rust Checks / Cargo Test (push) Successful in 5m12s
Details
Documentation / Build and Deploy Documentation (pull_request) Successful in 45s
Details
Release Docker Image / build-image (linux/amd64, linux-amd64) (push) Successful in 17m54s
Details
Release Docker Image / build-image (linux/arm64, linux-arm64) (push) Successful in 17m27s
Details
Release Docker Image / merge (push) Successful in 24s
Details
Checks / *
Required
This pull request has changes conflicting with the target branch.
  • src/api/client/relations.rs
  • src/api/client/room/initial_sync.rs
  • src/api/client/search.rs
  • src/api/client/threads.rs
  • src/core/matrix/pdu/unsigned.rs
  • src/service/rooms/pdu_metadata/data.rs
  • src/service/rooms/threads/mod.rs
  • src/service/rooms/timeline/mod.rs
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin jade/relations:jade/relations
git checkout jade/relations
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

   
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status
Confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Bug
Cherry-picking
Database
Dependencies
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/Federation
Matrix/MSC
Matrix/Media
Meta
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: continuwuation/continuwuity#847
No description provided.
Delete branch "jade/relations"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?