feat: Add bundled aggregations support #847

Merged

Jade merged 14 commits from jade/relations into main 2025-12-21 17:14:36 +00:00

Conversation 4 Commits 14 Files changed 23 +1006 -138

Jade commented 2025-06-03 23:15:59 +00:00

Owner

Copy link

It should be good to merge.

It should be good to merge.

Jade added the

Enhancement

Matrix/Client

labels 2025-06-03 23:15:59 +00:00

Jade force-pushed jade/relations from e4a0337e56 to 5a861d406a 2025-06-14 18:40:33 +00:00 Compare

Jade changed title from feat: Add bundled aggregations support to WIP: feat: Add bundled aggregations support 2025-06-25 23:41:17 +00:00

nex referenced this pull request 2025-07-01 00:21:24 +00:00

Matrix spec updates meta issue #880

Jade commented 2025-07-29 00:43:06 +00:00

Author

Owner

Copy link

for future ref: this needs refactoring to not make so many database hits and to be in a streaming style via something like github.com/JadedBlueEyes/stream-partition/

for future ref: this needs refactoring to not make so many database hits and to be in a streaming style via something like github.com/JadedBlueEyes/stream-partition/

nex referenced this pull request 2025-10-08 21:04:00 +00:00

Threads repeat the first message #1104

Jade referenced this pull request 2025-10-15 17:54:28 +00:00

m.room.create has a null room_id when calling /state on a room #1094

Henry-Hiles commented 2025-12-05 01:13:15 +00:00

First-time contributor

Copy link

Hi hi, I want to offer a 200$CAD bounty for this, because I really want it finished soon for my client :)

Hi hi, I want to offer a 200$CAD bounty for this, because I really want it finished soon for my client :)

Jade force-pushed jade/relations from 5a861d406a to b7c20b103b 2025-12-13 23:40:56 +00:00 Compare

Jade force-pushed jade/relations from b7c20b103b to 241fe1a029 2025-12-13 23:44:23 +00:00 Compare

Jade commented 2025-12-13 23:46:12 +00:00

Author

Owner

Copy link

Test image run, still work to do but I've rebased ontop of the ~500 commits that happened since I last worked on this

[Test image run](https://forgejo.ellis.link/continuwuation/continuwuity/actions/runs/8212/jobs/0/attempt/1), still work to do but I've rebased ontop of the ~500 commits that happened since I last worked on this

Jade force-pushed jade/relations from 241fe1a029 to d97ae18f5b 2025-12-14 00:04:15 +00:00 Compare

Jade force-pushed jade/relations from d97ae18f5b to 2463acf2bb 2025-12-18 02:39:05 +00:00 Compare

Jade added 1 commit 2025-12-18 20:33:57 +00:00

fix: Add aggregations to the search endpoint 2b3bbfb88f

Jade added 2 commits 2025-12-18 21:27:52 +00:00

refactor: Improve code style for bundled aggregations 043cb6cd33

refactor: Reduce database lookups in some cases 2ea952456a

Jade added 4 commits 2025-12-18 22:31:54 +00:00

refactor(perf): Push down visibility check after limit d26a2da703

fix: Don't incorrectly add thread root to relation response 0eda28c819

fix: Return 404 when event is not accessible d3bc50ad2a

fix: Always return the same 404 message in context 7ebb4a6134

Jade added 1 commit 2025-12-18 23:19:30 +00:00

feat: Run visibility checks on bundled relations e4a1908603

Jade added 3 commits 2025-12-19 00:35:43 +00:00

fix: Ensure that room ID is present on state events sent to client ... 80dce8f205

routes

Mostly fixes !1094

The remaining issue is federation routes

fix: Simplify visibility check code fbe392aa58

style: Fix clippy 13daa59a9d

Jade changed title from WIP: feat: Add bundled aggregations support to feat: Add bundled aggregations support 2025-12-19 01:07:42 +00:00

Jade commented 2025-12-19 01:55:11 +00:00

Author

Owner

Copy link

Things here:

• This scans every relation, even though only a subset will be returned. Optimising this would be difficult (either schema changes or more intertwining with the database code)
• Doesn't fix the server part of v12 room IDs

but it's in a good enough state

Things here: - This scans every relation, even though only a subset will be returned. Optimising this would be difficult (either schema changes or more intertwining with the database code) - Doesn't fix the server part of v12 room IDs but it's in a good enough state

ginger force-pushed jade/relations from 13daa59a9d to bb0d4bdaad 2025-12-19 01:56:13 +00:00 Compare

Jade force-pushed jade/relations from bb0d4bdaad to b165370560 2025-12-19 01:57:03 +00:00 Compare

Jade force-pushed jade/relations from b165370560 to 8fd15f26ce 2025-12-21 17:12:46 +00:00 Compare

Jade merged commit 8fd15f26ce into main 2025-12-21 17:14:36 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Blocked

This pull request or issue is currently blocked from being merged/closed

  

Bug

Something isn't working as intended

  

Cherry-picking

Commits picked from other conduit projects

  

Database

This requires or includes changes to the database

  

Dependencies

Something dependency related

  

Dependencies/Renovate

Automatic dependency upgrades by Renovate

  

Difficulty

Easy

Low difficulty to implement - touches few parts of the codebase, low complexity

  

Difficulty

Hard

High difficulty to implement - touches many parts of the codebase, high complexity

  

Difficulty

Medium

Medium difficulty to implement - touches more parts of the codebase, higher complexity

  

Documentation

Improvements or additions to documentation

  

Enhancement

New feature or request

  

Good first issue

Good for newcomers

  

Help wanted

Additional eyes and keyboards are required for this one

  

Inherited

Issues that have been inhereted from the project pre-fork

  

Matrix/Administration

Features pertaining to homeserver administration

  

Matrix/Appservices

Features pertaining to the appservice API

  

Matrix/Auth

Features pertaining to authentication

  

Matrix/Client

Features pertaining to client-to-server interactions

  

Matrix/Core

Issues relating to core matrix functionality, such as state resolution and PDU formats

  

Matrix/Federation

Features pertaining to server-to-server interactions

  

Matrix/Hydra

Issues related to room version 12 and related changes (temporary label)

  

Matrix/MSC

Features pertaining to unstable matrix features

  

Matrix/Media

Features pertaining to media interactions

  

Meta

Related to housekeeping, maintenance, or other repo-meta.

  

Meta/CI

Issues related to CI changes

  

Meta/Packaging

Packaging

  

Priority

Blocking

This issue is blocking the next release

  

Priority

High

This issue is very important

  

Priority

Low

This issue is of a rather low priority

  

Security

This item is related to general security

  

Status

Confirmed

This issue has enough information and is confirmed

  

Status

Duplicate

This issue or pull request already exists

  

Status

Invalid

This issue doesn't seem right

  

Status

Needs Investigation

This issue needs further investigation

  

Support

Questions or support requests

  

To-Merge

  

Wont fix

This will not be worked on

  

old/ci/cd

Ci/CD

Archived

  

old/rust

Pull requests that update Rust code

Archived

No labels

Blocked

Bug

Cherry-picking

Database

Dependencies

Dependencies/Renovate

Difficulty

Easy

Difficulty

Hard

Difficulty

Medium

Documentation

Enhancement

Good first issue

Help wanted

Inherited

Matrix/Administration

Matrix/Appservices

Matrix/Auth

Matrix/Client

Matrix/Core

Matrix/Federation

Matrix/Hydra

Matrix/MSC

Matrix/Media

Meta

Meta/CI

Meta/Packaging

Priority

Blocking

Priority

High

Priority

Low

Security

Status

Confirmed

Status

Duplicate

Status

Invalid

Status

Needs Investigation

Support

To-Merge

Wont fix

old/ci/cd

old/rust

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

continuwuation/continuwuity!847

No description provided.