continuwuation/continuwuity
continuwuation/continuwuity
11
32
Fork 29
Code Issues 94 Pull requests 17 Releases 19 Packages 4 Activity Actions

Properly send notifications to systemd when a reload is triggered #1073

Merged
nex merged 1 commit from ginger/fix-systemd-reload into main 2025-10-15 03:12:54 +00:00
Conversation 1 Commits 1 Files changed 6 +17 -6
ginger commented 2025-09-24 12:52:57 +00:00
Member
Copy link

This also removes possible undefined behavior caused by sd_notify::notify invoking std::env::remove_var, which can cause UB in multi-threaded programs.

This also removes possible undefined behavior caused by `sd_notify::notify` invoking `std::env::remove_var`, which can cause UB in multi-threaded programs.
nex added this to the 0.5.0 milestone 2025-09-25 02:12:54 +00:00
ginger force-pushed ginger/fix-systemd-reload from 261974315e
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 48s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m32s
Details
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 7m32s
Details
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 7m10s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 14m49s
Details
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 10s
Details
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 13m2s
Details
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 13m13s
Details
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 9s
Details
Update flake hashes / update-flake-hashes (pull_request) Failing after 55s
Details
to 33755c024e
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 54s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m49s
Details
Update flake hashes / update-flake-hashes (pull_request) Failing after 1m59s
Details
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 6m10s
Details
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 6m19s
Details
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 13s
Details
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 14m21s
Details
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 14m0s
Details
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 11s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 5m41s
Details
2025-09-25 12:52:28 +00:00 Compare
ginger force-pushed ginger/fix-systemd-reload from 33755c024e
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 54s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m49s
Details
Update flake hashes / update-flake-hashes (pull_request) Failing after 1m59s
Details
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 6m10s
Details
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 6m19s
Details
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 13s
Details
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 14m21s
Details
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 14m0s
Details
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 11s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Failing after 5m41s
Details
to fd6910558e
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 48s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m13s
Details
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 6m18s
Details
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 6m17s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 9m1s
Details
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 14s
Details
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 16m55s
Details
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 16m52s
Details
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 11s
Details
Update flake hashes / update-flake-hashes (pull_request) Failing after 1m22s
Details
2025-09-26 18:36:24 +00:00 Compare
nex commented 2025-10-15 03:10:18 +00:00
Owner
Copy link

anything blocking this?

~~anything blocking this?~~
nex force-pushed ginger/fix-systemd-reload from fd6910558e
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 48s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m13s
Details
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 6m18s
Details
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 6m17s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 9m1s
Details
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 14s
Details
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 16m55s
Details
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 16m52s
Details
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 11s
Details
Update flake hashes / update-flake-hashes (pull_request) Failing after 1m22s
Details
to dc047b635f
Some checks failed
Documentation / Build and Deploy Documentation (pull_request) Successful in 52s
Details
Checks / Prek / Pre-commit & Formatting (pull_request) Successful in 1m37s
Details
Update flake hashes / update-flake-hashes (pull_request) Failing after 30s
Details
Documentation / Build and Deploy Documentation (push) Successful in 1m0s
Details
Checks / Prek / Pre-commit & Formatting (push) Successful in 1m44s
Details
Release Docker Image / Build linux-arm64 (release) (pull_request) Successful in 10m43s
Details
Release Docker Image / Build linux-amd64 (release) (pull_request) Successful in 11m18s
Details
Release Docker Image / Build linux-amd64 (release) (push) Successful in 5m46s
Details
Release Docker Image / Build linux-arm64 (release) (push) Successful in 5m43s
Details
Release Docker Image / Create Multi-arch Release Manifest (pull_request) Successful in 16s
Details
Checks / Prek / Clippy and Cargo Tests (pull_request) Successful in 22m59s
Details
Release Docker Image / Create Multi-arch Release Manifest (push) Successful in 16s
Details
Checks / Prek / Clippy and Cargo Tests (push) Successful in 21m33s
Details
Release Docker Image / Build linux-amd64 (max-perf) (pull_request) Successful in 15m40s
Details
Release Docker Image / Build linux-arm64 (max-perf) (pull_request) Successful in 16m10s
Details
Release Docker Image / Create Max-Perf Manifest (pull_request) Successful in 16s
Details
Release Docker Image / Build linux-amd64 (max-perf) (push) Successful in 23m1s
Details
Release Docker Image / Build linux-arm64 (max-perf) (push) Successful in 20m17s
Details
Release Docker Image / Create Max-Perf Manifest (push) Successful in 20s
Details
2025-10-15 03:12:28 +00:00 Compare
nex merged commit dc047b635f into main 2025-10-15 03:12:54 +00:00
nex deleted branch ginger/fix-systemd-reload 2025-10-15 03:12:54 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Bug

Something isn't working as intended

  
Cherry-picking

Commits picked from other conduit projects

  
Database

This requires or includes changes to the database

  
Dependencies

Something dependency related

  
Dependencies/Renovate

Automatic dependency upgrades by Renovate

  
Difficulty
Easy
Low difficulty to implement - touches few parts of the codebase, low complexity

  
Difficulty
Hard
High difficulty to implement - touches many parts of the codebase, high complexity

  
Difficulty
Medium
Medium difficulty to implement - touches more parts of the codebase, higher complexity

  
Documentation

Improvements or additions to documentation

  
Enhancement

New feature or request

  
Good first issue

Good for newcomers

  
Help wanted

Additional eyes and keyboards are required for this one

  
Inherited

Issues that have been inhereted from the project pre-fork

  
Matrix/Administration

Features pertaining to homeserver administration

  
Matrix/Appservices

Features pertaining to the appservice API

  
Matrix/Auth

Features pertaining to authentication

  
Matrix/Client

Features pertaining to client-to-server interactions

  
Matrix/Core

Issues relating to core matrix functionality, such as state resolution and PDU formats

  
Matrix/Federation

Features pertaining to server-to-server interactions

  
Matrix/Hydra

Issues related to room version 12 and related changes (temporary label)

  
Matrix/MSC

Features pertaining to unstable matrix features

  
Matrix/Media

Features pertaining to media interactions

  
Meta

Related to housekeeping, maintenance, or other repo-meta.

  
Meta/CI

Issues related to CI changes

  
Meta/Packaging

Packaging

  
Priority
Blocking
This issue is blocking the next release

  
Priority
High
This issue is very important

  
Priority
Low
This issue is of a rather low priority

  
Security

This item is related to general security

  
Status/Blocked

This pull request or issue is currently blocked from being merged/closed

  
Status
Confirmed
This issue has enough information and is confirmed

  
Status
Duplicate
This issue or pull request already exists

  
Status
Invalid
This issue doesn't seem right

  
Status
Needs Investigation
This issue needs further investigation

  
To-Merge

   
Wont fix

This will not be worked on

  
old/ci/cd

Ci/CD

Archived

  
old/rust

Pull requests that update Rust code

Archived

No labels
Bug
Cherry-picking
Database
Dependencies
Dependencies/Renovate
Difficulty
Easy
Difficulty
Hard
Difficulty
Medium
Documentation
Enhancement
Good first issue
Help wanted
Inherited
Matrix/Administration
Matrix/Appservices
Matrix/Auth
Matrix/Client
Matrix/Core
Matrix/Federation
Matrix/Hydra
Matrix/MSC
Matrix/Media
Meta
Meta/CI
Meta/Packaging
Priority
Blocking
Priority
High
Priority
Low
Security
Status/Blocked
Status
Confirmed
Status
Duplicate
Status
Invalid
Status
Needs Investigation
To-Merge
Wont fix
old/ci/cd
old/rust
Milestone
Clear milestone
No items
No milestone
0.5.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
continuwuation/continuwuity!1073
No description provided.